Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Concurrent Segment Search] Dynamically enable/disable concurrent search #7356

Closed
sohami opened this issue May 2, 2023 · 3 comments · Fixed by #7956
Closed

[Concurrent Segment Search] Dynamically enable/disable concurrent search #7356

sohami opened this issue May 2, 2023 · 3 comments · Fixed by #7956
Assignees
Labels
distributed framework enhancement Enhancement or improvement to existing feature or request

Comments

@sohami
Copy link
Collaborator

sohami commented May 2, 2023

Provide a mechanism to dynamically toggle between concurrent and sequential search. This can be a cluster settings in phase 1 and later can be evaluated if it makes sense to have it at index level. It will be useful to have this during initial phase where users can evaluate if concurrent search mechanism is something which helps their use case or not. For more context #6798

@jed326
Copy link
Collaborator

jed326 commented May 26, 2023

@anasalkouz I can start taking a look at this one, could you assign this to me?

@kotwanikunal
Copy link
Member

@anasalkouz I can start taking a look at this one, could you assign this to me?

Assigned it to you @jed326

@jed326
Copy link
Collaborator

jed326 commented May 30, 2023

At first glance 2 problems stand out.

  1. What should the behavior of the setting be when the feature flag is disabled? There is probably some precedence set by however segrep or other feature flags handle this so will look into that.
  2. This will probably need to work with [Concurrent Segment Search] - Implement concurrent aggregations support without profile option #7353 as well but we can look into that once [Concurrent Segment Search]: Implement concurrent aggregations support without profile option #7514 is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment