-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change INDEX_SEARCHER threadpool to resizable to support task resource tracking #7502
Conversation
cd88594
to
68beb41
Compare
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
68beb41
to
1480aba
Compare
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## main #7502 +/- ##
============================================
- Coverage 70.54% 70.44% -0.11%
+ Complexity 59713 59674 -39
============================================
Files 4896 4896
Lines 286798 286798
Branches 41331 41331
============================================
- Hits 202334 202033 -301
- Misses 67761 68098 +337
+ Partials 16703 16667 -36
|
222c08f
to
e8f742a
Compare
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Seems like a known flaky test #7401 |
6c013b5
to
56790fb
Compare
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
56790fb
to
0ba0ae3
Compare
...ClusterTest/java/org/opensearch/action/admin/cluster/node/tasks/ConcurrentSearchTasksIT.java
Outdated
Show resolved
Hide resolved
...ClusterTest/java/org/opensearch/action/admin/cluster/node/tasks/ConcurrentSearchTasksIT.java
Outdated
Show resolved
Hide resolved
Have we figure out (and fixed) the flakiness part? thank you |
5f4554c
to
6be87cb
Compare
@reta Yep the flakiness and your last round of comments are both addressed now. |
6be87cb
to
6bad124
Compare
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
server/src/test/java/org/opensearch/tasks/TaskResourceTrackingServiceTests.java
Show resolved
Hide resolved
…e tracking Signed-off-by: Jay Deng <jayd0104@gmail.com>
6bad124
to
3e11e38
Compare
Gradle Check (Jenkins) Run Completed with:
|
…ort task resource tracking (opensearch-project#7502) (cherry picked from commit 054cccd) Signed-off-by: Jay Deng <jayd0104@gmail.com>
…ort task resource tracking (opensearch-project#7502) (cherry picked from commit 054cccd) Signed-off-by: Jay Deng <jayd0104@gmail.com>
…e tracking (opensearch-project#7502) Signed-off-by: Jay Deng <jayd0104@gmail.com>
…ort task resource tracking (opensearch-project#7502) (opensearch-project#7765) (cherry picked from commit 054cccd) Signed-off-by: Jay Deng <jayd0104@gmail.com>
…e tracking (opensearch-project#7502) Signed-off-by: Jay Deng <jayd0104@gmail.com> Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Description
Change the INDEX_SEARCHER threadpool type to
QueueResizableOpenSearchThreadPoolExecutor
to support task resource tracking for concurrent segment search.ConcurrentSearchTasksIT
test to validate that multiple threads are reporting resource stats for the same task with concurrent search enabled. Note that this is separate from [Concurrent Segment Search] Enable Search ITs with Concurrent Segment Search #7440.testStartingTrackingHandlesMultipleThreadsPerTask
toTaskResourceTrackingServiceTests
to check thatTaskResourceTrackingService
properly handles multiple threads per task.We already have existing tests for passing thread context between threadpools so I did not add any more tests related to
TaskAwareRunnable
.Related Issues
#7425
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.
Resolves #7425