Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Upgrade] Lucene 9.5.0 release #6078

Merged
merged 3 commits into from
Jan 31, 2023
Merged

[Upgrade] Lucene 9.5.0 release #6078

merged 3 commits into from
Jan 31, 2023

Conversation

nknize
Copy link
Collaborator

@nknize nknize commented Jan 30, 2023

Upgrades to official release of Lucene 9.5.

@nknize nknize added non-issue bugs / unexpected behaviors that end up non issues; audit trail simple changes that aren't issues >upgrade Label used when upgrading library dependencies (e.g., Lucene) v3.0.0 Issues and PRs related to version 3.0.0 skip-changelog labels Jan 30, 2023
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@andrross andrross added v2.6.0 'Issues and PRs related to version v2.6.0' and removed v3.0.0 Issues and PRs related to version 3.0.0 labels Jan 30, 2023
@andrross
Copy link
Member

Swapped around the labels because I assume this will go into the 2.6 release. @nknize please correct me if I'm wrong.

There does seem to be a related test failure though:

REPRODUCE WITH: ./gradlew ':modules:analysis-common:test' --tests "org.opensearch.analysis.common.HighlighterWithAnalyzersTests.testPhrasePrefix" -Dtests.seed=68DBA7498B3491B9 -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=en -Dtests.timezone=Pacific/Auckland -Druntime.java=19

org.opensearch.analysis.common.HighlighterWithAnalyzersTests > testPhrasePrefix FAILED
    java.lang.AssertionError: 
    Expected: map containing ["field0"->ANYTHING]
         but: map was []
        at __randomizedtesting.SeedInfo.seed([68DBA7498B3491B9:183142C700C72FBE]:0)
        at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:18)
        at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:6)
        at org.opensearch.test.hamcrest.OpenSearchAssertions.assertHighlight(OpenSearchAssertions.java:430)
        at org.opensearch.test.hamcrest.OpenSearchAssertions.assertHighlight(OpenSearchAssertions.java:420)
        at org.opensearch.test.hamcrest.OpenSearchAssertions.assertHighlight(OpenSearchAssertions.java:399)
        at org.opensearch.analysis.common.HighlighterWithAnalyzersTests.testPhrasePrefix(HighlighterWithAnalyzersTests.java:283)

@nknize
Copy link
Collaborator Author

nknize commented Jan 30, 2023

Swapped around the labels because I assume this will go into the 2.6 release. @nknize please correct me if I'm wrong.
👍🏻

There does seem to be a related test failure though

Fixed up MultiPhrasePrefixQuery based on some QueryVisitor and highlighter changes; should be passing now...

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: null ❌
  • URL: null
  • CommitID: 856560e
    Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
    Is the failure a flaky test unrelated to your change?

1 similar comment
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: null ❌
  • URL: null
  • CommitID: 856560e
    Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
    Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

Upgrades to official release of Lucene 9.5.

Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.indices.replication.SegmentReplicationRelocationIT.testPrimaryRelocationWithSegRepFailure

@nknize nknize merged commit 8d5d2e6 into opensearch-project:main Jan 31, 2023
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-6078-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 8d5d2e6b10db66784279c72715fb643f0fed38d0
# Push it to GitHub
git push --set-upstream origin backport/backport-6078-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-6078-to-2.x.

nknize added a commit to nknize/OpenSearch that referenced this pull request Jan 31, 2023
Upgrades to official release of Lucene 9.5.

Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
nknize added a commit to nknize/OpenSearch that referenced this pull request Jan 31, 2023
Upgrades to official release of Lucene 9.5.

Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
Co-authord-by: Suraj Singh <surajrider@gmail.com>
nknize added a commit to nknize/OpenSearch that referenced this pull request Jan 31, 2023
Upgrades to official release of Lucene 9.5.

Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
Co-authord-by: Suraj Singh <surajrider@gmail.com>
nknize added a commit to nknize/OpenSearch that referenced this pull request Jan 31, 2023
Upgrades to official release of Lucene 9.5.

Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
Co-authord-by: Suraj Singh <surajrider@gmail.com>
andrross pushed a commit that referenced this pull request Jan 31, 2023
* [Upgrade] Lucene 9.5.0 release (#6078)

Upgrades to official release of Lucene 9.5.

Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
Co-authord-by: Suraj Singh <surajrider@gmail.com>

* Bump antlr4 from 4.9.3 to 4.11.1

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>

---------

Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
Co-authored-by: Andriy Redko <andriy.redko@aiven.io>
@dreamer-89 dreamer-89 mentioned this pull request Feb 9, 2023
6 tasks
mch2 added a commit to mch2/OpenSearch that referenced this pull request Mar 5, 2023
Poojita-Raj added a commit to Poojita-Raj/OpenSearch that referenced this pull request Mar 7, 2023
Poojita-Raj added a commit to Poojita-Raj/OpenSearch that referenced this pull request Mar 8, 2023
dreamer-89 added a commit to dreamer-89/OpenSearch that referenced this pull request May 11, 2023
dreamer-89 added a commit to dreamer-89/OpenSearch that referenced this pull request May 16, 2023
dreamer-89 added a commit to dreamer-89/OpenSearch that referenced this pull request May 16, 2023
dreamer-89 added a commit to dreamer-89/OpenSearch that referenced this pull request May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch non-issue bugs / unexpected behaviors that end up non issues; audit trail simple changes that aren't issues skip-changelog >upgrade Label used when upgrading library dependencies (e.g., Lucene) v2.6.0 'Issues and PRs related to version v2.6.0'
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants