Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Couple of cases of infinite recursion #15387

Closed
dk2k opened this issue Aug 23, 2024 · 2 comments · Fixed by #15446
Closed

[BUG] Couple of cases of infinite recursion #15387

dk2k opened this issue Aug 23, 2024 · 2 comments · Fixed by #15446
Labels
bug Something isn't working Indexing Indexing, Bulk Indexing and anything related to indexing untriaged

Comments

@dk2k
Copy link
Contributor

dk2k commented Aug 23, 2024

Describe the bug

Methods getFloatVectorValues(String field) and getByteVectorValues(String field) in TranslogLeafReader class

Related component

Indexing

To Reproduce

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior

Additional Details

Plugins
Please list all plugins currently enabled.

Screenshots
If applicable, add screenshots to help explain your problem.

Host/Environment (please complete the following information):

  • OS: [e.g. iOS]
  • Version [e.g. 22]

Additional context
Add any other context about the problem here.

@dk2k dk2k added bug Something isn't working untriaged labels Aug 23, 2024
@github-actions github-actions bot added the Indexing Indexing, Bulk Indexing and anything related to indexing label Aug 23, 2024
@dbwiddis
Copy link
Member

@Override
public FloatVectorValues getFloatVectorValues(String field) throws IOException {
return getFloatVectorValues(field);
}
@Override
public ByteVectorValues getByteVectorValues(String field) throws IOException {
return getByteVectorValues(field);
}

Introduced in #6078 but the diff shows something similar prior to that:

@Override
public VectorValues getVectorValues(String field) throws IOException {
return getVectorValues(field);
}

That was introduced in #1109

It's not clear what it should be. @nknize any idea?

@dblock
Copy link
Member

dblock commented Aug 25, 2024

I would at least raise a not implemented exception here to begin with, I imagine all tests will pass, this code is obviously not executed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Indexing Indexing, Bulk Indexing and anything related to indexing untriaged
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants