Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add version check during task submission for bwc for static threshold setting #5633

Merged

Conversation

dhwanilpatel
Copy link
Contributor

@dhwanilpatel dhwanilpatel commented Dec 26, 2022

Signed-off-by: Dhwanil Patel dhwanip@amazon.com

Description

  • Changed version of the ClusterManagerThrottlingException.

  • BWC for thresholds set via static setting

    When throttling threshold setting is set via static setting (yml) file, it can be updated and feature can throttle the task even when older nodes are present in cluster.

    Added check on task submission of configured task for throttling to check for version check. If older nodes are present, it will not perform throttling to provide backward compatibility.

    Once all nodes are higher than 2.5.0, it will start throttling based on threshold and wont be disabled again.

Issues Resolved

#479

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

… setting

Signed-off-by: Dhwanil Patel <dhwanip@amazon.com>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@codecov-commenter
Copy link

codecov-commenter commented Dec 26, 2022

Codecov Report

Merging #5633 (31fb3a0) into main (35605c6) will decrease coverage by 0.21%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main    #5633      +/-   ##
============================================
- Coverage     71.16%   70.94%   -0.22%     
+ Complexity    58621    58461     -160     
============================================
  Files          4757     4757              
  Lines        279194   279202       +8     
  Branches      40316    40318       +2     
============================================
- Hits         198675   198078     -597     
- Misses        64302    64875     +573     
- Partials      16217    16249      +32     
Impacted Files Coverage Δ
.../main/java/org/opensearch/OpenSearchException.java 92.57% <ø> (+0.20%) ⬆️
...h/cluster/service/ClusterManagerTaskThrottler.java 89.65% <100.00%> (+1.04%) ⬆️
.../org/opensearch/client/indices/AnalyzeRequest.java 31.00% <0.00%> (-45.00%) ⬇️
...opensearch/persistent/PersistentTasksExecutor.java 22.22% <0.00%> (-44.45%) ⬇️
...nsearch/index/shard/IndexShardClosedException.java 66.66% <0.00%> (-33.34%) ⬇️
...arch/search/aggregations/pipeline/LinearModel.java 23.07% <0.00%> (-30.77%) ⬇️
.../search/aggregations/pipeline/HoltLinearModel.java 20.33% <0.00%> (-28.82%) ⬇️
.../java/org/opensearch/index/reindex/RemoteInfo.java 51.37% <0.00%> (-27.53%) ⬇️
...opensearch/index/reindex/BulkByScrollResponse.java 48.38% <0.00%> (-27.42%) ⬇️
...va/org/opensearch/client/sniff/SnifferBuilder.java 72.72% <0.00%> (-27.28%) ⬇️
... and 459 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@shwetathareja shwetathareja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comments. thanks @dhwanilpatel

Signed-off-by: Dhwanil Patel <dhwanip@amazon.com>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

Signed-off-by: Dhwanil Patel <dhwanip@amazon.com>
Signed-off-by: Dhwanil Patel <dhwanip@amazon.com>
@shwetathareja shwetathareja merged commit ea1cc9d into opensearch-project:main Dec 27, 2022
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@shwetathareja shwetathareja added the backport 2.x Backport to 2.x branch label Dec 28, 2022
opensearch-trigger-bot bot pushed a commit that referenced this pull request Dec 28, 2022
… setting (#5633)

* Add version check during task submission for bwc for static threshold setting

Signed-off-by: Dhwanil Patel <dhwanip@amazon.com>
(cherry picked from commit ea1cc9d)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
shwetathareja pushed a commit that referenced this pull request Jan 3, 2023
… setting (#5633) (#5647)

* Add version check during task submission for bwc for static threshold setting

Signed-off-by: Dhwanil Patel <dhwanip@amazon.com>
(cherry picked from commit ea1cc9d)
kotwanikunal pushed a commit that referenced this pull request Jan 25, 2023
… setting (#5633) (#5647)

* Add version check during task submission for bwc for static threshold setting

Signed-off-by: Dhwanil Patel <dhwanip@amazon.com>
(cherry picked from commit ea1cc9d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants