Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change deprecation message for API parameter value 'master_node' of parameter 'metric' #2880

Merged
merged 1 commit into from
Apr 12, 2022
Merged

Change deprecation message for API parameter value 'master_node' of parameter 'metric' #2880

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Change deprecation message for API parameter value 'master_node' of p… 
…arameter 'metric'

Signed-off-by: Tianli Feng <ftianli@amazon.com>
  • Loading branch information
Tianli Feng committed Apr 12, 2022
commit 85db8f8581a88d6a3b5e01a9ab62d0c0d8fd148f
2 changes: 1 addition & 1 deletion rest-api-spec/src/main/resources/rest-api-spec/test/cluster.state/20_filtering.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,7 @@ setup:
cluster.state:
metric: [ master_node, version ]
allowed_warnings:
- 'Parameter [master_timeout] is deprecated and will be removed in 3.0. To support inclusive language, please use [cluster_manager_timeout] instead.'
- 'Assigning [master_node] to parameter [metric] is deprecated and will be removed in 3.0. To support inclusive language, please use [cluster_manager_node] instead.'

- match: { cluster_uuid: $cluster_uuid }
- is_true: master_node
Expand Down
2 changes: 1 addition & 1 deletion server/src/main/java/org/opensearch/rest/action/admin/cluster/RestClusterRerouteAction.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ public RestClusterRerouteAction(SettingsFilter settingsFilter) {
// It's used to log deprecation when request parameter 'metric' contains 'master_node', or request parameter 'master_timeout' is used.
private static final DeprecationLogger deprecationLogger = DeprecationLogger.getLogger(RestClusterRerouteAction.class);
private static final String DEPRECATED_MESSAGE_MASTER_NODE =
"Deprecated value [master_node] used for parameter [metric]. To promote inclusive language, please use [cluster_manager_node] instead. It will be unsupported in a future major version.";
"Assigning [master_node] to parameter [metric] is deprecated and will be removed in 3.0. To support inclusive language, please use [cluster_manager_node] instead.";

@Override
public List<Route> routes() {
Expand Down
2 changes: 1 addition & 1 deletion server/src/main/java/org/opensearch/rest/action/admin/cluster/RestClusterStateAction.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ public RestClusterStateAction(SettingsFilter settingsFilter) {
// It's used to log deprecation when request parameter 'metric' contains 'master_node', or request parameter 'master_timeout' is used.
private static final DeprecationLogger deprecationLogger = DeprecationLogger.getLogger(RestClusterStateAction.class);
private static final String DEPRECATED_MESSAGE_MASTER_NODE =
"Deprecated value [master_node] used for parameter [metric]. To promote inclusive language, please use [cluster_manager_node] instead. It will be unsupported in a future major version.";
"Assigning [master_node] to parameter [metric] is deprecated and will be removed in 3.0. To support inclusive language, please use [cluster_manager_node] instead.";

@Override
public String getName() {
Expand Down