Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change deprecation message for API parameter value 'master_node' of parameter 'metric' #2880

Merged
merged 1 commit into from
Apr 12, 2022
Merged

Change deprecation message for API parameter value 'master_node' of parameter 'metric' #2880

merged 1 commit into from
Apr 12, 2022

Conversation

tlfeng
Copy link
Collaborator

@tlfeng tlfeng commented Apr 12, 2022 •
edited
Loading

Description

Issues Resolved

The test failure of org.opensearch.test.rest.ClientYamlTestSuiteIT" -Dtests.method="test {p0=cluster.state/20_filtering/Filtering the cluster state returns cluster_uuid at the top level regardless of metric filters}, see #2875 (comment) for detail.
Related to #2878

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@tlfeng tlfeng requested a review from a team as a code owner April 12, 2022 21:06
Change deprecation message for API parameter value 'master_node' of p…
85db8f8 
…arameter 'metric'

Signed-off-by: Tianli Feng <ftianli@amazon.com>
@tlfeng tlfeng force-pushed the change-deprecation-message-metric branch from 834e2e3 to 85db8f8 Compare April 12, 2022 21:23
@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success 834e2e3421354afccc67ccc2e5b259668f618a9c
Log 4419

Reports 4419

@tlfeng tlfeng added v2.0.0 Version 2.0.0 backport 2.x Backport to 2.x branch backport 2.0 Backport to 2.0 branch :test Adding or fixing a test deprecate bug Something isn't working labels Apr 12, 2022
@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success 85db8f8
Log 4420

Reports 4420

@tlfeng tlfeng merged commit 455fad3 into opensearch-project:main Apr 12, 2022
@tlfeng tlfeng deleted the change-deprecation-message-metric branch April 12, 2022 21:58
opensearch-trigger-bot bot pushed a commit that referenced this pull request Apr 12, 2022
@github-actions
Change deprecation message for API parameter value 'master_node' of p…
72e9cef 
…arameter 'metric' (#2880)

Signed-off-by: Tianli Feng <ftianli@amazon.com>
(cherry picked from commit 455fad3)
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Apr 12, 2022
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Apr 12, 2022
@github-actions
Change deprecation message for API parameter value 'master_node' of p…
067b0b0 
…arameter 'metric' (#2880)

Signed-off-by: Tianli Feng <ftianli@amazon.com>
(cherry picked from commit 455fad3)
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Apr 12, 2022
Merged
tlfeng pushed a commit that referenced this pull request Apr 12, 2022
@opensearch-trigger-bot
Change deprecation message for API parameter value 'master_node' of p…
223d297 
…arameter 'metric' (#2880) (#2881)

Signed-off-by: Tianli Feng <ftianli@amazon.com>
(cherry picked from commit 455fad3)
tlfeng pushed a commit that referenced this pull request Apr 12, 2022
@opensearch-trigger-bot
Change deprecation message for API parameter value 'master_node' of p…
7701cf0 
…arameter 'metric' (#2880) (#2882)

Signed-off-by: Tianli Feng <ftianli@amazon.com>
(cherry picked from commit 455fad3)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@owaiskazi19 owaiskazi19 owaiskazi19 approved these changes

@VachaShah VachaShah VachaShah approved these changes

Assignees
No one assigned
Labels
backport 2.x Backport to 2.x branch backport 2.0 Backport to 2.0 branch bug Something isn't working deprecate :test Adding or fixing a test v2.0.0 Version 2.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tlfeng @opensearch-ci-bot @VachaShah @owaiskazi19