Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] [1.x] Introduce QueryPhaseSearcher extension point (SearchPlugin) #2569

Merged
merged 1 commit into from
Mar 23, 2022

Conversation

reta
Copy link
Collaborator

@reta reta commented Mar 23, 2022

Signed-off-by: Andriy Redko andriy.redko@aiven.io

Description

Backport 82fb7ab from #1931

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure 3a32d7ece173e558e71fdccbe4b4db9b7ef23717
Log 3697

Reports 3697

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
@reta reta force-pushed the issue-1286.search.plugin.1.x branch from 3a32d7e to d77a941 Compare March 23, 2022 14:05
@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success d77a941
Log 3699

Reports 3699

Copy link
Collaborator

@nknize nknize left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the whitesource checker is stalled due to github's webhook and action problems today. This LGTM. If it doesn't resolve shortly I think we should just override and merge.

@dblock dblock merged commit b997d9c into opensearch-project:1.x Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants