Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 1.x] Introduce QueryPhaseSearcher extension point (SearchPlugin) #2559

Closed
wants to merge 1 commit into from
Closed

[Backport 1.x] Introduce QueryPhaseSearcher extension point (SearchPlugin) #2559

wants to merge 1 commit into from

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 82fb7ab from #1931

@reta @github-actions
Introduce QueryPhaseSearcher extension point (SearchPlugin) (#1931)
4980ae2 
Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
(cherry picked from commit 82fb7ab)
@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure 4980ae2
Log 3664

Reports 3664

@dblock
Copy link
Member

dblock commented Mar 22, 2022 

> Task :server:compileJava
/var/CITOOL/workflow/OpenSearch_CI/PR_Checks/Gradle_Check/search/server/src/main/java/org/opensearch/search/DefaultSearchContext.java:204: error: incompatible types: boolean cannot be converted to MutableQueryTimeout
            lowLevelCancellation,
            ^

@dblock
Copy link
Member

dblock commented Mar 22, 2022

@reta Feel free to just close if you think we don't care about it in 1.x (1.4 or 1.3.1 patch if those things are to be).

@reta
Copy link
Collaborator

reta commented Mar 23, 2022

@dblock opened #2569 (needs code change, cannot modify this pull request), could you close this one please? Thanks!

@kartg
Copy link
Member

kartg commented Mar 24, 2022

Closing since the backport was merged to 1.x in #2569

@kartg kartg closed this Mar 24, 2022
@peterzhuamazon peterzhuamazon deleted the backport/backport-1931-to-1.x branch July 8, 2022 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@opensearch-ci-bot @dblock @reta @kartg