Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating contributing.md #244

Closed
wants to merge 104 commits into from
Closed
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
104 commits
Select commit Hold shift + click to select a range
1f40732
[PURIFY] Remove x-pack directory
nknize Jan 26, 2021
35ecb4e
[PURIFY] Remove docs directory (#3)
nknize Jan 30, 2021
65cd98f
Cleanup build-scan, remove publish scan to elastic server (#1) (#4)
nknize Jan 30, 2021
0b8ed9f
[PURIFY] remove all trace of x-pack eql (#5)
nknize Jan 30, 2021
33c8ac7
[PURIFY] remove issue, pr tempalte to avoid confusion, we could add o…
nknize Jan 30, 2021
4bdad9f
[PURIFY] update build.gradle files to ensure build completes; gradle …
nknize Jan 30, 2021
6744e35
Cleanup build script to exclude security-authorization-engine (#8) (#8)
nknize Jan 30, 2021
16ae5f1
[PURIFY] remove all trace of x-pack enrichment processor (#9)
nknize Jan 30, 2021
712a80e
[PURIFY] remove all trace of x-pack async-search (#10)
nknize Jan 30, 2021
b3f56c6
[PURIFY] remove all trace of x-pack ccr (#11)
nknize Jan 30, 2021
809e5aa
Remove the Elastic license file, all checks for this license and the …
nknize Jan 30, 2021
399219b
[PURIFY] remove all trace of x-pack graph (#13)
nknize Jan 30, 2021
7505372
[PURIFY] remove all trace of x-pack ml (#14)
nknize Jan 30, 2021
70c38d4
[PURIFY] Add InferenceConfig to org.elasticsearch.client.analytics (#15)
nknize Jan 30, 2021
4d4f198
[PURIFY] remove all trace of x-pack security (#16)
nknize Jan 30, 2021
a352543
[PURIFY] remove all trace of x-pack rollups (#17)
nknize Jan 30, 2021
e139bda
[PURIFY] remove all trace of x-pack sql (#18)
nknize Jan 30, 2021
e1d4d79
[PURIFY] remove all trace of x-pack migration (#19)
nknize Jan 30, 2021
055d5ca
[PURIFY] remove all trace of x-pack index lifecycle management (#20)
nknize Jan 30, 2021
1827eff
[PURIFY] remove all trace of x-pack watcher (#21)
nknize Jan 30, 2021
dbcf046
[PURIFY] remove all trace of x-pack monitoring (#22)
nknize Jan 30, 2021
73a7bab
[PURIFY] Remove remaining x-pack license. (#25)
adnapibar Feb 2, 2021
4190b40
[PURIFY] Revert "Move data stream transport and rest action to xpack …
nknize Feb 2, 2021
fb9fe9f
[PURIFY] remove all trace of x-pack transforms (#31)
nknize Feb 2, 2021
b55d8f4
[PURIFY] fix GetDataStreamsRequestTests build failure
nknize Feb 2, 2021
f8144e1
[PURIFY] Remove the AuthorizationEnginePlugin from examples. (#26)
adnapibar Feb 2, 2021
d496925
Fix compilation issues for tests. (#29)
adnapibar Feb 2, 2021
5dd4a82
[PURIFY] Cleanup build and unblock HLRC integration tests (#33)
nknize Feb 3, 2021
d9ae459
Adding initial CI workflow for search (#35)
saratvemulapalli Feb 3, 2021
2be74b1
[TEST] Fix unit test failure in RestHighLevelClientTests (#36)
Feb 4, 2021
f49fb70
[TEST] fix DeleteDataStreamRequestTests failure (#37)
nknize Feb 4, 2021
7aa4833
Remove license option in gradlew command (#41)
harold-wang Feb 4, 2021
fa86308
Remove x-pack from build, distribution and packaging. (#43)
adnapibar Feb 4, 2021
7e42224
Removing _reload_search_analyzers related changes since the related x…
setiah Feb 5, 2021
914d30e
Fixing Rest Converters Tests after x-pack removal (#54)
saratvemulapalli Feb 6, 2021
23d2e50
Remove license statement from CONTRIBUTING.md (#58)
harold-wang Feb 8, 2021
f2f1bfa
Revert back refresh policy in RequestConverters. (#55)
adnapibar Feb 8, 2021
6f90868
Remove unused imports in RemoteClustersIT and InternalTestCluster
nknize Feb 8, 2021
9bed5c2
[DOCS] temporarily comment verifyDocsLuceneVersion in qa:verify-versi…
nknize Feb 8, 2021
ac45e3f
Mute AnalyticsAggsIT test failure
nknize Feb 8, 2021
94301ea
[MUTE] AwaitsFix failing tests
nknize Feb 9, 2021
2a901cc
Remove packaging tests for the x-pack command line tools. (#56)
adnapibar Feb 9, 2021
ae1727d
Remove x-pack aggregations. (#59)
adnapibar Feb 9, 2021
1bbc9b4
Remove x-pack data-frame analytics hlrc. (#62)
adnapibar Feb 9, 2021
6712670
Remove ILM policy from GetDataStreamAction Response. (#63)
adnapibar Feb 9, 2021
be00040
Ensure ReplicationOperation notify listener once (#68256)
dnhatn Jan 31, 2021
95e87ae
Fix search template request (#43509)
jdconrad Jun 25, 2019
bcb5c7f
Lower skip version for token_cound yaml test (#68583)
Feb 8, 2021
55b539e
Revert previous change to fix import issue.
adnapibar Feb 9, 2021
dac6af6
Remove unused imports in ArchiveTests
nknize Feb 9, 2021
7da7e34
Fix unit test for removal of x-pack aggregations. (#65)
adnapibar Feb 9, 2021
aab68fa
[PURIFY] Remove ProtocolUtils, TimeUtils, and XContentSource from HLR…
nknize Feb 9, 2021
a40924f
[PURIFY] Remove x-pack feature flag from yaml test (#68)
nknize Feb 9, 2021
5172928
Remove testcase testSearchWithBasicLicensedQuery since basic license …
harold-wang Feb 9, 2021
8654d6e
Remove UnusedImports (#76)
harold-wang Feb 10, 2021
52a3f37
Bring back the REST specs for data streams. (#78)
adnapibar Feb 10, 2021
75162da
Remove unused imports after x-pack feature flag removed from yaml tes…
Feb 10, 2021
6ba8876
[TEST] Fix Feature Flags in Test Framework and SortTemplates yaml fai…
nknize Feb 10, 2021
88542a7
Run precommit and unit tests as part of github actions. (#84)
adnapibar Feb 11, 2021
8f069ed
Removing FreezeIndex related code since its x-pack counterpart is rem…
abbashus Feb 11, 2021
93f3dd5
Only run pre-commit checks in GitHub actions. (#94)
adnapibar Feb 12, 2021
b29f47b
Fixing Bwc checks for 7.10.3 (#93)
saratvemulapalli Feb 12, 2021
482b187
Temporary fix for license check path for debian packaging. (#97)
adnapibar Feb 15, 2021
7114dd3
Disable plugincli feature (#101)
adnapibar Feb 15, 2021
baf563f
Update CONTRIBUTING.md
CEHENKLE Feb 18, 2021
7710ba2
Update CONTRIBUTING.md
CEHENKLE Feb 18, 2021
d135245
Support for continious integration with Jenkins (#96)
Feb 18, 2021
3b27a82
Create DEVELOPER_GUIDE.md
CEHENKLE Feb 19, 2021
460b564
Update CONTRIBUTING.md
CEHENKLE Feb 19, 2021
f22769e
Update CONTRIBUTING.md
CEHENKLE Feb 19, 2021
e1538b7
Update CONTRIBUTING.md
CEHENKLE Feb 19, 2021
601c734
Update CONTRIBUTING.md
CEHENKLE Feb 19, 2021
098fa0c
Update CONTRIBUTING.md
CEHENKLE Feb 19, 2021
fd36020
Remove any non oss from build, package, and distribution (#102)
nknize Feb 22, 2021
e607275
Style, accessibility, typo fixes (#109)
stockholmux Feb 23, 2021
4960dc9
Add version number to fork sentence
jcgraybill Feb 23, 2021
d4b12e7
"licensed" -> "released"
jcgraybill Feb 23, 2021
ca549b2
Remove x-pact from RESI API username and password (#117)
harold-wang Feb 23, 2021
d7e6aa0
Update signoff message (#121)
harold-wang Feb 24, 2021
5515b07
Update CI workflow to work on new infra (#123)
peternied Feb 24, 2021
462a0f1
Update .gitignore
peterzhuamazon Feb 24, 2021
e66c684
Update .gitignore
peterzhuamazon Feb 24, 2021
fba2d4c
Disable BWC checks. (#130)
Feb 24, 2021
ead8891
Create CODE_OF_CONDUCT.md (#124)
CEHENKLE Feb 25, 2021
547fdcb
Update developer guide (#136)
harold-wang Mar 1, 2021
29d5b00
Add script to perform signoff check between commits (#152)
peternied Mar 1, 2021
c50e8c8
[Rename] server/src/main/java/org/apache (#162)
nknize Mar 2, 2021
7a10440
Revert "[Rename] server/src/main/java/org/apache (#162)"
nknize Mar 2, 2021
3f2b7e5
Update CONTRIBUTING.md
CEHENKLE Mar 3, 2021
011b577
Update CONTRIBUTING.md
CEHENKLE Mar 3, 2021
dbb6c35
Update CONTRIBUTING.md
CEHENKLE Mar 3, 2021
6341605
Update CONTRIBUTING.md
CEHENKLE Mar 3, 2021
e0be0ea
Update CODE_OF_CONDUCT.md
CEHENKLE Mar 3, 2021
0fd5ef0
Update CONTRIBUTING.md
CEHENKLE Mar 4, 2021
d6855da
Dummy commit to test the CI/CD workflow
bbarani Mar 4, 2021
8efc8e0
Update .gitignore
peterzhuamazon Mar 4, 2021
8ed6084
Fixing transport deserialization with oss distribution (#218)
saratvemulapalli Mar 5, 2021
8f87920
Update LICENSE.txt (#227)
CEHENKLE Mar 6, 2021
ab729f5
Merge branch 'main' into Updating-CONTRIBUTING.md
CEHENKLE Mar 9, 2021
6deeff2
Update DEVELOPER_GUIDE.md
CEHENKLE Mar 10, 2021
dc351cd
Update DEVELOPER_GUIDE.md
CEHENKLE Mar 10, 2021
8661b61
Update DEVELOPER_GUIDE.md
CEHENKLE Mar 11, 2021
0673f50
Update DEVELOPER_GUIDE.md
CEHENKLE Mar 11, 2021
a2119e8
Update DEVELOPER_GUIDE.md
CEHENKLE Mar 15, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Removing _reload_search_analyzers related changes since the related x…
…-pack support is removed (#48)
  • Loading branch information
setiah authored Feb 5, 2021
commit 7e42224a12c1e8996eb7d03cec6f2956a9e30274
Original file line number Diff line number Diff line change
Expand Up @@ -72,8 +72,6 @@
import org.elasticsearch.client.indices.PutComposableIndexTemplateRequest;
import org.elasticsearch.client.indices.PutIndexTemplateRequest;
import org.elasticsearch.client.indices.PutMappingRequest;
import org.elasticsearch.client.indices.ReloadAnalyzersRequest;
import org.elasticsearch.client.indices.ReloadAnalyzersResponse;
import org.elasticsearch.client.indices.ResizeRequest;
import org.elasticsearch.client.indices.ResizeResponse;
import org.elasticsearch.client.indices.SimulateIndexTemplateRequest;
Expand Down Expand Up @@ -1837,30 +1835,6 @@ public Cancellable deleteIndexTemplateAsync(DeleteComposableIndexTemplateRequest
options, AcknowledgedResponse::fromXContent, listener, emptySet());
}

/**
* Synchronously calls the _reload_search_analyzers API
*
* @param request the request
* @param options the request options (e.g. headers), use {@link RequestOptions#DEFAULT} if nothing needs to be customized
*/
public ReloadAnalyzersResponse reloadAnalyzers(ReloadAnalyzersRequest request, RequestOptions options) throws IOException {
return restHighLevelClient.performRequestAndParseEntity(request, IndicesRequestConverters::reloadAnalyzers, options,
ReloadAnalyzersResponse::fromXContent, emptySet());
}

/**
* Asynchronously calls the _reload_search_analyzers API
* @param request the request
* @param options the request options (e.g. headers), use {@link RequestOptions#DEFAULT} if nothing needs to be customized
* @param listener the listener to be notified upon request completion
* @return cancellable that may be used to cancel the request
*/
public Cancellable reloadAnalyzersAsync(ReloadAnalyzersRequest request, RequestOptions options,
ActionListener<ReloadAnalyzersResponse> listener) {
return restHighLevelClient.performRequestAsyncAndParseEntity(request, IndicesRequestConverters::reloadAnalyzers, options,
ReloadAnalyzersResponse::fromXContent, listener, emptySet());
}

/**
* Synchronously calls the delete alias api
* @param request the request
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,6 @@
import org.elasticsearch.client.indices.PutIndexTemplateRequest;
import org.elasticsearch.client.indices.PutComposableIndexTemplateRequest;
import org.elasticsearch.client.indices.PutMappingRequest;
import org.elasticsearch.client.indices.ReloadAnalyzersRequest;
import org.elasticsearch.client.indices.ResizeRequest;
import org.elasticsearch.client.indices.SimulateIndexTemplateRequest;
import org.elasticsearch.client.indices.UnfreezeIndexRequest;
Expand Down Expand Up @@ -806,15 +805,6 @@ static Request deleteIndexTemplate(DeleteComposableIndexTemplateRequest deleteIn
return request;
}

static Request reloadAnalyzers(ReloadAnalyzersRequest reloadAnalyzersRequest) {
String endpoint = RequestConverters.endpoint(reloadAnalyzersRequest.getIndices(), "_reload_search_analyzers");
Request request = new Request(HttpPost.METHOD_NAME, endpoint);
RequestConverters.Params parameters = new RequestConverters.Params();
parameters.withIndicesOptions(reloadAnalyzersRequest.indicesOptions());
request.addParameters(parameters.asMap());
return request;
}

static Request deleteAlias(DeleteAliasRequest deleteAliasRequest) {
String endpoint = new RequestConverters.EndpointBuilder()
.addPathPart(deleteAliasRequest.getIndex())
Expand Down

This file was deleted.

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -88,8 +88,6 @@
import org.elasticsearch.client.indices.PutComposableIndexTemplateRequest;
import org.elasticsearch.client.indices.PutIndexTemplateRequest;
import org.elasticsearch.client.indices.PutMappingRequest;
import org.elasticsearch.client.indices.ReloadAnalyzersRequest;
import org.elasticsearch.client.indices.ReloadAnalyzersResponse;
import org.elasticsearch.client.indices.SimulateIndexTemplateRequest;
import org.elasticsearch.client.indices.SimulateIndexTemplateResponse;
import org.elasticsearch.client.indices.UnfreezeIndexRequest;
Expand Down Expand Up @@ -1996,16 +1994,6 @@ public void testFreezeAndUnfreeze() throws IOException {
assertTrue(unfreeze.isAcknowledged());
}

public void testReloadAnalyzer() throws IOException {
createIndex("test", Settings.EMPTY);
RestHighLevelClient client = highLevelClient();

ReloadAnalyzersResponse reloadResponse = execute(new ReloadAnalyzersRequest("test"), client.indices()::reloadAnalyzers,
client.indices()::reloadAnalyzersAsync);
assertNotNull(reloadResponse.shards());
assertTrue(reloadResponse.getReloadedDetails().containsKey("test"));
}

public void testDeleteAlias() throws IOException {
String index = "test";
createIndex(index, Settings.EMPTY);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,6 @@
import org.elasticsearch.client.indices.PutIndexTemplateRequest;
import org.elasticsearch.client.indices.PutMappingRequest;
import org.elasticsearch.client.indices.RandomCreateIndexGenerator;
import org.elasticsearch.client.indices.ReloadAnalyzersRequest;
import org.elasticsearch.client.indices.ResizeRequest;
import org.elasticsearch.client.indices.rollover.RolloverRequest;
import org.elasticsearch.common.CheckedFunction;
Expand Down Expand Up @@ -1236,23 +1235,6 @@ public void testDeleteTemplateRequest() {
Assert.assertThat(request.getEntity(), nullValue());
}

public void testReloadAnalyzers() {
String[] indices = RequestConvertersTests.randomIndicesNames(1, 5);
StringJoiner endpoint = new StringJoiner("/", "/", "");
if (CollectionUtils.isEmpty(indices) == false) {
endpoint.add(String.join(",", indices));
}
ReloadAnalyzersRequest reloadRequest = new ReloadAnalyzersRequest(indices);
Map<String, String> expectedParams = new HashMap<>();
RequestConvertersTests.setRandomIndicesOptions(reloadRequest::setIndicesOptions, reloadRequest::indicesOptions,
expectedParams);
Request request = IndicesRequestConverters.reloadAnalyzers(reloadRequest);
Assert.assertThat(request.getMethod(), equalTo(HttpPost.METHOD_NAME));
Assert.assertThat(request.getEndpoint(), equalTo(endpoint + "/_reload_search_analyzers"));
Assert.assertThat(request.getParameters(), equalTo(expectedParams));
Assert.assertThat(request.getEntity(), nullValue());
}

public void testDeleteAlias() {
DeleteAliasRequest deleteAliasRequest = new DeleteAliasRequest(randomAlphaOfLength(4), randomAlphaOfLength(4));

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,6 @@
import org.elasticsearch.client.RequestOptions;
import org.elasticsearch.client.RestHighLevelClient;
import org.elasticsearch.client.SyncedFlushResponse;
import org.elasticsearch.client.core.BroadcastResponse.Shards;
import org.elasticsearch.client.core.ShardsAcknowledgedResponse;
import org.elasticsearch.client.indices.AnalyzeRequest;
import org.elasticsearch.client.indices.AnalyzeResponse;
Expand Down Expand Up @@ -85,9 +84,6 @@
import org.elasticsearch.client.indices.PutIndexTemplateRequest;
import org.elasticsearch.client.indices.PutComposableIndexTemplateRequest;
import org.elasticsearch.client.indices.PutMappingRequest;
import org.elasticsearch.client.indices.ReloadAnalyzersRequest;
import org.elasticsearch.client.indices.ReloadAnalyzersResponse;
import org.elasticsearch.client.indices.ReloadAnalyzersResponse.ReloadDetails;
import org.elasticsearch.client.indices.SimulateIndexTemplateRequest;
import org.elasticsearch.client.indices.SimulateIndexTemplateResponse;
import org.elasticsearch.client.indices.UnfreezeIndexRequest;
Expand Down Expand Up @@ -3172,79 +3168,6 @@ public void onFailure(Exception e) {
assertTrue(latch.await(30L, TimeUnit.SECONDS));
}

public void testReloadSearchAnalyzers() throws Exception {
RestHighLevelClient client = highLevelClient();
{
CreateIndexResponse createIndexResponse = client.indices().create(new CreateIndexRequest("index"), RequestOptions.DEFAULT);
assertTrue(createIndexResponse.isAcknowledged());
}

{
// tag::reload-analyzers-request
ReloadAnalyzersRequest request = new ReloadAnalyzersRequest("index"); // <1>
// end::reload-analyzers-request

// tag::reload-analyzers-request-indicesOptions
request.setIndicesOptions(IndicesOptions.strictExpandOpen()); // <1>
// end::reload-analyzers-request-indicesOptions

// tag::reload-analyzers-execute
ReloadAnalyzersResponse reloadResponse = client.indices().reloadAnalyzers(request, RequestOptions.DEFAULT);
// end::reload-analyzers-execute

// tag::reload-analyzers-response
Shards shards = reloadResponse.shards(); // <1>
Map<String, ReloadDetails> reloadDetails = reloadResponse.getReloadedDetails(); // <2>
ReloadDetails details = reloadDetails.get("index"); // <3>
String indexName = details.getIndexName(); // <4>
Set<String> indicesNodes = details.getReloadedIndicesNodes(); // <5>
Set<String> analyzers = details.getReloadedAnalyzers(); // <6>
// end::reload-analyzers-response
assertNotNull(shards);
assertEquals("index", indexName);
assertEquals(1, indicesNodes.size());
assertEquals(0, analyzers.size());

// tag::reload-analyzers-execute-listener
ActionListener<ReloadAnalyzersResponse> listener =
new ActionListener<ReloadAnalyzersResponse>() {
@Override
public void onResponse(ReloadAnalyzersResponse reloadResponse) {
// <1>
}

@Override
public void onFailure(Exception e) {
// <2>
}
};
// end::reload-analyzers-execute-listener

// Replace the empty listener by a blocking listener in test
final CountDownLatch latch = new CountDownLatch(1);
listener = new LatchedActionListener<>(listener, latch);

// tag::reload-analyzers-execute-async
client.indices().reloadAnalyzersAsync(request, RequestOptions.DEFAULT, listener); // <1>
// end::reload-analyzers-execute-async

assertTrue(latch.await(30L, TimeUnit.SECONDS));
}

{
// tag::reload-analyzers-notfound
try {
ReloadAnalyzersRequest request = new ReloadAnalyzersRequest("does_not_exist");
client.indices().reloadAnalyzers(request, RequestOptions.DEFAULT);
} catch (ElasticsearchException exception) {
if (exception.status() == RestStatus.BAD_REQUEST) {
// <1>
}
}
// end::reload-analyzers-notfound
}
}

@SuppressWarnings("unused")
public void testDeleteAlias() throws Exception {
RestHighLevelClient client = highLevelClient();
Expand Down