Updating contributing.md #244

CEHENKLE · 2021-03-09T21:13:10Z

Issue #, if available:

Description of changes:

Merging new contributing file, including splitting out the developer guide content.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

This commit removes the doc directory

Co-authored-by: Huan Jiang <huanji@amazon.com>

This commit removes all trace of EQL from the sanitized fork.

…later (#10) (#6) Co-authored-by: Huan Jiang <huanji@amazon.com>

…check fails (#7)

* Cleanup build-scan, remove publish scan to elastic server * Cleanup build script to exclude security-authorization-engine which test has dependency on xpack * Cleanup build script to exclude security-authorization-engine which test has dependency on xpack Co-authored-by: Huan Jiang <huanji@amazon.com>

This commit removes all trace of the Elastic licensed enrichment processor.

This commit removes all trace of Elastic licensed asyc-search

This committ removes all trace of Elastic licensed CCR.

…license REST APIs. (#12) Co-authored-by: Rabi Panda <rabipanda@icloud.com>

This commit removes all trace of Elastic licensed graph feature

This commit removes all trace of x-pack ml.

This commits adds InferenceConfig back to org.elasticsearch.client.analytics for use in InferencePipelineAggregationBuilder.

This commit removes all trace of the security high level rest client and other reference to x-pack security Co-authored-by: Rabi Panda <rabipanda@icloud.com>

This commit removes all trace of Elastic licensed rollups

This commit removes all trace of Elastic licensed SQL

This commit removes all trace of Elastic licensed Migration

This commit removes all trace of Elastic licensed ILM.

This commit removes all trace of Elastic licensed watcher

This commit removes all trace of Elastic licensed monitoring

…(#59593)" (#28) This commit reverts commit 2a89e13. Relicensing data streams from OSS to XPack.

This commit removes all trace of Elastic licensed transforms.

This fixes the constructor for IndexNameExpressionResolver to pass in Settings.EMPTY to a ThreadContext used by the resolver.

Some of the tests that use the x-pack code are failing compilation. This PR cleans up the references to fix the issue.

This commit cleans up the following: * Remove unused imports * Remove ILM settings in hlrc testCluster formation * Comment out security users settings in ElasticsearchNode creation for build-tools tests

* fix testProvidedNamedXContents by modifying the assertion

This reverts commit c50e8c8 which went should have merged to the rename branch instead of the main branch.

Anna and Dave's feedback incorporated.

Henri's comments

Renaming

replaced renameme

Signed-off-by: Sarat Vemulapalli <vemsarat@amazon.com>

updating to Apache 2.0 License from https://www.apache.org/licenses/LICENSE-2.0.txt

odfe-release-bot · 2021-03-09T21:14:02Z

Request for Admin to accept this test.

Renaming for OpenSearch

2nd pass renaming

setiah · 2021-03-11T02:12:31Z

DEVELOPER_GUIDE.md

+First and foremost, opening an issue and discussing your change before you make it is the best way to smooth the PR process.  This will prevent a rejection because someone else is already working on the problem, or because the solution is incompatable with our architectual direction.
+
+Additionally:
+1) Plesae make sure you've run `./gradlew check` before submitting.  The better tested your change is, the higher our confidence will be in it.


nit: we may want to replace this with ./gradlew precommit initially if the gradle check is not working.

Yeah, it's a little sticky. At the top of the testing section, we also tell people to run gradlew check. So I've added more warnings to the test suite, and some language on line 194 to use ./gradlew precomit while we're in pre-alpha.

DEVELOPER_GUIDE.md

adnapibar · 2021-03-11T03:04:14Z

DEVELOPER_GUIDE.md

@@ -75,7 +75,7 @@ dozen extra jars.

 ## Project Tools

-JDK 14 is required to build RENAMEME. You must have a JDK 14 installed
+JDK 14 is required to build OpenSearch. You must have a JDK 14 installed
 with the environment variable `JAVA_HOME` referencing the path to Java home for
 your JDK 14 installation. By default, tests use the same runtime as `JAVA_HOME`.
 However, since RENNAMEME supports JDK 8, the build supports compiling with


Probably need replacing 'RENNAMEME' with OpenSearch

Fixed, thanks.

peternied · 2021-03-13T16:00:47Z

This pull request will need to be re-parented since the history of main is being rewritten. See our slack channel for details on that process.

odfe-release-bot · 2021-03-15T17:11:38Z

❌ DCO Check Failed
Run ./dev-tools/signoff-check.sh remotes/origin/main 0673f504fabe07478de622e65a6335f02341ccce to check locally
Use git commit with -s to add 'Signed-of-by: {EMAIL}' on impacted commits

odfe-release-bot · 2021-03-15T23:57:03Z

❌ DCO Check Failed
Run ./dev-tools/signoff-check.sh remotes/origin/main a2119e83381ff93088b7273a12887a5f10dcc4de to check locally
Use git commit with -s to add 'Signed-of-by: {EMAIL}' on impacted commits

CEHENKLE · 2021-03-17T06:19:36Z

Closed as part of #323

Signed-off-by: Andriy Redko <andriy.redko@aiven.io> Signed-off-by: Andriy Redko <andriy.redko@aiven.io>

…opensearch-project#234) * Add support to parse sub-aggregations from filter/nested aggregations Signed-off-by: Abhinav Nath <abhinavnath@ymail.com> * Add USER_GUIDE.md Signed-off-by: Abhinav Nath <abhinavnath@ymail.com> * Add DCO Signed-off-by: Abhinav Nath <abhinavnath@ymail.com> * Add link to USER_GUIDE.md in README.md Signed-off-by: Abhinav Nath <abhinavnath@ymail.com> * Add changelog and changelog verifier (opensearch-project#239) Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com> Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com> Signed-off-by: Abhinav Nath <abhinavnath@ymail.com> * Set javadoc encoding to utf-8 (opensearch-project#50) (opensearch-project#241) Signed-off-by: Meetesh Kumawat<kmeetesh@gmail.com> Signed-off-by: meetesh <kmeetesh@gmail.com> Signed-off-by: Meetesh Kumawat<kmeetesh@gmail.com> Signed-off-by: meetesh <kmeetesh@gmail.com> Signed-off-by: Abhinav Nath <abhinavnath@ymail.com> * Update Jackson Databind to 2.13.4.2 (addressing CVE-2022-42003) (opensearch-project#240) Signed-off-by: Andriy Redko <andriy.redko@aiven.io> Signed-off-by: Andriy Redko <andriy.redko@aiven.io> Signed-off-by: Abhinav Nath <abhinavnath@ymail.com> * Updates changelog for dependabot PRs (opensearch-project#247) * Updates changelog for dependabot PRs Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com> * Adding dependabot label for workflow Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com> Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com> Signed-off-by: Abhinav Nath <abhinavnath@ymail.com> * Update tests to use JUnit's Assert (opensearch-project#244) Signed-off-by: Andriy Redko <andriy.redko@aiven.io> Signed-off-by: Andriy Redko <andriy.redko@aiven.io> Signed-off-by: Abhinav Nath <abhinavnath@ymail.com> * Update literature around changelog (opensearch-project#242) * Update literature Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com> * Removing pr template and updating language Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com> Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com> Co-authored-by: Daniel (dB.) Doubrovkine <dblock@amazon.com> Signed-off-by: Abhinav Nath <abhinavnath@ymail.com> * Bump grgit-gradle from 4.0.1 to 5.0.0 (opensearch-project#243) * Bump grgit-gradle from 4.0.1 to 5.0.0 Bumps [grgit-gradle](https://github.com/ajoberstar/grgit) from 4.0.1 to 5.0.0. - [Release notes](https://github.com/ajoberstar/grgit/releases) - [Commits](ajoberstar/grgit@4.0.1...5.0.0) --- updated-dependencies: - dependency-name: org.ajoberstar.grgit:grgit-gradle dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * Update changelog Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com> Signed-off-by: Abhinav Nath <abhinavnath@ymail.com> * Add DCO Signed-off-by: Abhinav Nath <abhinavnath@ymail.com> * Update CHANGELOG and README Signed-off-by: Abhinav Nath <abhinavnath@ymail.com> * Add DCO Signed-off-by: Abhinav Nath <abhinavnath@ymail.com> * Add DCO Signed-off-by: Abhinav Nath <abhinavnath@ymail.com> * Fix CHANGLOG and README TOC Signed-off-by: Abhinav Nath <abhinavnath@ymail.com> Signed-off-by: Abhinav Nath <abhinavnath@ymail.com> Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com> Signed-off-by: Meetesh Kumawat<kmeetesh@gmail.com> Signed-off-by: meetesh <kmeetesh@gmail.com> Signed-off-by: Andriy Redko <andriy.redko@aiven.io> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com> Co-authored-by: Meetesh Kumawat <kmeetesh@gmail.com> Co-authored-by: Andriy Redko <andriy.redko@aiven.io> Co-authored-by: Daniel (dB.) Doubrovkine <dblock@amazon.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>

nknize and others added 30 commits January 29, 2021 22:30

[PURIFY] Remove x-pack directory

1f40732

[PURIFY] Remove docs directory (#3)

35ecb4e

This commit removes the doc directory

Cleanup build-scan, remove publish scan to elastic server (#1) (#4)

65cd98f

Co-authored-by: Huan Jiang <huanji@amazon.com>

[PURIFY] remove all trace of x-pack eql (#5)

0b8ed9f

This commit removes all trace of EQL from the sanitized fork.

[PURIFY] remove issue, pr tempalte to avoid confusion, we could add o…

33c8ac7

…later (#10) (#6) Co-authored-by: Huan Jiang <huanji@amazon.com>

[PURIFY] update build.gradle files to ensure build completes; gradle …

4bdad9f

…check fails (#7)

[PURIFY] remove all trace of x-pack enrichment processor (#9)

16ae5f1

This commit removes all trace of the Elastic licensed enrichment processor.

[PURIFY] remove all trace of x-pack async-search (#10)

712a80e

This commit removes all trace of Elastic licensed asyc-search

[PURIFY] remove all trace of x-pack ccr (#11)

b3f56c6

This committ removes all trace of Elastic licensed CCR.

Remove the Elastic license file, all checks for this license and the …

809e5aa

…license REST APIs. (#12) Co-authored-by: Rabi Panda <rabipanda@icloud.com>

[PURIFY] remove all trace of x-pack graph (#13)

399219b

This commit removes all trace of Elastic licensed graph feature

[PURIFY] remove all trace of x-pack ml (#14)

7505372

This commit removes all trace of x-pack ml.

[PURIFY] Add InferenceConfig to org.elasticsearch.client.analytics (#15)

70c38d4

This commits adds InferenceConfig back to org.elasticsearch.client.analytics for use in InferencePipelineAggregationBuilder.

[PURIFY] remove all trace of x-pack security (#16)

4d4f198

This commit removes all trace of the security high level rest client and other reference to x-pack security Co-authored-by: Rabi Panda <rabipanda@icloud.com>

[PURIFY] remove all trace of x-pack rollups (#17)

a352543

This commit removes all trace of Elastic licensed rollups

[PURIFY] remove all trace of x-pack sql (#18)

e139bda

This commit removes all trace of Elastic licensed SQL

[PURIFY] remove all trace of x-pack migration (#19)

e1d4d79

This commit removes all trace of Elastic licensed Migration

[PURIFY] remove all trace of x-pack index lifecycle management (#20)

055d5ca

This commit removes all trace of Elastic licensed ILM.

[PURIFY] remove all trace of x-pack watcher (#21)

1827eff

This commit removes all trace of Elastic licensed watcher

[PURIFY] remove all trace of x-pack monitoring (#22)

dbcf046

This commit removes all trace of Elastic licensed monitoring

[PURIFY] Remove remaining x-pack license. (#25)

73a7bab

[PURIFY] Revert "Move data stream transport and rest action to xpack …

4190b40

…(#59593)" (#28) This commit reverts commit 2a89e13. Relicensing data streams from OSS to XPack.

[PURIFY] remove all trace of x-pack transforms (#31)

fb9fe9f

This commit removes all trace of Elastic licensed transforms.

[PURIFY] fix GetDataStreamsRequestTests build failure

b55d8f4

This fixes the constructor for IndexNameExpressionResolver to pass in Settings.EMPTY to a ThreadContext used by the resolver.

[PURIFY] Remove the AuthorizationEnginePlugin from examples. (#26)

f8144e1

Fix compilation issues for tests. (#29)

d496925

Some of the tests that use the x-pack code are failing compilation. This PR cleans up the references to fix the issue.

[PURIFY] Cleanup build and unblock HLRC integration tests (#33)

5dd4a82

This commit cleans up the following: * Remove unused imports * Remove ILM settings in hlrc testCluster formation * Comment out security users settings in ElasticsearchNode creation for build-tools tests

Adding initial CI workflow for search (#35)

d9ae459

[TEST] Fix unit test failure in RestHighLevelClientTests (#36)

2be74b1

* fix testProvidedNamedXContents by modifying the assertion

nknize and others added 11 commits March 2, 2021 15:28

Revert "[Rename] server/src/main/java/org/apache (#162)"

7a10440

This reverts commit c50e8c8 which went should have merged to the rename branch instead of the main branch.

Update CONTRIBUTING.md

3f2b7e5

Anna and Dave's feedback incorporated.

Update CONTRIBUTING.md

011b577

Henri's comments

Update CONTRIBUTING.md

dbb6c35

Update CONTRIBUTING.md

6341605

Renaming

Update CODE_OF_CONDUCT.md

e0be0ea

replaced renameme

Update CONTRIBUTING.md

0fd5ef0

Dummy commit to test the CI/CD workflow

d6855da

Update .gitignore

8efc8e0

Fixing transport deserialization with oss distribution (#218)

8ed6084

Signed-off-by: Sarat Vemulapalli <vemsarat@amazon.com>

Update LICENSE.txt (#227)

8f87920

updating to Apache 2.0 License from https://www.apache.org/licenses/LICENSE-2.0.txt

CEHENKLE added 3 commits March 9, 2021 13:16

Merge branch 'main' into Updating-CONTRIBUTING.md

ab729f5

Update DEVELOPER_GUIDE.md

6deeff2

Renaming for OpenSearch

Update DEVELOPER_GUIDE.md

dc351cd

2nd pass renaming

setiah reviewed Mar 11, 2021

View reviewed changes

DEVELOPER_GUIDE.md Outdated Show resolved Hide resolved

adnapibar reviewed Mar 11, 2021

View reviewed changes

CEHENKLE added 2 commits March 10, 2021 21:04

Update DEVELOPER_GUIDE.md

8661b61

Update DEVELOPER_GUIDE.md

0673f50

peternied force-pushed the main branch from 8bdabbf to 807d0e3 Compare March 13, 2021 17:21

Update DEVELOPER_GUIDE.md

a2119e8

CEHENKLE closed this Mar 17, 2021

CEHENKLE deleted the Updating-CONTRIBUTING.md branch March 17, 2021 06:19

ritty27 pushed a commit to ritty27/OpenSearch that referenced this pull request May 12, 2024

Update tests to use JUnit's Assert (opensearch-project#244)

3068b76

Signed-off-by: Andriy Redko <andriy.redko@aiven.io> Signed-off-by: Andriy Redko <andriy.redko@aiven.io>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Updating contributing.md #244

Updating contributing.md #244

CEHENKLE commented Mar 9, 2021 •

edited

Loading

odfe-release-bot commented Mar 9, 2021

setiah Mar 11, 2021

CEHENKLE Mar 11, 2021

adnapibar Mar 11, 2021

CEHENKLE Mar 11, 2021

peternied commented Mar 13, 2021

odfe-release-bot commented Mar 15, 2021

odfe-release-bot commented Mar 15, 2021

CEHENKLE commented Mar 17, 2021

Updating contributing.md #244

Updating contributing.md #244

Conversation

CEHENKLE commented Mar 9, 2021 • edited Loading

odfe-release-bot commented Mar 9, 2021

setiah Mar 11, 2021

Choose a reason for hiding this comment

CEHENKLE Mar 11, 2021

Choose a reason for hiding this comment

adnapibar Mar 11, 2021

Choose a reason for hiding this comment

CEHENKLE Mar 11, 2021

Choose a reason for hiding this comment

peternied commented Mar 13, 2021

odfe-release-bot commented Mar 15, 2021

odfe-release-bot commented Mar 15, 2021

CEHENKLE commented Mar 17, 2021

CEHENKLE commented Mar 9, 2021 •

edited

Loading