[Backport 2.19] task cancellation and query phase result consumer changes #19787
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ch-project#17576) * add validation check for SBP service Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * add SBP should not handle the task tracking UT Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * add CHANGELOG entry Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * fix broken UT Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * address comments Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> --------- Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>
…ject#18426) --------- Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>
…t#19066) --------- Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>
…arch-project#19231) --------- Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>
kaushalmahi12
requested review from
a team,
Bukhtawar,
CEHENKLE,
Rishikesh1159,
anasalkouz,
andrross,
ashking94,
cwperks,
dbwiddis,
gbbafna,
jed326,
kotwanikunal,
mch2,
msfroh,
owaiskazi19,
reta,
sachinpkale,
saratvemulapalli,
shwetathareja and
sohami
as code owners
Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>
Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>
|
Tagging @jainankitk for review & merge of backports |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## 2.19 #19787 +/- ##
============================================
- Coverage 72.03% 71.90% -0.13%
+ Complexity 66024 65953 -71
============================================
Files 5342 5342
Lines 307283 307343 +60
Branches 44845 44851 +6
============================================
- Hits 221346 221001 -345
- Misses 67462 67888 +426
+ Partials 18475 18454 -21 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jainankitk
approved these changes
Oct 27, 2025
This was referenced Oct 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a backport for the following PRs. This backport will introduce cancellation checks in aggregation phase and improve circuit breaking mechanism at the co-ordinator node.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.