-
Couldn't load subscription status.
- Fork 2.3k
Add circuit breaking logic for shard level results #19066
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add circuit breaking logic for shard level results #19066
Conversation
…rdinator node Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>
Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>
8c954ec to
b0ed156
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #19066 +/- ##
============================================
- Coverage 72.87% 72.85% -0.02%
+ Complexity 69380 69359 -21
============================================
Files 5647 5647
Lines 319084 319111 +27
Branches 46157 46159 +2
============================================
- Hits 232528 232491 -37
- Misses 67729 67753 +24
- Partials 18827 18867 +40 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
server/src/main/java/org/opensearch/action/search/QueryPhaseResultConsumer.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>
|
❌ Gradle check result for 75e731d: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>
|
❌ Gradle check result for a73bbd3: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
server/src/main/java/org/opensearch/action/search/AbstractSearchAsyncAction.java
Show resolved
Hide resolved
|
❌ Gradle check result for a73bbd3: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>
|
❌ Gradle check result for 83eba80: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>
|
❌ Gradle check result for 927b6c8: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>
|
❌ Gradle check result for c96e172: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
Test is still failing: |
…t#19066) --------- Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>
…t#19066) --------- Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>
…t#19066) --------- Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>
…t#19066) --------- Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>
…t#19066) --------- Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>
Description
This change addresses the OOM issue which is triggered when the coordinator node buffers the
batched_reduce_sizenumber of shard level results. In the current logic the circuit breaking logic is missing and can easily cause OOMs for memory intensive queries.This change at a high level does the following
Current search request flow concerning this PR
Related Issues
Resolves #18999
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.