Skip to content

Conversation

@asimmahmood1
Copy link
Contributor

@asimmahmood1 asimmahmood1 commented Sep 30, 2025

Description

Related Issues

Resolves #19123

Check List

  • Functionality includes testing.
  • [n/a] API changes companion pull request created, if applicable.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions
Copy link
Contributor

❌ Gradle check result for 89c3fba: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@asimmahmood1 asimmahmood1 moved this from Todo to In-Review in Performance Roadmap Sep 30, 2025
@github-actions
Copy link
Contributor

❌ Gradle check result for 13ec937: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-project-automation github-project-automation bot moved this from In-Review to Done in Performance Roadmap Sep 30, 2025
@asimmahmood1 asimmahmood1 reopened this Sep 30, 2025
@github-project-automation github-project-automation bot moved this from Done to In Progress in Performance Roadmap Sep 30, 2025
@asimmahmood1
Copy link
Contributor Author

@github-actions
Copy link
Contributor

✅ Gradle check result for 13ec937: SUCCESS

@codecov
Copy link

codecov bot commented Sep 30, 2025

Codecov Report

❌ Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 72.94%. Comparing base (83b2a6d) to head (13ec937).
⚠️ Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
...a/org/opensearch/index/mapper/DateFieldMapper.java 87.50% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #19480      +/-   ##
============================================
+ Coverage     72.93%   72.94%   +0.01%     
  Complexity    70236    70236              
============================================
  Files          5700     5700              
  Lines        322150   322157       +7     
  Branches      46616    46618       +2     
============================================
+ Hits         234966   235007      +41     
+ Misses        68225    68163      -62     
- Partials      18959    18987      +28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@jainankitk jainankitk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jainankitk jainankitk merged commit 08ed9ee into opensearch-project:main Sep 30, 2025
61 of 63 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in Performance Roadmap Sep 30, 2025
asimmahmood1 added a commit to asimmahmood1/opensearch-benchmark-workloads that referenced this pull request Oct 8, 2025
* to test out skiplist based date histogram
* skiplist is enabled by default http_logs has @timestamp field: opensearch-project/OpenSearch#19480
* TODO: add index.sort.field option on @timestamp

Signed-off-by: Asim Mahmood <asim.seng@gmail.com>
rishabh6788 pushed a commit to opensearch-project/opensearch-benchmark-workloads that referenced this pull request Oct 8, 2025
* to test out skiplist based date histogram
* skiplist is enabled by default http_logs has @timestamp field: opensearch-project/OpenSearch#19480
* TODO: add index.sort.field option on @timestamp

Signed-off-by: Asim Mahmood <asim.seng@gmail.com>
opensearch-trigger-bot bot pushed a commit to opensearch-project/opensearch-benchmark-workloads that referenced this pull request Oct 8, 2025
* to test out skiplist based date histogram
* skiplist is enabled by default http_logs has @timestamp field: opensearch-project/OpenSearch#19480
* TODO: add index.sort.field option on @timestamp

Signed-off-by: Asim Mahmood <asim.seng@gmail.com>
(cherry picked from commit bf2c36e)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
rishabh6788 pushed a commit to opensearch-project/opensearch-benchmark-workloads that referenced this pull request Oct 8, 2025
* to test out skiplist based date histogram
* skiplist is enabled by default http_logs has @timestamp field: opensearch-project/OpenSearch#19480
* TODO: add index.sort.field option on @timestamp


(cherry picked from commit bf2c36e)

Signed-off-by: Asim Mahmood <asim.seng@gmail.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
peteralfonsi pushed a commit to peteralfonsi/OpenSearch that referenced this pull request Oct 15, 2025
asimmahmood1 added a commit to asimmahmood1/OpenSearch that referenced this pull request Oct 16, 2025
asimmahmood1 added a commit to asimmahmood1/OpenSearch that referenced this pull request Oct 16, 2025
…ensearch-project#19480)"

Fixes opensearch-project#19660

This reverts commit 08ed9ee.

Signed-off-by: Asim Mahmood <asim.seng@gmail.com>
asimmahmood1 added a commit to asimmahmood1/OpenSearch that referenced this pull request Oct 16, 2025
…ensearch-project#19480)"

Fixes opensearch-project#19660

This reverts commit 08ed9ee.

Signed-off-by: Asim Mahmood <asim.seng@gmail.com>
asimmahmood1 added a commit to asimmahmood1/OpenSearch that referenced this pull request Oct 16, 2025
…ensearch-project#19480)"

This reverts commit 08ed9ee.

Fixes opensearch-project#19660

Signed-off-by: Asim Mahmood <asim.seng@gmail.com>
asimmahmood1 added a commit to asimmahmood1/OpenSearch that referenced this pull request Oct 16, 2025
…ensearch-project#19480)"

This reverts commit 08ed9ee.

Fixes opensearch-project#19660

Signed-off-by: Asim Mahmood <asim.seng@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Enhancement or improvement to existing feature or request Indexing Indexing, Bulk Indexing and anything related to indexing Roadmap:Search Project-wide roadmap label Search:Aggregations Search:Performance v3.3.0

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Enable skip_list by default in 3.3

2 participants