Skip to content

Conversation

@karenyrx
Copy link
Contributor

@karenyrx karenyrx commented Sep 29, 2025

Description

  1. Bump up the protobuf version
  2. Fix compilation errors.
  3. Fix a bug for Inner Hits.
  4. Remove Sort-related protobufs as they are incorrect and will be fixed in a future PR.

Related Issues

Part of #19446

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@karenyrx karenyrx force-pushed the 0.18.0protos branch 2 times, most recently from f358e81 to e7458bf Compare September 29, 2025 03:21
Signed-off-by: Karen X <karenxyr@gmail.com>
@github-actions
Copy link
Contributor

✅ Gradle check result for 28b984c: SUCCESS

@codecov
Copy link

codecov bot commented Sep 29, 2025

Codecov Report

❌ Patch coverage is 95.16129% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.98%. Comparing base (28689b7) to head (fef4f49).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...oto/request/search/InnerHitsBuilderProtoUtils.java 94.44% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #19447      +/-   ##
============================================
+ Coverage     72.96%   72.98%   +0.02%     
- Complexity    69969    69996      +27     
============================================
  Files          5676     5676              
  Lines        321265   321246      -19     
  Branches      46445    46439       -6     
============================================
+ Hits         234407   234460      +53     
+ Misses        67901    67830      -71     
+ Partials      18957    18956       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Karen X <karenxyr@gmail.com>
@github-actions
Copy link
Contributor

✅ Gradle check result for fef4f49: SUCCESS

@cwperks cwperks merged commit 5962128 into opensearch-project:main Sep 29, 2025
33 checks passed
karenyrx added a commit to karenyrx/OpenSearch that referenced this pull request Sep 29, 2025
…errors (opensearch-project#19447)

* upgrade to protobufs 0.18.0

Signed-off-by: Karen X <karenxyr@gmail.com>

* add tests

Signed-off-by: Karen X <karenxyr@gmail.com>

---------

Signed-off-by: Karen X <karenxyr@gmail.com>
peteralfonsi pushed a commit to peteralfonsi/OpenSearch that referenced this pull request Oct 15, 2025
…errors (opensearch-project#19447)

* upgrade to protobufs 0.18.0

Signed-off-by: Karen X <karenxyr@gmail.com>

* add tests

Signed-off-by: Karen X <karenxyr@gmail.com>

---------

Signed-off-by: Karen X <karenxyr@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants