[GRPC][Joining queries] Implement GRPC Nested query, fix InnerHits, and bump to 0.19.0 protobufs #19453
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Karen X <karenxyr@gmail.com>
github-actions
bot
added
enhancement
|
❕ Gradle check result for eb43722: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #19453 +/- ##
============================================
+ Coverage 72.93% 72.96% +0.02%
- Complexity 70236 70273 +37
============================================
Files 5700 5702 +2
Lines 322150 322202 +52
Branches 46616 46625 +9
============================================
+ Hits 234966 235084 +118
+ Misses 68225 68135 -90
- Partials 18959 18983 +24 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Karen X <karenxyr@gmail.com>
karenyrx
requested review from
a team,
Bukhtawar,
CEHENKLE,
Rishikesh1159,
anasalkouz,
andrross,
ashking94,
cwperks,
dbwiddis,
gbbafna,
jed326,
kotwanikunal,
mch2,
msfroh,
owaiskazi19,
reta,
sachinpkale,
saratvemulapalli,
shwetathareja and
sohami
as code owners
mch2
reviewed
Sep 29, 2025
...a/org/opensearch/transport/grpc/proto/request/search/query/NestedQueryBuilderProtoUtils.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Karen X <karenxyr@gmail.com>
karenyrx
force-pushed
the
0.18.0_nested
branch
from
eb43722 to
4d61048
Compare
Signed-off-by: Karen X <karenxyr@gmail.com>
karenyrx
force-pushed
the
0.18.0_nested
branch
from
003cebd to
4aa1ae3
Compare
karenyrx
commented
Sep 30, 2025
karenyrx
changed the title
Signed-off-by: Karen X <karenxyr@gmail.com>
Signed-off-by: Karen X <karenxyr@gmail.com>
mch2
approved these changes
Sep 30, 2025
peteralfonsi
pushed a commit
to peteralfonsi/OpenSearch
that referenced
this pull request
Oct 15, 2025
…nd bump to 0.19.0 protobufs (opensearch-project#19453) * upgrade to protobufs 0.18.0 Signed-off-by: Karen X <karenxyr@gmail.com> * add tests Signed-off-by: Karen X <karenxyr@gmail.com> * [GRPC][Joining queries] Implement GRPC Nested query Signed-off-by: Karen X <karenxyr@gmail.com> * package private, remove static registry and add tests Signed-off-by: Karen X <karenxyr@gmail.com> * spotless Signed-off-by: Karen X <karenxyr@gmail.com> * add changelog Signed-off-by: Karen X <karenxyr@gmail.com> * add tests Signed-off-by: Karen X <karenxyr@gmail.com> * inner hits fix and update to 0.19.0 Signed-off-by: Karen X <karenxyr@gmail.com> --------- Signed-off-by: Karen X <karenxyr@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issues
Resolves #19452
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.