Skip to content

Conversation

@andrross
Copy link
Member

The evil tests had a dependency on jimfs but did not use it anywhere, so I removed the dependency. The TranslogPolicyIT file had no corresponding build.gradle file and therefore was just dead code. The test is no longer relevant as it is related to pre-OpenSearch compatibility.

Check List

  • Functionality includes testing.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@andrross andrross requested a review from a team as a code owner September 19, 2025 23:51
@andrross andrross mentioned this pull request Sep 20, 2025
1 task
@github-actions
Copy link
Contributor

❌ Gradle check result for 02d04b3: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

The evil tests had a dependency on jimfs but did not use it anywhere, so
I removed the dependency. The TranslogPolicyIT file had no corresponding
build.gradle file and therefore was just dead code. The test is no
longer relevant as it is related to pre-OpenSearch compatibility.

Signed-off-by: Andrew Ross <andrross@amazon.com>
@github-actions
Copy link
Contributor

❌ Gradle check result for 9769906: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Contributor

❌ Gradle check result for 9769906: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Contributor

❕ Gradle check result for 9769906: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@codecov
Copy link

codecov bot commented Sep 21, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.93%. Comparing base (1f9eb87) to head (9769906).
⚠️ Report is 12 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #19347      +/-   ##
============================================
+ Coverage     72.89%   72.93%   +0.03%     
+ Complexity    69870    69868       -2     
============================================
  Files          5673     5674       +1     
  Lines        320754   320850      +96     
  Branches      46367    46383      +16     
============================================
+ Hits         233824   233998     +174     
+ Misses        68012    67901     -111     
- Partials      18918    18951      +33     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@andrross andrross merged commit b26e4c2 into opensearch-project:main Sep 22, 2025
33 of 37 checks passed
@andrross andrross deleted the qa-cleanup branch September 22, 2025 15:36
jainankitk pushed a commit to jainankitk/OpenSearch that referenced this pull request Sep 22, 2025
The evil tests had a dependency on jimfs but did not use it anywhere, so
I removed the dependency. The TranslogPolicyIT file had no corresponding
build.gradle file and therefore was just dead code. The test is no
longer relevant as it is related to pre-OpenSearch compatibility.

Signed-off-by: Andrew Ross <andrross@amazon.com>
jainankitk pushed a commit to jainankitk/OpenSearch that referenced this pull request Sep 22, 2025
The evil tests had a dependency on jimfs but did not use it anywhere, so
I removed the dependency. The TranslogPolicyIT file had no corresponding
build.gradle file and therefore was just dead code. The test is no
longer relevant as it is related to pre-OpenSearch compatibility.

Signed-off-by: Andrew Ross <andrross@amazon.com>
Signed-off-by: Ankit Jain <jainankitk@apache.org>
jainankitk pushed a commit to jainankitk/OpenSearch that referenced this pull request Sep 22, 2025
The evil tests had a dependency on jimfs but did not use it anywhere, so
I removed the dependency. The TranslogPolicyIT file had no corresponding
build.gradle file and therefore was just dead code. The test is no
longer relevant as it is related to pre-OpenSearch compatibility.

Signed-off-by: Andrew Ross <andrross@amazon.com>
Signed-off-by: Ankit Jain <jainankitk@apache.org>
asimmahmood1 pushed a commit to jainankitk/OpenSearch that referenced this pull request Sep 23, 2025
The evil tests had a dependency on jimfs but did not use it anywhere, so
I removed the dependency. The TranslogPolicyIT file had no corresponding
build.gradle file and therefore was just dead code. The test is no
longer relevant as it is related to pre-OpenSearch compatibility.

Signed-off-by: Andrew Ross <andrross@amazon.com>
pranikum pushed a commit to pranikum/OpenSearch that referenced this pull request Sep 23, 2025
The evil tests had a dependency on jimfs but did not use it anywhere, so
I removed the dependency. The TranslogPolicyIT file had no corresponding
build.gradle file and therefore was just dead code. The test is no
longer relevant as it is related to pre-OpenSearch compatibility.

Signed-off-by: Andrew Ross <andrross@amazon.com>
pranikum pushed a commit to pranikum/OpenSearch that referenced this pull request Sep 23, 2025
The evil tests had a dependency on jimfs but did not use it anywhere, so
I removed the dependency. The TranslogPolicyIT file had no corresponding
build.gradle file and therefore was just dead code. The test is no
longer relevant as it is related to pre-OpenSearch compatibility.

Signed-off-by: Andrew Ross <andrross@amazon.com>
Signed-off-by: Pranit Kumar <pranikum@amazon.com>
vinaykpud pushed a commit to vinaykpud/OpenSearch that referenced this pull request Sep 26, 2025
The evil tests had a dependency on jimfs but did not use it anywhere, so
I removed the dependency. The TranslogPolicyIT file had no corresponding
build.gradle file and therefore was just dead code. The test is no
longer relevant as it is related to pre-OpenSearch compatibility.

Signed-off-by: Andrew Ross <andrross@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants