Skip to content

Update to Gradle 9.1.0 #19329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 24, 2025
Merged

Update to Gradle 9.1.0 #19329

merged 1 commit into from
Sep 24, 2025

Conversation

@andrross
Copy link
Member

Check List

  • Functionality includes testing.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

andrross
andrross commented Sep 17, 2025
View reviewed changes
@github-actions
Copy link
Contributor

❌ Gradle check result for 15b99aa: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Contributor

❌ Gradle check result for add82a5: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Contributor

❌ Gradle check result for 79e1e2a: null

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@andrross andrross mentioned this pull request Sep 18, 2025
Open
@andrross andrross changed the title Update to Gradle 9.0.0 Update to Gradle 9.1.0 Sep 19, 2025
andrross
andrross commented Sep 19, 2025
View reviewed changes
@github-actions
Copy link
Contributor

❌ Gradle check result for a0f5913: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Contributor

❌ Gradle check result for 0079637: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Contributor

❌ Gradle check result for 6d477bd: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

andrross
andrross commented Sep 20, 2025
View reviewed changes
@opensearch-ci-bot opensearch-ci-bot mentioned this pull request Sep 19, 2025
Open
@github-actions
Copy link
Contributor

✅ Gradle check result for 6d477bd: SUCCESS

@codecov
Copy link

codecov bot commented Sep 20, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 0% with 27 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.80%. Comparing base (eb28e77) to head (22f087d).
⚠️ Report is 14 commits behind head on main.

Files with missing lines Patch % Lines
...n/java/org/opensearch/gradle/util/GradleUtils.java 0.00% 10 Missing ⚠️
...ensearch/gradle/precommit/ThirdPartyAuditTask.java 0.00% 7 Missing ⚠️
...g/opensearch/gradle/vagrant/VagrantBasePlugin.java 0.00% 4 Missing ⚠️
.../org/opensearch/gradle/test/TestWithSslPlugin.java 0.00% 2 Missing ⚠️
...e/precommit/DependencyLicensesPrecommitPlugin.java 0.00% 2 Missing ⚠️
.../opensearch/gradle/plugin/PluginBuildPlugin.groovy 0.00% 0 Missing and 1 partial ⚠️
...ensearch/gradle/tar/SymbolicLinkPreservingTar.java 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               main   #19329      +/-   ##
============================================
- Coverage     72.81%   72.80%   -0.02%     
- Complexity    69801    69811      +10     
============================================
  Files          5674     5674              
  Lines        320850   320780      -70     
  Branches      46383    46376       -7     
============================================
- Hits         233638   233544      -94     
- Misses        68264    68354      +90     
+ Partials      18948    18882      -66

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@andrross
Update to Gradle 9.1.0
22f087d 
Signed-off-by: Andrew Ross <andrross@amazon.com>
@andrross andrross marked this pull request as ready for review September 22, 2025 18:55
@andrross andrross requested review from a team, jed326 and peternied as code owners September 22, 2025 18:55
@github-actions
Copy link
Contributor

✅ Gradle check result for 22f087d: SUCCESS

jainankitk
jainankitk approved these changes Sep 23, 2025
View reviewed changes
Copy link
Contributor

@jainankitk jainankitk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, this should unblock the upgrade to JDK25!

@andrross andrross merged commit df3b3ae into opensearch-project:main Sep 24, 2025
35 of 36 checks passed
@andrross andrross deleted the gradle-9 branch September 24, 2025 16:37
This was referenced Sep 23, 2025
Open
Open
@peterzhuamazon peterzhuamazon mentioned this pull request Sep 24, 2025
Closed
andrross added a commit to andrross/OpenSearch that referenced this pull request Sep 24, 2025
@andrross
Revert back to Gradle 8.14.3
fe26a87 
Something in Gradle 9 broke the assemble workflow such that the tarballs
are not being generated. This is a minimal revert of opensearch-project#19329 to go back
to using Gradle 8.14.3 which fixes the assemble workflow.

Signed-off-by: Andrew Ross <andrross@amazon.com>
andrross added a commit to andrross/OpenSearch that referenced this pull request Sep 24, 2025
@andrross
Revert back to Gradle 8.14.3
7a4c548 
Something in Gradle 9 broke the assemble workflow such that the tarballs
are not being generated. This is a minimal revert of opensearch-project#19329 to go back
to using Gradle 8.14.3 which fixes the assemble workflow.

Signed-off-by: Andrew Ross <andrross@amazon.com>
@andrross andrross mentioned this pull request Sep 24, 2025
Merged
1 task
andrross added a commit to andrross/OpenSearch that referenced this pull request Sep 24, 2025
@andrross
Revert back to Gradle 8.14.3
1138898 
Something in Gradle 9 broke the assemble workflow such that the tarballs
are not being generated. This is a minimal revert of opensearch-project#19329 to go back
to using Gradle 8.14.3 which fixes the assemble workflow.

Signed-off-by: Andrew Ross <andrross@amazon.com>
andrross added a commit that referenced this pull request Sep 25, 2025
@andrross @jainankitk
Revert back to Gradle 8.14.3 (#19405)
7abef8c 
Something in Gradle 9 broke the assemble workflow such that the tarballs
are not being generated. This is a minimal revert of #19329 to go back
to using Gradle 8.14.3 which fixes the assemble workflow.

Signed-off-by: Andrew Ross <andrross@amazon.com>
Signed-off-by: Ankit Jain <jainankitk@apache.org>
Co-authored-by: Ankit Jain <jainankitk@apache.org>
vinaykpud pushed a commit to vinaykpud/OpenSearch that referenced this pull request Sep 26, 2025
@andrross @vinaykpud
Update to Gradle 9.1.0 (opensearch-project#19329)
37a26b4 
Signed-off-by: Andrew Ross <andrross@amazon.com>
vinaykpud pushed a commit to vinaykpud/OpenSearch that referenced this pull request Sep 26, 2025
@andrross @jainankitk @vinaykpud
Revert back to Gradle 8.14.3 (opensearch-project#19405)
cf1841e 
Something in Gradle 9 broke the assemble workflow such that the tarballs
are not being generated. This is a minimal revert of opensearch-project#19329 to go back
to using Gradle 8.14.3 which fixes the assemble workflow.

Signed-off-by: Andrew Ross <andrross@amazon.com>
Signed-off-by: Ankit Jain <jainankitk@apache.org>
Co-authored-by: Ankit Jain <jainankitk@apache.org>
karenyrx pushed a commit to karenyrx/OpenSearch that referenced this pull request Sep 29, 2025
@andrross @jainankitk @karenyrx
Revert back to Gradle 8.14.3 (opensearch-project#19405)
48051cf 
Something in Gradle 9 broke the assemble workflow such that the tarballs
are not being generated. This is a minimal revert of opensearch-project#19329 to go back
to using Gradle 8.14.3 which fixes the assemble workflow.

Signed-off-by: Andrew Ross <andrross@amazon.com>
Signed-off-by: Ankit Jain <jainankitk@apache.org>
Co-authored-by: Ankit Jain <jainankitk@apache.org>
peteralfonsi pushed a commit to peteralfonsi/OpenSearch that referenced this pull request Oct 15, 2025
@andrross @jainankitk
Revert back to Gradle 8.14.3 (opensearch-project#19405)
e1457f5 
Something in Gradle 9 broke the assemble workflow such that the tarballs
are not being generated. This is a minimal revert of opensearch-project#19329 to go back
to using Gradle 8.14.3 which fixes the assemble workflow.

Signed-off-by: Andrew Ross <andrross@amazon.com>
Signed-off-by: Ankit Jain <jainankitk@apache.org>
Co-authored-by: Ankit Jain <jainankitk@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@reta reta reta left review comments

@mch2 mch2 mch2 approved these changes

@jainankitk jainankitk jainankitk approved these changes

@jed326 jed326 Awaiting requested review from jed326 jed326 is a code owner

@peternied peternied Awaiting requested review from peternied peternied is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@andrross @reta @mch2 @jainankitk