Reverts accidental access changes in IpFieldMapper parser util #19077
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sandesh Kumar <sandeshkr419@gmail.com>
sandeshkr419
requested review from
a team,
Bukhtawar,
CEHENKLE,
Rishikesh1159,
VachaShah,
anasalkouz,
andrross,
ashking94,
cwperks,
dbwiddis,
gbbafna,
jed326,
kotwanikunal,
mch2,
msfroh,
owaiskazi19,
reta,
sachinpkale,
saratvemulapalli,
shwetathareja and
sohami
as code owners
sandeshkr419
added
non-issue
sandeshkr419
changed the title
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #19077 +/- ##
============================================
+ Coverage 72.98% 73.00% +0.02%
- Complexity 69482 69489 +7
============================================
Files 5647 5647
Lines 319137 319136 -1
Branches 46163 46163
============================================
+ Hits 232907 232981 +74
+ Misses 67391 67326 -65
+ Partials 18839 18829 -10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
asimmahmood1
approved these changes
Aug 14, 2025
rishabhmaurya
approved these changes
Aug 14, 2025
rishabhmaurya
merged commit f4e5c9d
into
opensearch-project:main
64 of 66 checks passed
RajatGupta02
pushed a commit
to RajatGupta02/OpenSearch
that referenced
this pull request
Aug 18, 2025
Signed-off-by: Sandesh Kumar <sandeshkr419@gmail.com>
karenyrx
pushed a commit
to karenyrx/OpenSearch
that referenced
this pull request
Aug 21, 2025
Signed-off-by: Sandesh Kumar <sandeshkr419@gmail.com>
atris
pushed a commit
to atris/OpenSearch
that referenced
this pull request
Aug 28, 2025
Signed-off-by: Sandesh Kumar <sandeshkr419@gmail.com>
kh3ra
pushed a commit
to kh3ra/OpenSearch
that referenced
this pull request
Sep 5, 2025
Signed-off-by: Sandesh Kumar <sandeshkr419@gmail.com>
vinaykpud
pushed a commit
to vinaykpud/OpenSearch
that referenced
this pull request
Sep 26, 2025
Signed-off-by: Sandesh Kumar <sandeshkr419@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reverts intended changes from [Star Tree] IP field search support #18671 where accidentally made a private method in IpFieldMapper as public: https://github.com/opensearch-project/OpenSearch/pull/18671/files#diff-daa7078975bbb300cf8b6a7be32603d1c3092303720b102c873c57d02f90d12bL240
Minor refactoring/cleanup in StarTreeQueryHelper.java
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.