Skip to content

[Star Tree] IP field search support #18671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 5, 2025
Merged

[Star Tree] IP field search support #18671

merged 4 commits into from
Aug 5, 2025
+134 −19

Conversation

@sandeshkr419
Copy link
Member

@sandeshkr419 sandeshkr419 commented Jul 2, 2025 •
edited
Loading

Description

Support for IP field in star-tree queries

Documentation changes: opensearch-project/documentation-website#10668

Related Issues

Resolves #16547

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions github-actions bot added enhancement Enhancement or improvement to existing feature or request Search:Aggregations v3.1.0 labels Jul 2, 2025
@sandeshkr419 sandeshkr419 changed the title ip field support [Star Tree] IP field support Jul 2, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jul 2, 2025

❌ Gradle check result for 24f8876: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@sandeshkr419 sandeshkr419 added v3.2.0 and removed v3.1.0 labels Jul 7, 2025
@sandeshkr419 sandeshkr419 marked this pull request as ready for review July 17, 2025 20:47
@github-actions github-actions bot added the v3.1.0 label Aug 5, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Aug 5, 2025

❌ Gradle check result for e217312: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@sandeshkr419
increase coverage
9377d86 
Signed-off-by: Sandesh Kumar <sandeshkr419@gmail.com>
@github-actions
Copy link
Contributor

github-actions bot commented Aug 5, 2025

✅ Gradle check result for 9377d86: SUCCESS

@sandeshkr419
Merge branch 'main' into ip
4f1e398 
Signed-off-by: Sandesh Kumar <sandeshkr419@gmail.com>
@github-actions
Copy link
Contributor

github-actions bot commented Aug 5, 2025

❌ Gradle check result for 4f1e398: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@sandeshkr419 sandeshkr419 reopened this Aug 5, 2025
@opensearch-ci-bot opensearch-ci-bot mentioned this pull request Aug 5, 2025
Closed
expani
expani reviewed Aug 5, 2025
View reviewed changes
Copy link
Contributor

@expani expani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR.

Why is there no InetAddress.nextUp/nextDown for handling IP Field range queries ?

https://github.com/opensearch-project/OpenSearch/blob/main/server/src/main/java/org/opensearch/index/mapper/IpFieldMapper.java#L465

@github-actions
Copy link
Contributor

github-actions bot commented Aug 5, 2025

❌ Gradle check result for 4f1e398: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@sandeshkr419 sandeshkr419 reopened this Aug 5, 2025
@expani
Copy link
Contributor

expani commented Aug 5, 2025

Why is there no InetAddress.nextUp/nextDown for handling IP Field range queries ?

Looks like it should be handled at https://github.com/opensearch-project/OpenSearch/blob/main/server/src/main/java/org/opensearch/search/startree/filter/RangeMatchDimFilter.java#L52-L78 as Keyword and IP will use ordinals instead of raw values.

@sandeshkr419
Merge branch 'main' into ip
32725a0 
Signed-off-by: Sandesh Kumar <sandeshkr419@gmail.com>
@sandeshkr419 sandeshkr419 mentioned this pull request Aug 5, 2025
Merged
1 task
@github-actions
Copy link
Contributor

github-actions bot commented Aug 5, 2025

❕ Gradle check result for 32725a0: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@prudhvigodithi prudhvigodithi merged commit f0e5003 into opensearch-project:main Aug 5, 2025
31 checks passed
@opensearch-ci-bot opensearch-ci-bot mentioned this pull request Aug 5, 2025
Open
@sandeshkr419 sandeshkr419 deleted the ip branch August 5, 2025 23:51
@prudhvigodithi prudhvigodithi mentioned this pull request Aug 6, 2025
Closed
23 tasks
@opensearch-ci-bot opensearch-ci-bot mentioned this pull request Aug 6, 2025
Open
@sandeshkr419 sandeshkr419 mentioned this pull request Aug 11, 2025
Open
16 tasks
This was referenced Jun 10, 2025
Open
Open
@sandeshkr419 sandeshkr419 mentioned this pull request Aug 14, 2025
Merged
3 tasks
@BrewTestBot BrewTestBot mentioned this pull request Aug 20, 2025
Merged
vinaykpud pushed a commit to vinaykpud/OpenSearch that referenced this pull request Sep 26, 2025
@sandeshkr419 @vinaykpud
[Star Tree] IP field search support (opensearch-project#18671)
67eed85 
* ip field changes

Signed-off-by: Sandesh Kumar <sandeshkr419@gmail.com>

* increase coverage

Signed-off-by: Sandesh Kumar <sandeshkr419@gmail.com>

---------

Signed-off-by: Sandesh Kumar <sandeshkr419@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bharath-techie bharath-techie bharath-techie approved these changes

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@ashking94 ashking94 Awaiting requested review from ashking94 ashking94 is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@cwperks cwperks Awaiting requested review from cwperks cwperks is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@jed326 jed326 Awaiting requested review from jed326 jed326 is a code owner

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@reta reta Awaiting requested review from reta reta is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@VachaShah VachaShah Awaiting requested review from VachaShah

+1 more reviewer

@expani expani expani approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

enhancement Enhancement or improvement to existing feature or request Search:Aggregations v3.1.0 v3.2.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Star Tree] [Search] Support for IP field in supported queries with star-tree supported aggregations

4 participants

@sandeshkr419 @expani @bharath-techie @prudhvigodithi