Remove invalid type tests for false_allow_templates
#19064
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update tests Tests Tests Cleanup Tested, cleanup Cleanup Signed-off-by: Bruce Hong <bruce.hong@glean.com>
Signed-off-by: Bruce Hong <bruce.hong@glean.com>
Signed-off-by: Bruce Hong <bruce.hong@glean.com>
Signed-off-by: Bruce Hong <bruce.hong@glean.com>
Signed-off-by: Bruce Hong <bruce.hong@glean.com>
Signed-off-by: Bruce Hong <bruce.hong@glean.com>
Signed-off-by: Bruce Hong <bruce.hong@glean.com>
Signed-off-by: gaobinlong <gbinlong@amazon.com>
Signed-off-by: gaobinlong <gbinlong@amazon.com>
…uce-hong-glean/OpenSearch into false-allow-dynamic-templates
Signed-off-by: Bruce Hong <bruce.hong@glean.com>
…uce-hong-glean/OpenSearch into false-allow-dynamic-templates
1 task
bruce-hong-glean
changed the title
false_allow_templatesfalse_allow_templates
|
❌ Gradle check result for 1dbfc1e: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
This was referenced Aug 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The PR introducing
false_allow_templatesadded tests that try to test for thefloatandintegertypes which aren't supported. This PR removes the invalid tests.Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.