-
Couldn't load subscription status.
- Fork 2.3k
Revert "Add false_allow_templates as a dynamic mapping option (#18825)" #19061
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…arch-project#18825)" This reverts commit 9f28ef8. Lots of test failures blocking PRs for the newly added yaml test. Signed-off-by: Andrew Ross <andrross@amazon.com>
|
❌ Gradle check result for 5839a56: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
Sorry about that, I didn't realize updating the version to |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #19061 +/- ##
============================================
- Coverage 72.89% 72.86% -0.04%
+ Complexity 69405 69401 -4
============================================
Files 5647 5647
Lines 319084 319084
Branches 46157 46157
============================================
- Hits 232594 232491 -103
- Misses 67700 67809 +109
+ Partials 18790 18784 -6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I have a PR removing the offending tests (they're testing invalid types and shouldn't exist to begin with) as a draft here. lmk if you'd prefer to merge in this revert, and then have the draft PR (+ these reverted changes) merged in separately, if just fix-forward with the draft PR. |
|
@bruce-hong-glean Apologies, I clicked merge on the revert before seeing your comments about having the fix. Please integrate your fix back into the original change and we'll get it merged again. Thanks! |
…arch-project#18825)" (opensearch-project#19061) This reverts commit 9f28ef8. Lots of test failures blocking PRs for the newly added yaml test. Signed-off-by: Andrew Ross <andrross@amazon.com>
…arch-project#18825)" (opensearch-project#19061) This reverts commit 9f28ef8. Lots of test failures blocking PRs for the newly added yaml test. Signed-off-by: Andrew Ross <andrross@amazon.com>
…arch-project#18825)" (opensearch-project#19061) This reverts commit 9f28ef8. Lots of test failures blocking PRs for the newly added yaml test. Signed-off-by: Andrew Ross <andrross@amazon.com>
…arch-project#18825)" (opensearch-project#19061) This reverts commit 9f28ef8. Lots of test failures blocking PRs for the newly added yaml test. Signed-off-by: Andrew Ross <andrross@amazon.com>
…arch-project#18825)" (opensearch-project#19061) This reverts commit 9f28ef8. Lots of test failures blocking PRs for the newly added yaml test. Signed-off-by: Andrew Ross <andrross@amazon.com>
This reverts commit 9f28ef8.
Lots of test failures blocking PRs for the newly added yaml test.
Example build failure: https://build.ci.opensearch.org/job/gradle-check/62321/#showFailuresLink
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.