Skip to content

Conversation

@andrross
Copy link
Member

This reverts commit 9f28ef8.

Lots of test failures blocking PRs for the newly added yaml test.

Example build failure: https://build.ci.opensearch.org/job/gradle-check/62321/#showFailuresLink

Check List

  • Functionality includes testing.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…arch-project#18825)"

This reverts commit 9f28ef8.

Lots of test failures blocking PRs for the newly added yaml test.

Signed-off-by: Andrew Ross <andrross@amazon.com>
@andrross
Copy link
Member Author

FYI @bruce-hong-glean @gaobinlong

@github-actions
Copy link
Contributor

❌ Gradle check result for 5839a56: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@bruce-hong-glean
Copy link
Contributor

bruce-hong-glean commented Aug 13, 2025

Sorry about that, I didn't realize updating the version to 3.3.0 in the test file caused my local testing to skip that test when it was executing. I'll put up a new PR with the working test.

@github-actions
Copy link
Contributor

✅ Gradle check result for 5839a56: SUCCESS

@codecov
Copy link

codecov bot commented Aug 13, 2025

Codecov Report

❌ Patch coverage is 92.30769% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 72.86%. Comparing base (8f310f5) to head (5839a56).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...va/org/opensearch/index/mapper/DocumentParser.java 91.66% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #19061      +/-   ##
============================================
- Coverage     72.89%   72.86%   -0.04%     
+ Complexity    69405    69401       -4     
============================================
  Files          5647     5647              
  Lines        319084   319084              
  Branches      46157    46157              
============================================
- Hits         232594   232491     -103     
- Misses        67700    67809     +109     
+ Partials      18790    18784       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bruce-hong-glean
Copy link
Contributor

bruce-hong-glean commented Aug 13, 2025

I have a PR removing the offending tests (they're testing invalid types and shouldn't exist to begin with) as a draft here.

lmk if you'd prefer to merge in this revert, and then have the draft PR (+ these reverted changes) merged in separately, if just fix-forward with the draft PR.

@andrross andrross merged commit dc70bf6 into opensearch-project:main Aug 13, 2025
52 of 54 checks passed
@andrross
Copy link
Member Author

@bruce-hong-glean Apologies, I clicked merge on the revert before seeing your comments about having the fix. Please integrate your fix back into the original change and we'll get it merged again. Thanks!

bruce-hong-glean added a commit to bruce-hong-glean/OpenSearch that referenced this pull request Aug 13, 2025
@andrross andrross deleted the revert-9f28ef8a branch August 13, 2025 20:19
RajatGupta02 pushed a commit to RajatGupta02/OpenSearch that referenced this pull request Aug 18, 2025
…arch-project#18825)" (opensearch-project#19061)

This reverts commit 9f28ef8.

Lots of test failures blocking PRs for the newly added yaml test.

Signed-off-by: Andrew Ross <andrross@amazon.com>
karenyrx pushed a commit to karenyrx/OpenSearch that referenced this pull request Aug 21, 2025
…arch-project#18825)" (opensearch-project#19061)

This reverts commit 9f28ef8.

Lots of test failures blocking PRs for the newly added yaml test.

Signed-off-by: Andrew Ross <andrross@amazon.com>
atris pushed a commit to atris/OpenSearch that referenced this pull request Aug 28, 2025
…arch-project#18825)" (opensearch-project#19061)

This reverts commit 9f28ef8.

Lots of test failures blocking PRs for the newly added yaml test.

Signed-off-by: Andrew Ross <andrross@amazon.com>
kh3ra pushed a commit to kh3ra/OpenSearch that referenced this pull request Sep 5, 2025
…arch-project#18825)" (opensearch-project#19061)

This reverts commit 9f28ef8.

Lots of test failures blocking PRs for the newly added yaml test.

Signed-off-by: Andrew Ross <andrross@amazon.com>
vinaykpud pushed a commit to vinaykpud/OpenSearch that referenced this pull request Sep 26, 2025
…arch-project#18825)" (opensearch-project#19061)

This reverts commit 9f28ef8.

Lots of test failures blocking PRs for the newly added yaml test.

Signed-off-by: Andrew Ross <andrross@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants