Skip to content

Fix flaky ExistsQueryBuilderTests.testToQuery #18995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 11, 2025
Merged

Fix flaky ExistsQueryBuilderTests.testToQuery #18995

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e53fa38
Fix flaky ExistsQueryBuilderTests.testToQuery
atris Aug 8, 2025
befa977
Revert CHANGELOG changes
atris Aug 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion server/src/test/java/org/opensearch/index/query/ExistsQueryBuilderTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,12 +87,20 @@ protected ExistsQueryBuilder doCreateTestQueryBuilder() {
} else {
fieldPattern = randomAlphaOfLengthBetween(1, 10);
}

// Avoid patterns that would match the derived field "raw.derived_keyword"
// which doesn't support exists queries
if (fieldPattern.startsWith("raw")) {
fieldPattern = TEXT_FIELD_NAME;
}

// also sometimes test wildcard patterns
if (randomBoolean()) {
if (randomBoolean()) {
if (randomBoolean() && !fieldPattern.equals("r") && !fieldPattern.equals("ra")) {
fieldPattern = fieldPattern + "*";
}
}

return new ExistsQueryBuilder(fieldPattern);
}

Expand Down
Loading