Fix flaky ExistsQueryBuilderTests.testToQuery #18995
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atris
requested review from
a team,
Bukhtawar,
CEHENKLE,
Rishikesh1159,
VachaShah,
anasalkouz,
andrross,
ashking94,
cwperks,
dbwiddis,
gbbafna,
jed326,
kotwanikunal,
mch2,
msfroh,
owaiskazi19,
reta,
sachinpkale,
saratvemulapalli,
shwetathareja and
sohami
as code owners
github-actions
bot
added
enhancement
|
@owaiskazi19 @andrross Please review |
github-actions
bot
added
>test-failure
github-actions
bot
added
the
flaky-test
andrross
reviewed
Aug 8, 2025
sandeshkr419
requested changes
Aug 8, 2025
There was a problem hiding this comment.
Thanks @atris for taking time to fix this flaky test.
I have a few comments to refine it more.
Also. if this was reproduce-able, can you please verify the same (before/after) by running the test in your IDE n-times.
server/src/test/java/org/opensearch/index/query/ExistsQueryBuilderTests.java
Show resolved
Hide resolved
server/src/test/java/org/opensearch/index/query/ExistsQueryBuilderTests.java
Outdated
Show resolved
Hide resolved
server/src/test/java/org/opensearch/index/query/ExistsQueryBuilderTests.java
Outdated
Show resolved
Hide resolved
Test was generating field patterns that matched raw.derived_keyword, which doesnt support exists queries. Fixed by replacing problematic patterns with TEXT_FIELD_NAME. Fixes opensearch-project#18724 Signed-off-by: Atri Sharma <atri.jiit@gmail.com>
Thanks for the review @sandeshkr419. I've addressed all your comments - removed the redundant check, moved the pattern check before wildcard logic, and preserved the original 25% probability for wildcards. I ran the test 30+ times locally with random seeds including the two failing seeds from the issue (8C4D6928119E4426 and D373738A924E04A). All pass now. Before the fix, these seeds failed with the UnsupportedOperationException. |
Signed-off-by: Atri Sharma <atri.jiit@gmail.com>
sandeshkr419
approved these changes
Aug 8, 2025
jainankitk
approved these changes
Aug 8, 2025
sandeshkr419
removed
lucene
Search
andrross
approved these changes
Aug 8, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #18995 +/- ##
============================================
- Coverage 72.88% 72.88% -0.01%
- Complexity 69300 69323 +23
============================================
Files 5642 5642
Lines 318640 318641 +1
Branches 46108 46108
============================================
- Hits 232237 232235 -2
- Misses 67566 67591 +25
+ Partials 18837 18815 -22 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Thank you for reviewing. @andrross @jainankitk @sandeshkr419 If it looks good, can we please merge? |
rishabhmaurya
approved these changes
Aug 11, 2025
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 11, 2025
* Fix flaky ExistsQueryBuilderTests.testToQuery Test was generating field patterns that matched raw.derived_keyword, which doesnt support exists queries. Fixed by replacing problematic patterns with TEXT_FIELD_NAME. Fixes #18724 Signed-off-by: Atri Sharma <atri.jiit@gmail.com> * Revert CHANGELOG changes Signed-off-by: Atri Sharma <atri.jiit@gmail.com> --------- Signed-off-by: Atri Sharma <atri.jiit@gmail.com> (cherry picked from commit 86ac3ab) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
jainankitk
pushed a commit
that referenced
this pull request
Aug 11, 2025
--------- (cherry picked from commit 86ac3ab) Signed-off-by: Atri Sharma <atri.jiit@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
RajatGupta02
pushed a commit
to RajatGupta02/OpenSearch
that referenced
this pull request
Aug 18, 2025
* Fix flaky ExistsQueryBuilderTests.testToQuery Test was generating field patterns that matched raw.derived_keyword, which doesnt support exists queries. Fixed by replacing problematic patterns with TEXT_FIELD_NAME. Fixes opensearch-project#18724 Signed-off-by: Atri Sharma <atri.jiit@gmail.com> * Revert CHANGELOG changes Signed-off-by: Atri Sharma <atri.jiit@gmail.com> --------- Signed-off-by: Atri Sharma <atri.jiit@gmail.com>
atris
added a commit
to atris/OpenSearch
that referenced
this pull request
Aug 28, 2025
* Fix flaky ExistsQueryBuilderTests.testToQuery Test was generating field patterns that matched raw.derived_keyword, which doesnt support exists queries. Fixed by replacing problematic patterns with TEXT_FIELD_NAME. Fixes opensearch-project#18724 Signed-off-by: Atri Sharma <atri.jiit@gmail.com> * Revert CHANGELOG changes Signed-off-by: Atri Sharma <atri.jiit@gmail.com> --------- Signed-off-by: Atri Sharma <atri.jiit@gmail.com>
kh3ra
pushed a commit
to kh3ra/OpenSearch
that referenced
this pull request
Sep 5, 2025
* Fix flaky ExistsQueryBuilderTests.testToQuery Test was generating field patterns that matched raw.derived_keyword, which doesnt support exists queries. Fixed by replacing problematic patterns with TEXT_FIELD_NAME. Fixes opensearch-project#18724 Signed-off-by: Atri Sharma <atri.jiit@gmail.com> * Revert CHANGELOG changes Signed-off-by: Atri Sharma <atri.jiit@gmail.com> --------- Signed-off-by: Atri Sharma <atri.jiit@gmail.com>
vinaykpud
pushed a commit
to vinaykpud/OpenSearch
that referenced
this pull request
Sep 26, 2025
* Fix flaky ExistsQueryBuilderTests.testToQuery Test was generating field patterns that matched raw.derived_keyword, which doesnt support exists queries. Fixed by replacing problematic patterns with TEXT_FIELD_NAME. Fixes opensearch-project#18724 Signed-off-by: Atri Sharma <atri.jiit@gmail.com> * Revert CHANGELOG changes Signed-off-by: Atri Sharma <atri.jiit@gmail.com> --------- Signed-off-by: Atri Sharma <atri.jiit@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test was generating field patterns that matched raw.derived_keyword, which doesnt support exists queries. Fixed by replacing problematic patterns with TEXT_FIELD_NAME.
Fixes #18274