Expose SETTING_GRPC_MAX_MSG_SIZE to settings service #18910
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
❌ Gradle check result for 7ef65d4: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
finnegancarroll
force-pushed
the
grpc-max-msg-size-fix
branch
from
7ef65d4 to
3a958d0
Compare
|
lgtm, provided changelog entry is added later |
karenyrx
approved these changes
Aug 5, 2025
andrross
approved these changes
Aug 5, 2025
|
❌ Gradle check result for 3a958d0: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Finn Carroll <carrofin@amazon.com>
finnegancarroll
force-pushed
the
grpc-max-msg-size-fix
branch
from
3a958d0 to
290d281
Compare
Signed-off-by: Finn Carroll <carrofin@amazon.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #18910 +/- ##
============================================
+ Coverage 72.88% 72.93% +0.05%
- Complexity 69160 69203 +43
============================================
Files 5633 5633
Lines 317978 317978
Branches 45988 45988
============================================
+ Hits 231752 231913 +161
+ Misses 67517 67350 -167
- Partials 18709 18715 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@finnegancarroll should this be back-ported to 3.2? |
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 7, 2025
(cherry picked from commit bf5b43d) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
prudhvigodithi
pushed a commit
that referenced
this pull request
Aug 7, 2025
RajatGupta02
pushed a commit
to RajatGupta02/OpenSearch
that referenced
this pull request
Aug 18, 2025
kh3ra
pushed a commit
to kh3ra/OpenSearch
that referenced
this pull request
Sep 5, 2025
vinaykpud
pushed a commit
to vinaykpud/OpenSearch
that referenced
this pull request
Sep 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Correcting a previous mistake when adding SETTING_GRPC_MAX_MSG_SIZE. This setting is not included in GrpcPlugin
getSettings. This causes the max size setting to be rejected if set with opensearch.yml.Related Issues
N/A
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.