Skip to content

Conversation

@peteralfonsi
Copy link
Contributor

Description

Reverts #18124.

As discussed with @msfroh in #18476, we are seeing some worrying AssertionErrors coming out of MergingDigest.quantile() in flaky tests. While that assertion error in particular is probably just due to tdunning/t-digest#167 and doesn't suggest broader issues with correctness, we're concerned there might be other lurking bugs in the MergingDigest implementation. So, we are reverting to the older AVLTreeDigest. Since there haven't been any major version releases since the original PR was merged, there shouldn't be any BWC issues.

I'll also reach out to the library creator and see if we can get some more info on this issue. If there's time I'll investigate the Apache implementation of MergingDigest as well.

Related Issues

Resolves #18476

Check List

  • Functionality includes testing.
  • [N/A] API changes companion pull request created, if applicable.
  • [N/A] Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…h-project#18124)"

This reverts commit 22a6194.

Signed-off-by: Peter Alfonsi <petealft@amazon.com>
@github-actions
Copy link
Contributor

❌ Gradle check result for 13c2261: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@peteralfonsi
Copy link
Contributor Author

Flaky test: #14309

Signed-off-by: Peter Alfonsi <petealft@amazon.com>
@peteralfonsi
Copy link
Contributor Author

Flaky test: #14324

Signed-off-by: Peter Alfonsi <petealft@amazon.com>
@github-actions
Copy link
Contributor

❌ Gradle check result for 0ebe747: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@peteralfonsi
Copy link
Contributor Author

#14559

Signed-off-by: Peter Alfonsi <petealft@amazon.com>
@github-actions
Copy link
Contributor

❌ Gradle check result for ac009e8: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@peteralfonsi
Copy link
Contributor Author

Flaky test: #17154

Signed-off-by: Peter Alfonsi <petealft@amazon.com>
@github-actions
Copy link
Contributor

✅ Gradle check result for 167102d: SUCCESS

@codecov
Copy link

codecov bot commented Jun 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.69%. Comparing base (5255f5b) to head (167102d).
Report is 9 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #18497      +/-   ##
============================================
- Coverage     72.71%   72.69%   -0.02%     
- Complexity    68094    68127      +33     
============================================
  Files          5537     5537              
  Lines        313312   313352      +40     
  Branches      45460    45469       +9     
============================================
- Hits         227813   227784      -29     
- Misses        66967    67082     +115     
+ Partials      18532    18486      -46     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@peteralfonsi
Copy link
Contributor Author

@msfroh or @andrross - finally got a green build on this, should be ready to merge

@msfroh msfroh merged commit afb08a0 into opensearch-project:main Jun 13, 2025
30 checks passed
@msfroh
Copy link
Contributor

msfroh commented Jun 13, 2025

Thanks @peteralfonsi!

@andrross
Copy link
Member

@msfroh @peteralfonsi Let's make sure this revert gets into the 3.1 branch so that we revert this from the 3.1 release

opensearch-trigger-bot bot pushed a commit that referenced this pull request Jun 13, 2025
…18497)

---------

Signed-off-by: Peter Alfonsi <petealft@amazon.com>
Co-authored-by: Peter Alfonsi <petealft@amazon.com>
(cherry picked from commit afb08a0)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
peteralfonsi added a commit to peteralfonsi/OpenSearch that referenced this pull request Jun 13, 2025
…h-project#18124)" (opensearch-project#18497)

---------

Signed-off-by: Peter Alfonsi <petealft@amazon.com>
Co-authored-by: Peter Alfonsi <petealft@amazon.com>
abhita pushed a commit to abhita/OpenSearch that referenced this pull request Jun 17, 2025
…h-project#18124)" (opensearch-project#18497)

---------

Signed-off-by: Peter Alfonsi <petealft@amazon.com>
Co-authored-by: Peter Alfonsi <petealft@amazon.com>
owaiskazi19 pushed a commit that referenced this pull request Jun 18, 2025
…18497)

---------

Signed-off-by: Peter Alfonsi <petealft@amazon.com>
Co-authored-by: Peter Alfonsi <petealft@amazon.com>
(cherry picked from commit afb08a0)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
owaiskazi19 pushed a commit that referenced this pull request Jun 18, 2025
…18497) (#18517)

---------



(cherry picked from commit afb08a0)

Signed-off-by: Peter Alfonsi <petealft@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Peter Alfonsi <petealft@amazon.com>
neuenfeldttj added a commit to neuenfeldttj/OpenSearch that referenced this pull request Jun 26, 2025
…h-project#18124)" (opensearch-project#18497)

---------

Signed-off-by: Peter Alfonsi <petealft@amazon.com>
Co-authored-by: Peter Alfonsi <petealft@amazon.com>Signed-off-by: TJ Neuenfeldt <tjneu@amazon.com>
neuenfeldttj pushed a commit to neuenfeldttj/OpenSearch that referenced this pull request Jun 26, 2025
…h-project#18124)" (opensearch-project#18497)

---------

Signed-off-by: Peter Alfonsi <petealft@amazon.com>
Co-authored-by: Peter Alfonsi <petealft@amazon.com>
tandonks pushed a commit to tandonks/OpenSearch that referenced this pull request Aug 5, 2025
…h-project#18124)" (opensearch-project#18497)

---------

Signed-off-by: Peter Alfonsi <petealft@amazon.com>
Co-authored-by: Peter Alfonsi <petealft@amazon.com>
peteralfonsi pushed a commit to peteralfonsi/OpenSearch that referenced this pull request Oct 15, 2025
…ch-project#18124)" (opensearch-project#18497)

This reverts commit afb08a0.

Signed-off-by: Peter Alfonsi <petealft@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autocut backport 3.1 flaky-test Random test failure that succeeds on second run >test-failure Test failure from CI, local build, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[AUTOCUT] Gradle Check Flaky Test Report for TDigestStateTests

3 participants