Switch percentiles implementation to MergingDigest #18124
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peteralfonsi
requested review from
Bukhtawar,
CEHENKLE,
Rishikesh1159,
VachaShah,
anasalkouz,
andrross,
ashking94,
cwperks,
dbwiddis,
gbbafna,
jed326,
kotwanikunal,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
sachinpkale,
saratvemulapalli,
shwetathareja and
sohami
as code owners
github-actions
bot
added
enhancement
peteralfonsi
force-pushed
the
merging-percentiles
branch
from
0f72ce4 to
852c178
Compare
|
❌ Gradle check result for 852c178: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Peter Alfonsi <petealft@amazon.com>
peteralfonsi
force-pushed
the
merging-percentiles
branch
from
852c178 to
4599cff
Compare
|
On further thought I will add some tests around serialization + serialization inter-version compatibility. Both classes provide their own serialization methods. Probably the most logical thing to do would be to add a version check, and for < 3.1 use the preexisting logic assuming |
|
❌ Gradle check result for 4599cff: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Peter Alfonsi <peter.alfonsi@gmail.com>
7 tasks
Gagan6164
pushed a commit
to Gagan6164/OpenSearch
that referenced
this pull request
Jun 8, 2025
…t#18124) --------- Signed-off-by: Peter Alfonsi <petealft@amazon.com> Signed-off-by: Peter Alfonsi <peter.alfonsi@gmail.com> Co-authored-by: Peter Alfonsi <petealft@amazon.com>
Gagan6164
pushed a commit
to Gagan6164/OpenSearch
that referenced
this pull request
Jun 8, 2025
…t#18124) --------- Signed-off-by: Peter Alfonsi <petealft@amazon.com> Signed-off-by: Peter Alfonsi <peter.alfonsi@gmail.com> Co-authored-by: Peter Alfonsi <petealft@amazon.com>
peteralfonsi
pushed a commit
to peteralfonsi/OpenSearch
that referenced
this pull request
Jun 11, 2025
…h-project#18124)" This reverts commit 22a6194.
1 task
peteralfonsi
pushed a commit
to peteralfonsi/OpenSearch
that referenced
this pull request
Jun 11, 2025
…h-project#18124)" This reverts commit 22a6194. Signed-off-by: Peter Alfonsi <petealft@amazon.com>
msfroh
pushed a commit
that referenced
this pull request
Jun 13, 2025
peteralfonsi
added a commit
to peteralfonsi/OpenSearch
that referenced
this pull request
Jun 13, 2025
…h-project#18124)" (opensearch-project#18497) --------- Signed-off-by: Peter Alfonsi <petealft@amazon.com> Co-authored-by: Peter Alfonsi <petealft@amazon.com>
abhita
pushed a commit
to abhita/OpenSearch
that referenced
this pull request
Jun 17, 2025
…h-project#18124)" (opensearch-project#18497) --------- Signed-off-by: Peter Alfonsi <petealft@amazon.com> Co-authored-by: Peter Alfonsi <petealft@amazon.com>
owaiskazi19
pushed a commit
that referenced
this pull request
Jun 18, 2025
…18497) (#18517) --------- (cherry picked from commit afb08a0) Signed-off-by: Peter Alfonsi <petealft@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Peter Alfonsi <petealft@amazon.com>
neuenfeldttj
added a commit
to neuenfeldttj/OpenSearch
that referenced
this pull request
Jun 26, 2025
…t#18124) --------- Signed-off-by: Peter Alfonsi <petealft@amazon.com> Signed-off-by: Peter Alfonsi <peter.alfonsi@gmail.com> Co-authored-by: Peter Alfonsi <petealft@amazon.com>Signed-off-by: TJ Neuenfeldt <tjneu@amazon.com>
neuenfeldttj
added a commit
to neuenfeldttj/OpenSearch
that referenced
this pull request
Jun 26, 2025
…h-project#18124)" (opensearch-project#18497) --------- Signed-off-by: Peter Alfonsi <petealft@amazon.com> Co-authored-by: Peter Alfonsi <petealft@amazon.com>Signed-off-by: TJ Neuenfeldt <tjneu@amazon.com>
neuenfeldttj
pushed a commit
to neuenfeldttj/OpenSearch
that referenced
this pull request
Jun 26, 2025
…t#18124) --------- Signed-off-by: Peter Alfonsi <petealft@amazon.com> Signed-off-by: Peter Alfonsi <peter.alfonsi@gmail.com> Co-authored-by: Peter Alfonsi <petealft@amazon.com>
neuenfeldttj
pushed a commit
to neuenfeldttj/OpenSearch
that referenced
this pull request
Jun 26, 2025
…h-project#18124)" (opensearch-project#18497) --------- Signed-off-by: Peter Alfonsi <petealft@amazon.com> Co-authored-by: Peter Alfonsi <petealft@amazon.com>
tandonks
pushed a commit
to tandonks/OpenSearch
that referenced
this pull request
Aug 5, 2025
…t#18124) --------- Signed-off-by: Peter Alfonsi <petealft@amazon.com> Signed-off-by: Peter Alfonsi <peter.alfonsi@gmail.com> Co-authored-by: Peter Alfonsi <petealft@amazon.com>
tandonks
pushed a commit
to tandonks/OpenSearch
that referenced
this pull request
Aug 5, 2025
…h-project#18124)" (opensearch-project#18497) --------- Signed-off-by: Peter Alfonsi <petealft@amazon.com> Co-authored-by: Peter Alfonsi <petealft@amazon.com>
peteralfonsi
pushed a commit
to peteralfonsi/OpenSearch
that referenced
this pull request
Oct 15, 2025
…ch-project#18124)" (opensearch-project#18497) This reverts commit afb08a0. Signed-off-by: Peter Alfonsi <petealft@amazon.com>
1 task
jainankitk
pushed a commit
that referenced
this pull request
Oct 17, 2025
rgsriram
pushed a commit
to rgsriram/OpenSearch
that referenced
this pull request
Oct 18, 2025
…ch-project#18124)" (opensearch-project#19648) Signed-off-by: Peter Alfonsi <petealft@amazon.com> Co-authored-by: Peter Alfonsi <petealft@amazon.com>
kh3ra
pushed a commit
to kh3ra/OpenSearch
that referenced
this pull request
Oct 23, 2025
…ch-project#18124)" (opensearch-project#19648) Signed-off-by: Peter Alfonsi <petealft@amazon.com> Co-authored-by: Peter Alfonsi <petealft@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Switches the percentiles agg implementation from AVLTreeDigest to MergingDigest. MergingDigest is now the recommended implementation from the t-digest library, and we see significant speedups by switching to it. (See more details in the original issue). Some latencies from percentiles aggregations on http_logs:
Since the implementations extend the same abstract class
AbstractTDigest, this is a drag-and-drop change. Our extending classTDigestStatejust adds some StreamInput/StreamOutput methods, which use the result of thecentroids()andcentroidCount()methods which are overridden from the abstract class. I don't think we need additional tests. The existing tests in TDigestPercentilesAggregatorTests.java still pass after the change. However I will still mark this PR as a draft, please let me know if I'm missing something here...I also don't think we need any tuning of the sole parameter
compression, since in the library's methodcreateDigestthat creates a digest of the default implementation, it doesn't modify the inputcompressionbased on which implementation it's actually using.Related Issues
Resolves #18122
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.