Change remote store restore cluster state priority to URGENT

[sachinpkale]

Description

• Currently, remote store restore cluster state update has NORMAL priority.
• Given that remote store restore is triggered when cluster has unassigned shards, it becomes important to trigger restore as soon as possible.
• Due to NORMAL priority, it is possible that other HIGH/URGENT priority tasks will delay the restore process.
• In this PR, we are changing the remote store restore cluster state update priority from NORMAL to URGENT.

Check List

• [ ] Functionality includes testing.
• [ ] API changes companion pull request created, if applicable.
• [ ] Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[github-actions]

❌ Gradle check result for 60b6322: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions]

❌ Gradle check result for 60b6322: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[ashking94]

Can we verify that changing the priority of this task can lead to starvation of other URGENT, HIGH priority tasks? It appears that the remote store restore task execution itself should not take much time. However, good to verify.

[github-actions]

✅ Gradle check result for 60b6322: SUCCESS

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 72.02%. Comparing base (691f725) to head (60b6322).
Report is 4 commits behind head on main.

Files with missing lines	Patch %	Lines
...arch/index/recovery/RemoteStoreRestoreService.java	0.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #16281      +/-   ##
============================================
- Coverage     72.06%   72.02%   -0.04%     
+ Complexity    64822    64820       -2     
============================================
  Files          5308     5308              
  Lines        302574   302565       -9     
  Branches      43710    43710              
============================================
- Hits         218048   217923     -125     
- Misses        66648    66785     +137     
+ Partials      17878    17857      -21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[sachinpkale]

Can we verify that changing the priority of this task can lead to starvation of other URGENT, HIGH priority tasks? It appears that the remote store restore task execution itself should not take much time. However, good to verify.

Yes, this is verified. As part of cluster state update, we build routing table.