Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AUTOCUT] Gradle Check Flaky Test Report for ApproximatePointRangeQueryTests #15807

Open
opensearch-ci-bot opened this issue Sep 6, 2024 · 2 comments
Open

[AUTOCUT] Gradle Check Flaky Test Report for ApproximatePointRangeQueryTests #15807

opensearch-ci-bot opened this issue Sep 6, 2024 · 2 comments
Labels
autocut flaky-test Random test failure that succeeds on second run >test-failure Test failure from CI, local build, etc.

Comments

@opensearch-ci-bot
Copy link
Collaborator

opensearch-ci-bot commented Sep 6, 2024 •
edited
Loading

Flaky Test Report for ApproximatePointRangeQueryTests

Noticed the ApproximatePointRangeQueryTests has some flaky, failing tests that failed during post-merge actions.

Details

Git Reference Merged Pull Request Build Details Test Name
b23c9de 15204 46352 org.opensearch.search.approximate.ApproximatePointRangeQueryTests.testApproximateRangeShortCircuit

org.opensearch.search.approximate.ApproximatePointRangeQueryTests.testApproximateRangeWithSizeUnderDefault
022acba 15598 46371 org.opensearch.search.approximate.ApproximatePointRangeQueryTests.testApproximateRangeWithSizeOverDefault
06c1a5a 16414 49949 org.opensearch.search.approximate.ApproximatePointRangeQueryTests.testApproximateRangeWithSizeOverDefault
0f7d572 16378 49739 org.opensearch.search.approximate.ApproximatePointRangeQueryTests.testApproximateRangeWithSizeOverDefault
0fd6a6a 15707 47032 org.opensearch.search.approximate.ApproximatePointRangeQueryTests.testApproximateRangeWithSizeUnderDefault
20e233e 16428 49932 org.opensearch.search.approximate.ApproximatePointRangeQueryTests.testApproximateRangeWithSizeOverDefault
266bdd3 16047 49028 org.opensearch.search.approximate.ApproximatePointRangeQueryTests.testApproximateRangeWithSizeOverDefault
2742e74 15700 47023 org.opensearch.search.approximate.ApproximatePointRangeQueryTests.testApproximateRangeWithSizeUnderDefault
41d582e 16389 49879 org.opensearch.search.approximate.ApproximatePointRangeQueryTests.testApproximateRangeWithSizeOverDefault
4456d55 16002 49664 org.opensearch.search.approximate.ApproximatePointRangeQueryTests.testApproximateRangeWithSizeOverDefault
4742400 15763 47609 org.opensearch.search.approximate.ApproximatePointRangeQueryTests.testApproximateRangeShortCircuitAscSort
4ed6a47 16411 49889 org.opensearch.search.approximate.ApproximatePointRangeQueryTests.testApproximateRangeWithSizeOverDefault
58adc18 16248 49187 org.opensearch.search.approximate.ApproximatePointRangeQueryTests.testApproximateRangeWithSizeOverDefault
65b0959 15698 47014 org.opensearch.search.approximate.ApproximatePointRangeQueryTests.testApproximateRangeWithSizeUnderDefault
925f41b 15409 46324 org.opensearch.search.approximate.ApproximatePointRangeQueryTests.testApproximateRangeShortCircuit
942765e 16267 49212 org.opensearch.search.approximate.ApproximatePointRangeQueryTests.testApproximateRangeWithSizeOverDefault
946bd9d 16329 49527 org.opensearch.search.approximate.ApproximatePointRangeQueryTests.testApproximateRangeWithSizeOverDefault
9a476b6 16444 50006 org.opensearch.search.approximate.ApproximatePointRangeQueryTests.testApproximateRangeWithSizeOverDefault
a09750a 16144 49156 org.opensearch.search.approximate.ApproximatePointRangeQueryTests.testApproximateRangeWithSizeOverDefault
a737f83 15682 47016 org.opensearch.search.approximate.ApproximatePointRangeQueryTests.testApproximateRangeWithSizeOverDefault
a853b75 16331 49514 org.opensearch.search.approximate.ApproximatePointRangeQueryTests.testApproximateRangeWithSizeOverDefault
b1f2ff8 16442 49980 org.opensearch.search.approximate.ApproximatePointRangeQueryTests.testApproximateRangeWithSizeOverDefault
cfcfe21 15526 46295 org.opensearch.search.approximate.ApproximatePointRangeQueryTests.testApproximateRangeShortCircuitAscSort
dd5a87a 16332 49540 org.opensearch.search.approximate.ApproximatePointRangeQueryTests.testApproximateRangeWithSizeOverDefault
e208672 16287 49309 org.opensearch.search.approximate.ApproximatePointRangeQueryTests.testApproximateRangeWithSizeOverDefault
e24b4c9 15925 49020 org.opensearch.search.approximate.ApproximatePointRangeQueryTests.testApproximateRangeWithSizeOverDefault
e8e041b 16207 49051 org.opensearch.search.approximate.ApproximatePointRangeQueryTests.testApproximateRangeWithSizeOverDefault
f795fdb 16113 49224 org.opensearch.search.approximate.ApproximatePointRangeQueryTests.testApproximateRangeWithSizeOverDefault
fbe8497 15711 47050 org.opensearch.search.approximate.ApproximatePointRangeQueryTests.testApproximateRangeShortCircuit

The other pull requests, besides those involved in post-merge actions, that contain failing tests with the ApproximatePointRangeQueryTests class are:

For more details on the failed tests refer to OpenSearch Gradle Check Metrics dashboard.
@opensearch-ci-bot opensearch-ci-bot added >test-failure Test failure from CI, local build, etc. autocut flaky-test Random test failure that succeeds on second run untriaged labels Sep 6, 2024
@harshavamsi
Copy link
Contributor

This should be fixed by #15590

@reta
Copy link
Collaborator

reta commented Sep 30, 2024

[Catch All Triage - 1, 2, 3, 4]

@reta reta removed the untriaged label Sep 30, 2024
@ltaragi ltaragi mentioned this issue Oct 21, 2024
Merged
3 tasks
@SwethaGuptha SwethaGuptha mentioned this issue Oct 21, 2024
Draft
3 tasks
This was referenced Oct 22, 2024
Closed
Merged
inpink added a commit to inpink/OpenSearch that referenced this issue Oct 22, 2024
@inpink
Fix flaky test in testApproximateRangeWithSizeOverDefault by adjust…
9230ea4 
…ing totalHits assertion logic (opensearch-project#15807)

- Updated the test to account for Lucene's behavior where `IndexSearcher.search()` may return `GREATER_THAN_OR_EQUAL_TO` for totalHits when the number of matches exceeds 1000.
- Added logic to check if `totalHits.relation` is `EQUAL_TO`. If so, assert that the count is exactly 11000. Otherwise, ensure the count is at least 11000 and within the allowed upper limit (`maxHits`).
- This change prevents intermittent test failures caused by Lucene’s performance optimizations.

Signed-off-by: inpink <inpink@kakao.com>
inpink added a commit to inpink/OpenSearch that referenced this issue Oct 23, 2024
@inpink
Fix flaky test in testApproximateRangeWithSizeOverDefault by adjust…
7533e97 
…ing totalHits assertion logic (opensearch-project#15807)

- Updated the test to account for Lucene's behavior where `IndexSearcher.search()` may return `GREATER_THAN_OR_EQUAL_TO` for totalHits when the number of matches exceeds 1000.
- Added logic to check if `totalHits.relation` is `EQUAL_TO`. If so, assert that the count is exactly 11000. Otherwise, ensure the count is at least 11000 and within the allowed upper limit (`maxHits`).
- This change prevents intermittent test failures caused by Lucene’s performance optimizations.

Signed-off-by: inpink <inpink@kakao.com>
inpink added a commit to inpink/OpenSearch that referenced this issue Oct 23, 2024
@inpink
Fix flaky test in testApproximateRangeWithSizeOverDefault by adjust…
bfb040a 
…ing totalHits assertion logic (opensearch-project#15807)

- Updated the test to account for Lucene's behavior where `IndexSearcher.search()` may return `GREATER_THAN_OR_EQUAL_TO` for totalHits when the number of matches exceeds 1000.
- Added logic to check if `totalHits.relation` is `EQUAL_TO`. If so, assert that the count is exactly 11000. Otherwise, ensure the count is at least 11000 and within the allowed upper limit (`maxHits`).
- This change prevents intermittent test failures caused by Lucene’s performance optimizations.

Signed-off-by: inpink <inpink@kakao.com>
dbwiddis pushed a commit that referenced this issue Oct 23, 2024
@inpink
Fix flaky test in testApproximateRangeWithSizeOverDefault by adjust…
66f0110 
…ing totalHits assertion logic (#15807) (#16434)

- Updated the test to account for Lucene's behavior where `IndexSearcher.search()` may return `GREATER_THAN_OR_EQUAL_TO` for totalHits when the number of matches exceeds 1000.
- Added logic to check if `totalHits.relation` is `EQUAL_TO`. If so, assert that the count is exactly 11000. Otherwise, ensure the count is at least 11000 and within the allowed upper limit (`maxHits`).
- This change prevents intermittent test failures caused by Lucene’s performance optimizations.

Signed-off-by: inpink <inpink@kakao.com>
opensearch-trigger-bot bot pushed a commit that referenced this issue Oct 23, 2024
@github-actions
Fix flaky test in testApproximateRangeWithSizeOverDefault by adjust…
5a19403 
…ing totalHits assertion logic (#15807) (#16434)

- Updated the test to account for Lucene's behavior where `IndexSearcher.search()` may return `GREATER_THAN_OR_EQUAL_TO` for totalHits when the number of matches exceeds 1000.
- Added logic to check if `totalHits.relation` is `EQUAL_TO`. If so, assert that the count is exactly 11000. Otherwise, ensure the count is at least 11000 and within the allowed upper limit (`maxHits`).
- This change prevents intermittent test failures caused by Lucene’s performance optimizations.

Signed-off-by: inpink <inpink@kakao.com>
(cherry picked from commit 66f0110)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dbwiddis pushed a commit that referenced this issue Oct 23, 2024
@opensearch-trigger-bot @github-actions
Fix flaky test in testApproximateRangeWithSizeOverDefault by adjust…
d27ee4e 
…ing totalHits assertion logic (#15807) (#16434) (#16459)

- Updated the test to account for Lucene's behavior where `IndexSearcher.search()` may return `GREATER_THAN_OR_EQUAL_TO` for totalHits when the number of matches exceeds 1000.
- Added logic to check if `totalHits.relation` is `EQUAL_TO`. If so, assert that the count is exactly 11000. Otherwise, ensure the count is at least 11000 and within the allowed upper limit (`maxHits`).
- This change prevents intermittent test failures caused by Lucene’s performance optimizations.


(cherry picked from commit 66f0110)

Signed-off-by: inpink <inpink@kakao.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
autocut flaky-test Random test failure that succeeds on second run >test-failure Test failure from CI, local build, etc.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@reta @harshavamsi @opensearch-ci-bot