Add snapshot_path prefix to snapshot shards path file on remote store #16267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
❕ Gradle check result for 5406886: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #16267 +/- ##
============================================
+ Coverage 71.97% 72.06% +0.09%
- Complexity 64771 64803 +32
============================================
Files 5302 5302
Lines 302473 302479 +6
Branches 43699 43699
============================================
+ Hits 217715 217996 +281
+ Misses 66950 66591 -359
- Partials 17808 17892 +84 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Ashish Singh <ssashish@amazon.com>
ashking94
requested review from
anasalkouz,
andrross,
Bukhtawar,
CEHENKLE,
dblock,
dbwiddis,
gbbafna,
jainankitk,
kotwanikunal,
linuxpi,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami and
VachaShah
as code owners
ashking94
changed the title
sachinpkale
approved these changes
Oct 10, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 10, 2024
Signed-off-by: Ashish Singh <ssashish@amazon.com> (cherry picked from commit 942765e) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This was referenced Oct 10, 2024
dk2k
pushed a commit
to dk2k/OpenSearch
that referenced
this pull request
Oct 16, 2024
…ch-project#16267) Signed-off-by: Ashish Singh <ssashish@amazon.com>
dk2k
pushed a commit
to dk2k/OpenSearch
that referenced
this pull request
Oct 17, 2024
…ch-project#16267) Signed-off-by: Ashish Singh <ssashish@amazon.com>
dk2k
pushed a commit
to dk2k/OpenSearch
that referenced
this pull request
Oct 21, 2024
…ch-project#16267) Signed-off-by: Ashish Singh <ssashish@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this PR, we are changing the name pattern of the file where we keep the paths for shard blobs for snapshots. This is done to align with the naming pattern we have followed with remote store index shard paths file as well.
Check List
[ ] API changes companion pull request created, if applicable.[ ] Public documentation issue/PR created, if applicable.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.