Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete keyword changes for star tree #16233

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

bharath-techie
Copy link
Contributor

@bharath-techie bharath-techie commented Oct 8, 2024

Description

This PR adds support for keyword fields with changes end to end that includes flush, merge and file format changes.

As part of "ordered_dimensions" as part of star tree mapping , users can provide keyword fields as well now. [ Metrics are not supported for keyword, its still "numeric-only" supported for star tree]

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Bharathwaj G <bharath78910@gmail.com>
Copy link
Contributor

github-actions bot commented Oct 8, 2024

❌ Gradle check result for bbb9ed0: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Oct 8, 2024

❌ Gradle check result for 57b0517: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: Bharathwaj G <bharath78910@gmail.com>
Copy link
Contributor

❌ Gradle check result for a48de57: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: Bharathwaj G <bharath78910@gmail.com>
Copy link
Contributor

✅ Gradle check result for 9238f17: SUCCESS

Copy link

codecov bot commented Oct 12, 2024

Codecov Report

Attention: Patch coverage is 81.36201% with 52 lines in your changes missing coverage. Please review.

Project coverage is 72.05%. Comparing base (dc8a435) to head (5a5e8af).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
...site/composite912/Composite912DocValuesWriter.java 73.33% 6 Missing and 2 partials ⚠️
...be/startree/utils/SequentialDocValuesIterator.java 52.94% 3 Missing and 5 partials ⚠️
...ndex/compositeindex/datacube/DimensionFactory.java 33.33% 4 Missing and 2 partials ⚠️
...be/startree/fileformats/meta/StarTreeMetadata.java 57.14% 5 Missing and 1 partial ⚠️
...rtree/fileformats/meta/StarTreeMetadataWriter.java 45.45% 5 Missing and 1 partial ⚠️
...ndex/compositeindex/datacube/KeywordDimension.java 73.68% 5 Missing ⚠️
...datacube/startree/builder/BaseStarTreeBuilder.java 94.73% 2 Missing and 3 partials ⚠️
...org/apache/lucene/index/DocValuesProducerUtil.java 25.00% 2 Missing and 1 partial ⚠️
...tils/iterator/SortedSetStarTreeValuesIterator.java 66.66% 3 Missing ⚠️
...site/composite912/Composite912DocValuesReader.java 90.00% 0 Missing and 1 partial ⚠️
... and 1 more
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #16233      +/-   ##
============================================
+ Coverage     71.96%   72.05%   +0.09%     
- Complexity    64791    64931     +140     
============================================
  Files          5307     5312       +5     
  Lines        302714   302946     +232     
  Branches      43733    43764      +31     
============================================
+ Hits         217836   218290     +454     
+ Misses        67013    66817     -196     
+ Partials      17865    17839      -26     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Bharathwaj G <bharath78910@gmail.com>
Copy link
Contributor

❌ Gradle check result for 7b3d88d: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: Bharathwaj G <bharath78910@gmail.com>
Copy link
Contributor

❌ Gradle check result for 914bdfd: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 3ec6d99: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@bharath-techie bharath-techie force-pushed the keyword-iterator branch 2 times, most recently from 89dc09f to 2bba7c1 Compare October 17, 2024 15:21
Copy link
Contributor

❌ Gradle check result for 2bba7c1: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for ded4921: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for c80298f: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: Bharathwaj G <bharath78910@gmail.com>
Copy link
Contributor

❌ Gradle check result for 5a5e8af: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❕ Gradle check result for 5a5e8af: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@bharath-techie
Copy link
Contributor Author

This PR is missing 2.18 , so I have merged the fixes that were done as part of this PR as part of 2.18.

Copy link
Contributor

❌ Gradle check result for fe8ed3e: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants