Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abstract out RemoteFsTranslogWithPinnedTimestamps #15579

Merged
merged 4 commits into from
Sep 3, 2024
Merged

Abstract out RemoteFsTranslogWithPinnedTimestamps #15579

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
96ded03
Abstract out RemoteFsTranslogWithPinnedTimestamps
Sep 2, 2024
eb12983
Revert test changes made for combined classes
Sep 3, 2024
1c72ad0
Address PR comments
Sep 3, 2024
68c620a
Fix spotless errors
Sep 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix spotless errors 
Signed-off-by: Sachin Kale <kalsac@amazon.com>
  • Loading branch information
Sachin Kale committed Sep 3, 2024
commit 68c620a57ab5c34eb6dc3a3934c8607cb740f851
12 changes: 3 additions & 9 deletions server/src/test/java/org/opensearch/index/translog/RemoteFsTimestampAwareTranslogTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -688,9 +688,7 @@ public void testGetMetadataFilesToBeDeletedExclusionBasedOnAgeOnly() {
"metadata__9223372036438563903__9223372036854775701__" + md3Timestamp + "__31__9223372036854775701__1"
);

List<String> metadataFilesToBeDeleted = ((RemoteFsTimestampAwareTranslog) translog).getMetadataFilesToBeDeleted(
metadataFiles
);
List<String> metadataFilesToBeDeleted = ((RemoteFsTimestampAwareTranslog) translog).getMetadataFilesToBeDeleted(metadataFiles);
assertEquals(1, metadataFilesToBeDeleted.size());
assertEquals(metadataFiles.get(0), metadataFilesToBeDeleted.get(0));
}
Expand All @@ -712,9 +710,7 @@ public void testGetMetadataFilesToBeDeletedExclusionBasedOnPinningOnly() throws
"metadata__9223372036438563903__9223372036854775701__" + md3Timestamp + "__31__9223372036854775701__1"
);

List<String> metadataFilesToBeDeleted = ((RemoteFsTimestampAwareTranslog) translog).getMetadataFilesToBeDeleted(
metadataFiles
);
List<String> metadataFilesToBeDeleted = ((RemoteFsTimestampAwareTranslog) translog).getMetadataFilesToBeDeleted(metadataFiles);
assertEquals(2, metadataFilesToBeDeleted.size());
assertEquals(metadataFiles.get(0), metadataFilesToBeDeleted.get(0));
assertEquals(metadataFiles.get(2), metadataFilesToBeDeleted.get(1));
Expand All @@ -737,9 +733,7 @@ public void testGetMetadataFilesToBeDeletedExclusionBasedOnAgeAndPinning() throw
"metadata__9223372036438563903__9223372036854775701__" + md3Timestamp + "__31__9223372036854775701__1"
);

List<String> metadataFilesToBeDeleted = ((RemoteFsTimestampAwareTranslog) translog).getMetadataFilesToBeDeleted(
metadataFiles
);
List<String> metadataFilesToBeDeleted = ((RemoteFsTimestampAwareTranslog) translog).getMetadataFilesToBeDeleted(metadataFiles);
assertEquals(1, metadataFilesToBeDeleted.size());
assertEquals(metadataFiles.get(2), metadataFilesToBeDeleted.get(0));
}
Expand Down
Loading