Abstract out RemoteFsTranslogWithPinnedTimestamps

[sachinpkale]

Description

• Abstract out RemoteFsTranslogWithPinnedTimestamps from RemoteFsTranslog for better separation of concerns.
• Add support to skip pinned timestamp in remote translog garbage collector #15416 (comment)

Check List

• Functionality includes testing.
• API changes companion pull request created, if applicable.
• Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[github-actions]

❌ Gradle check result for 1793974: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions]

❌ Gradle check result for 1793974: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions]

❌ Gradle check result for 7b9957c: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions]

❌ Gradle check result for d63200e: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions]

✅ Gradle check result for d63200e: SUCCESS

[codecov]

Codecov Report

Attention: Patch coverage is 81.43713% with 31 lines in your changes missing coverage. Please review.

Project coverage is 71.88%. Comparing base (7a9cb35) to head (68c620a).
Report is 11 commits behind head on main.

Files with missing lines	Patch %	Lines
...index/translog/RemoteFsTimestampAwareTranslog.java	81.11%	19 Missing and 8 partials ⚠️
...anslog/RemoteBlobStoreInternalTranslogFactory.java	33.33%	1 Missing and 1 partial ⚠️
...rg/opensearch/index/translog/RemoteFsTranslog.java	90.47%	1 Missing and 1 partial ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #15579      +/-   ##
============================================
+ Coverage     71.83%   71.88%   +0.05%     
- Complexity    63932    63970      +38     
============================================
  Files          5258     5259       +1     
  Lines        299329   299387      +58     
  Branches      43259    43266       +7     
============================================
+ Hits         215010   215206     +196     
+ Misses        66587    66404     -183     
- Partials      17732    17777      +45     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

❌ Gradle check result for 699693d: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions]

❕ Gradle check result for 68c620a: UNSTABLE

• TEST FAILURES:

      2 org.opensearch.backwards.MixedClusterClientYamlTestSuiteIT.test {p0=snapshot.status/10_basic/Get missing snapshot status throws an exception}
      1 org.opensearch.search.SearchWeightedRoutingIT.testStrictWeightedRoutingWithCustomString_FailOpenEnabled
      1 org.opensearch.backwards.MixedClusterClientYamlTestSuiteIT.test {p0=snapshot.status/10_basic/Get snapshot status}

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

[Bukhtawar]

Thanks for the changes Sachin