Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SnapshotV2] Snapshot Status API changes #15409

Merged
merged 8 commits into from
Sep 3, 2024
Merged

[SnapshotV2] Snapshot Status API changes #15409

merged 8 commits into from
Sep 3, 2024

Conversation

ltaragi
Copy link
Contributor

@ltaragi ltaragi commented Aug 26, 2024 •
edited
Loading

Description

This PR contains the necessary changes to Snapshot Status API as part of V2 snapshots:

  • Allow index filter in the status API if the request contains only one snapshot name. Thus, the status API response will only consist of the specified indices in the filter (if any). Throw IndexNotFoundException in case an index name is not found in the provided snapshot.
  • For shallow snapshots of type V2, the file count and size stats are 0 at all levels
  • For other snapshots:
    • The status API call works only if the total number of shards across the requested resources (snapshots or the indices of a particular snapshot) is less than a certain amount determined by the cluster setting snapshot.max_shards_allowed_in_status_api

Related Issues

Resolves #15463

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for b0c0c7c: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 1a5fa32: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 513732d: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions github-actions bot added enhancement Enhancement or improvement to existing feature or request Storage:Snapshots v2.17.0 labels Aug 28, 2024
@ltaragi ltaragi self-assigned this Aug 28, 2024
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for dba91db: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 74468bd: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for b5cab5b: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@ltaragi ltaragi force-pushed the snapshot-status branch 2 times, most recently from 9623803 to 138ca7c Compare August 30, 2024 08:02
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 2c59e24: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 9623803: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

✅ Gradle check result for 138ca7c: SUCCESS

@ltaragi ltaragi marked this pull request as ready for review August 30, 2024 08:58
ltaragi added a commit to ltaragi/OpenSearch that referenced this pull request Sep 4, 2024
@ltaragi
Remove breaking changes from opensearch-project#15409 (opensearch-pro…
278557a 
…ject#15624)

Signed-off-by: Lakshya Taragi <lakshya.taragi@gmail.com>
(cherry picked from commit a60b668)
ashking94 pushed a commit that referenced this pull request Sep 4, 2024
@ltaragi
[Backport 2.x] Backport #15409 and #15624 to 2.x (#15595)
01b38be 
* [SnapshotV2] Snapshot Status API changes (#15409)

---------

Signed-off-by: Lakshya Taragi <lakshya.taragi@gmail.com>
(cherry picked from commit 925f41b)

* Remove breaking changes from #15409 (#15624)

Signed-off-by: Lakshya Taragi <lakshya.taragi@gmail.com>
(cherry picked from commit a60b668)
ltaragi added a commit to ltaragi/OpenSearch that referenced this pull request Sep 4, 2024
@ltaragi
[Backport 2.x] Backport opensearch-project#15409 and opensearch-proje…
37b2c7b 
…ct#15624 to 2.x (opensearch-project#15595)

* [SnapshotV2] Snapshot Status API changes (opensearch-project#15409)

---------

Signed-off-by: Lakshya Taragi <lakshya.taragi@gmail.com>
(cherry picked from commit 925f41b)

* Remove breaking changes from opensearch-project#15409 (opensearch-project#15624)

Signed-off-by: Lakshya Taragi <lakshya.taragi@gmail.com>
(cherry picked from commit a60b668)
(cherry picked from commit 01b38be)
ltaragi added a commit to ltaragi/OpenSearch that referenced this pull request Sep 4, 2024
@ltaragi
[Backport 2.x] Backport opensearch-project#15409 and opensearch-proje…
1d332e0 
…ct#15624 to 2.x (opensearch-project#15595)

* [SnapshotV2] Snapshot Status API changes (opensearch-project#15409)

---------

Signed-off-by: Lakshya Taragi <lakshya.taragi@gmail.com>
(cherry picked from commit 925f41b)

* Remove breaking changes from opensearch-project#15409 (opensearch-project#15624)

Signed-off-by: Lakshya Taragi <lakshya.taragi@gmail.com>
(cherry picked from commit a60b668)
(cherry picked from commit 01b38be)
sachinpkale pushed a commit that referenced this pull request Sep 4, 2024
@ltaragi
[Backport] Snapshot Status API changes (#15665)
eaa7295 
---------

Signed-off-by: Lakshya Taragi <lakshya.taragi@gmail.com>
(cherry picked from commit 925f41b)

* Remove breaking changes from #15409 (#15624)

Signed-off-by: Lakshya Taragi <lakshya.taragi@gmail.com>
(cherry picked from commit a60b668)
(cherry picked from commit 01b38be)

* Change version to V_2_17_0 (#15596) (#15642)

Signed-off-by: Lakshya Taragi <lakshya.taragi@gmail.com>
(cherry picked from commit 0f53bf9)
(cherry picked from commit d368e3b)
This was referenced Sep 6, 2024
Open
Open
Open
Open
Open
@ltaragi ltaragi mentioned this pull request Sep 10, 2024
Merged
3 tasks
akolarkunnu pushed a commit to akolarkunnu/OpenSearch that referenced this pull request Sep 10, 2024
@ltaragi @akolarkunnu
[SnapshotV2] Snapshot Status API changes (opensearch-project#15409)
7060c10 
---------

Signed-off-by: Lakshya Taragi <lakshya.taragi@gmail.com>
akolarkunnu pushed a commit to akolarkunnu/OpenSearch that referenced this pull request Sep 10, 2024
@ltaragi @akolarkunnu
Remove breaking changes from opensearch-project#15409 (opensearch-pro…
2c09d8a 
…ject#15624)

Signed-off-by: Lakshya Taragi <lakshya.taragi@gmail.com>
This was referenced Sep 11, 2024
Open
Open
Open
Open
Open
Open
@BrewTestBot BrewTestBot mentioned this pull request Sep 18, 2024
Merged
@opensearch-ci-bot opensearch-ci-bot mentioned this pull request Oct 1, 2024
Open
@prudhvigodithi prudhvigodithi mentioned this pull request Oct 16, 2024
Open
dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 16, 2024
@ltaragi @dk2k
[SnapshotV2] Snapshot Status API changes (opensearch-project#15409)
478b540 
---------

Signed-off-by: Lakshya Taragi <lakshya.taragi@gmail.com>
dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 16, 2024
@ltaragi @dk2k
Remove breaking changes from opensearch-project#15409 (opensearch-pro…
18c229c 
…ject#15624)

Signed-off-by: Lakshya Taragi <lakshya.taragi@gmail.com>
dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 17, 2024
@ltaragi @dk2k
[SnapshotV2] Snapshot Status API changes (opensearch-project#15409)
5ac608d 
---------

Signed-off-by: Lakshya Taragi <lakshya.taragi@gmail.com>
dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 17, 2024
@ltaragi @dk2k
Remove breaking changes from opensearch-project#15409 (opensearch-pro…
7805fa3 
…ject#15624)

Signed-off-by: Lakshya Taragi <lakshya.taragi@gmail.com>
@ltaragi ltaragi mentioned this pull request Oct 20, 2024
Merged
3 tasks
dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 21, 2024
@ltaragi @dk2k
[SnapshotV2] Snapshot Status API changes (opensearch-project#15409)
e36b6ef 
---------

Signed-off-by: Lakshya Taragi <lakshya.taragi@gmail.com>
dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 21, 2024
@ltaragi @dk2k
Remove breaking changes from opensearch-project#15409 (opensearch-pro…
a691298 
…ject#15624)

Signed-off-by: Lakshya Taragi <lakshya.taragi@gmail.com>
@opensearch-ci-bot opensearch-ci-bot mentioned this pull request Oct 30, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sachinpkale sachinpkale sachinpkale approved these changes

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@ashking94 ashking94 Awaiting requested review from ashking94 ashking94 is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@jainankitk jainankitk Awaiting requested review from jainankitk jainankitk is a code owner

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@linuxpi linuxpi Awaiting requested review from linuxpi linuxpi is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@reta reta Awaiting requested review from reta reta is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

Assignees

@ltaragi ltaragi

Labels
backport 2.x Backport to 2.x branch backport-failed enhancement Enhancement or improvement to existing feature or request Storage:Snapshots v2.17.0
Projects
Storage Project Board
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[SnapshotV2] Snapshot Status API changes
2 participants
@ltaragi @sachinpkale