Compare strings with equals() instead of == #15369

dk2k · 2024-08-22T18:41:24Z

Compare strings with equals() instead of ==

github-actions · 2024-08-22T19:17:14Z

❌ Gradle check result for af992a9: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions · 2024-08-23T19:06:09Z

❕ Gradle check result for af992a9: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

codecov · 2024-08-23T19:08:17Z

Codecov Report

Attention: Patch coverage is 20.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 71.88%. Comparing base (abb1041) to head (af992a9).
Report is 168 commits behind head on main.

Files with missing lines	Patch %	Lines
...earch/suggest/phrase/NoisyChannelSpellChecker.java	0.00%	0 Missing and 2 partials ⚠️
...h/common/lucene/search/MultiPhrasePrefixQuery.java	0.00%	0 Missing and 1 partial ⚠️
...ons/bucket/composite/UnsignedLongValuesSource.java	0.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #15369      +/-   ##
============================================
- Coverage     71.93%   71.88%   -0.05%     
+ Complexity    63223    63190      -33     
============================================
  Files          5214     5214              
  Lines        295938   295938              
  Branches      42754    42754              
============================================
- Hits         212876   212738     -138     
- Misses        65601    65691      +90     
- Partials      17461    17509      +48

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

dbwiddis

LGTM with a suggestion

test/framework/src/main/java/org/opensearch/index/shard/IndexShardTestCase.java

…h-project#16290) Signed-off-by: David Zane <davizane@amazon.com> Signed-off-by: Ankit Jain <akjain@amazon.com> Co-authored-by: Ankit Jain <akjain@amazon.com>

…es (opensearch-project#14383) Signed-off-by: kkewwei <kkewwei@163.com>

…16323) We have guarded the experimental query approximation framework behind a feature flag. In order to easily measure the impact of approximation on big5 benchmarks, it would be nice to have a benchmark config. Signed-off-by: Michael Froh <froh@amazon.com>

) * Update last seen cluster state on apply commit Signed-off-by: Sooraj Sinha <soosinha@amazon.com>

…t#16236) Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>

…ch-project#16282) --------- Signed-off-by: Sachin Kale <sachinpkale@gmail.com>

…o null on index creation (opensearch-project#16331) * Fix wrong value when setting index.number_of_routing_shards to null on index creation Signed-off-by: Gao Binlong <gbinlong@amazon.com> * Modify change log Signed-off-by: Gao Binlong <gbinlong@amazon.com> --------- Signed-off-by: Gao Binlong <gbinlong@amazon.com>

…sue (performance regression) (opensearch-project#16342) Signed-off-by: Andriy Redko <andriy.redko@aiven.io>

Signed-off-by: Sachin Kale <sachinpkale@gmail.com>

…ld (opensearch-project#15258) * fix cluster not able to spin up issue when disk usage exceeds threshold Signed-off-by: zane-neo <zaniu@amazon.com> * Add comment to changes Signed-off-by: zane-neo <zaniu@amazon.com> * Add UT to ensure the keepAliveThread starts before node starts Signed-off-by: zane-neo <zaniu@amazon.com> * remove unused imports Signed-off-by: zane-neo <zaniu@amazon.com> * Fix forbidden API calls check failed issue Signed-off-by: zane-neo <zaniu@amazon.com> * format code Signed-off-by: zane-neo <zaniu@amazon.com> * format code Signed-off-by: zane-neo <zaniu@amazon.com> * change setInstance method to static Signed-off-by: zane-neo <zaniu@amazon.com> * Add countdownlatch in test to coordinate the thread to avoid concureency issue caused test failure Signed-off-by: zane-neo <zaniu@amazon.com> --------- Signed-off-by: zane-neo <zaniu@amazon.com>

…t V2 (opensearch-project#16344) --------- Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>

…nated by a newline [\n]' failures (opensearch-project#16337) * [Streaming Indexing] Fix intermittent 'The bulk request must be terminated by a newline [\n]' failures Signed-off-by: Andriy Redko <andriy.redko@aiven.io> * Address code review comments Signed-off-by: Andriy Redko <andriy.redko@aiven.io> --------- Signed-off-by: Andriy Redko <andriy.redko@aiven.io>

@sandeshkr419

…rch-project#15386) * Fixed inefficient Stream API call chains ending with count() Signed-off-by: Dmitry Kryukov <dk2k@ya.ru> * Refactored method minTermLength() as per @sandeshkr419's advice Signed-off-by: Dmitry Kryukov <dk2k@ya.ru> * Added a line in CHANGELOG.md Signed-off-by: Dmitry Kryukov <dk2k@ya.ru> --------- Signed-off-by: Dmitry Kryukov <dk2k@ya.ru>

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>

* Make Remote Publication a dynamic setting Signed-off-by: Shivansh Arora <hishiv@amazon.com> Co-authored-by: Sooraj Sinha <soosinha@amazon.com>

…roject#16037) --------- Signed-off-by: Bharathwaj G <bharath78910@gmail.com>

…6358) Signed-off-by: Andrew Ross <andrross@amazon.com>

Signed-off-by: Dmitry Kryukov <dk2k@ya.ru>

…ect#16370) * add QueryGroupMetadata to namedXContentWritables Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * add UT Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * apply spotless Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * add CHANGELOG entry Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * improve changelog comment Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> --------- Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>

…sed type info (opensearch-project#16002) * Removed suspicious getClass() call on Class Signed-off-by: Dmitry Kryukov <dk2k@ya.ru> * Changed the exception's message. Added unit test. Signed-off-by: Dmitry Kryukov <dk2k@ya.ru> * Run spotless, add license header Signed-off-by: Daniel Widdis <widdis@gmail.com> --------- Signed-off-by: Dmitry Kryukov <dk2k@ya.ru> Signed-off-by: Daniel Widdis <widdis@gmail.com> Co-authored-by: Daniel Widdis <widdis@gmail.com>

…x the issue. (opensearch-project#16377) Signed-off-by: zane-neo <zaniu@amazon.com>

…ject#16379) Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>

…h-project#16365) Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>

…nsportSettingsProvider interface (opensearch-project#16387) * Add isDualModeEnabled to SecureTransportSettingsProvider interface Signed-off-by: Craig Perkins <cwperx@amazon.com> * Add default impl Signed-off-by: Craig Perkins <cwperx@amazon.com> * Respond to comments, update usages and update docstring Signed-off-by: Craig Perkins <cwperx@amazon.com> * Address feedback Signed-off-by: Craig Perkins <cwperx@amazon.com> * Add ExperimentalApi and add to CHANGELOG Signed-off-by: Craig Perkins <cwperx@amazon.com> * Move DefaultSecureTransportParameters to separate file and add javadoc Signed-off-by: Craig Perkins <cwperx@amazon.com> --------- Signed-off-by: Craig Perkins <cwperx@amazon.com>

…h-project#16378) * Array, passed to Objects.hash(), should be wrapped into Arrays.hashCode(). Added unit test Signed-off-by: Dmitry Kryukov <dk2k@ya.ru> * Updated CHANGELOG.md Signed-off-by: Dmitry Kryukov <dk2k@ya.ru> --------- Signed-off-by: Dmitry Kryukov <dk2k@ya.ru>

github-actions · 2024-10-21T19:35:12Z

❌ Gradle check result for 3460ca7: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

dk2k · 2024-10-21T19:42:02Z

Sorry, I spoiled the rebase

dblock approved these changes Aug 23, 2024

View reviewed changes

dblock added backport 2.x Backport to 2.x branch skip-changelog labels Aug 24, 2024

dbwiddis approved these changes Aug 25, 2024

View reviewed changes

test/framework/src/main/java/org/opensearch/index/shard/IndexShardTestCase.java Outdated Show resolved Hide resolved

dzane17 and others added 25 commits October 21, 2024 22:16

Enable coordinator search.request_stats_enabled by default (opensearc…

b37de2b

…h-project#16290) Signed-off-by: David Zane <davizane@amazon.com> Signed-off-by: Ankit Jain <akjain@amazon.com> Co-authored-by: Ankit Jain <akjain@amazon.com>

Flat object field should delegate to keyword field for most query typ…

15b8089

…es (opensearch-project#14383) Signed-off-by: kkewwei <kkewwei@163.com>

Update last seen cluster state in commit phase (opensearch-project#16215

aa1a16b

) * Update last seen cluster state on apply commit Signed-off-by: Sooraj Sinha <soosinha@amazon.com>

Add support to dynamically resize threadpools size (opensearch-projec…

a33c79f

…t#16236) Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>

Fix deletion permits flow in RemoteFsTimestampAwareTranslog (opensear…

ce6ac6f

…ch-project#16282) --------- Signed-off-by: Sachin Kale <sachinpkale@gmail.com>

JDK-23: Mitigation for https://bugs.openjdk.org/browse/JDK-8341127 is…

742d9a7

…sue (performance regression) (opensearch-project#16342) Signed-off-by: Andriy Redko <andriy.redko@aiven.io>

Bugfix in snapshot V2 restore flow (opensearch-project#16332)

07b0da3

Signed-off-by: Sachin Kale <sachinpkale@gmail.com>

[Snapshot V2] Use metadata from source snapshot while cloning snapsho…

4f76cbf

…t V2 (opensearch-project#16344) --------- Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>

Update 10_basic.yml (opensearch-project#16349)

4bb2bb5

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>

Make Remote Publication a dynamic setting (opensearch-project#15937)

925fa7d

* Make Remote Publication a dynamic setting Signed-off-by: Shivansh Arora <hishiv@amazon.com> Co-authored-by: Sooraj Sinha <soosinha@amazon.com>

[Star tree] Performance optimizations during flush flow (opensearch-p…

fbefe51

…roject#16037) --------- Signed-off-by: Bharathwaj G <bharath78910@gmail.com>

Skip media type parsing for known string values (opensearch-project#1…

48528af

…6358) Signed-off-by: Andrew Ross <andrross@amazon.com>

Fixed assignment to catch block parameter (opensearch-project#15384)

a1f4831

Signed-off-by: Dmitry Kryukov <dk2k@ya.ru>

Revert opensearch-project#15258 to figure out a better approach to fi…

f4f37d5

…x the issue. (opensearch-project#16377) Signed-off-by: zane-neo <zaniu@amazon.com>

Fix bug in snapshot update check for multiple v2 repo (opensearch-pro…

875b129

…ject#16379) Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>

Do orphan timestamp cleanup before completing the snapshot (opensearc…

2e45eab

…h-project#16365) Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>

dk2k requested a review from peternied as a code owner October 21, 2024 19:17

dk2k closed this Oct 21, 2024

dk2k mentioned this pull request Oct 21, 2024

Compare strings with equals() instead of == #16415

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Compare strings with equals() instead of == #15369

Compare strings with equals() instead of == #15369

Uh oh!

dk2k commented Aug 22, 2024

Uh oh!

github-actions bot commented Aug 22, 2024

Uh oh!

github-actions bot commented Aug 23, 2024

Uh oh!

codecov bot commented Aug 23, 2024 •

edited

Loading

Uh oh!

dbwiddis left a comment

Uh oh!

Uh oh!

github-actions bot commented Oct 21, 2024

Uh oh!

dk2k commented Oct 21, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

51 participants

Compare strings with equals() instead of == #15369

Compare strings with equals() instead of == #15369

Uh oh!

Conversation

dk2k commented Aug 22, 2024

Uh oh!

github-actions bot commented Aug 22, 2024

Uh oh!

github-actions bot commented Aug 23, 2024

Uh oh!

codecov bot commented Aug 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

dbwiddis left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Oct 21, 2024

Uh oh!

dk2k commented Oct 21, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

51 participants

codecov bot commented Aug 23, 2024 •

edited

Loading