[Snapshot V2] Do orphan timestamp cleanup before completing the snapshot #16365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
❌ Gradle check result for 2386c93: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
gbbafna
changed the title
gbbafna
requested review from
anasalkouz,
andrross,
ashking94,
Bukhtawar,
CEHENKLE,
dblock,
dbwiddis,
jainankitk,
kotwanikunal,
linuxpi,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami and
VachaShah
as code owners
sachinpkale
approved these changes
Oct 18, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #16365 +/- ##
============================================
+ Coverage 71.89% 72.07% +0.17%
- Complexity 64750 64874 +124
============================================
Files 5307 5307
Lines 302664 302663 -1
Branches 43726 43723 -3
============================================
+ Hits 217612 218154 +542
+ Misses 67183 66645 -538
+ Partials 17869 17864 -5 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
|
❌ Gradle check result for c2ca7fe: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
sachinpkale
approved these changes
Oct 18, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 18, 2024
Signed-off-by: Gaurav Bafna <gbbafna@amazon.com> (cherry picked from commit f1c98a4) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
sachinpkale
added a commit
to sachinpkale/OpenSearch
that referenced
this pull request
Oct 20, 2024
sachinpkale
added a commit
to sachinpkale/OpenSearch
that referenced
this pull request
Oct 20, 2024
dk2k
pushed a commit
to dk2k/OpenSearch
that referenced
this pull request
Oct 21, 2024
…h-project#16365) Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently we do orphan timestamp clean up after sending ack to the client . In between leaving the repo loop and entering the loop again , if there is a snapshot , we delete the non-orphan time stamp as well . This is because the
repositoryDatawhichcleanOrphanTimestamphas becomes stale.To simplify this, I intend to do
cleanOrphanTimestampwhen we are still in therepo loopwhich means thatrepositoryDatawill not change during this .Check List
[ ] API changes companion pull request created, if applicable.Public documentation issue/PR created, if applicable.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.