Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Apache Lucene to 9.12.0 #15333

Merged
merged 5 commits into from
Oct 7, 2024

Conversation

reta
Copy link
Collaborator

@reta reta commented Aug 21, 2024

Description

Update Apache Lucene to 9.12.0, see please https://lucene.apache.org/core/9_12_0/changes/Changes.html

Related Issues

N/A

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

❌ Gradle check result for a4d5b6b: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 51b60c5: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 128f5ef: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@reta reta force-pushed the update.9.12.0-snapshot-25253a1 branch from 128f5ef to e711f02 Compare August 21, 2024 14:58
Copy link
Contributor

github-actions bot commented Oct 3, 2024

❕ Gradle check result for 1bc034d: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.http.SearchRestCancellationIT.testAutomaticCancellationDuringQueryPhase
      1 org.opensearch.action.admin.cluster.node.tasks.ResourceAwareTasksTests.testTaskResourceTrackingDuringTaskCancellation

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link
Collaborator

@msfroh msfroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going through, I don't see any changes that seem unreasonable.

In theory, since CompositeCodec is guarded behind an experimental feature flag and hasn't shipped the search side of things yet, we may not need to keep Composite99Codec around, depending on our feelings on backwards compatibility for experimental features.

@bharath-techie -- what do you think? Can we just switch to Composite912Codec and drop Composite99Codec?

@reta
Copy link
Collaborator Author

reta commented Oct 7, 2024

@bharath-techie merging this one, please feel free to push code refactorings

@reta reta merged commit 146b0f7 into opensearch-project:main Oct 7, 2024
35 of 36 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-15333-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 146b0f7264b1426d475e757729d213097b776212
# Push it to GitHub
git push --set-upstream origin backport/backport-15333-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-15333-to-2.x.

@bharath-techie
Copy link
Contributor

bharath-techie commented Oct 7, 2024

I guess I missed this , @msfroh yes that certainly makes sense. We can completely drop Composite99Codec since its not shipped out of experimental yet.

Thanks @reta will refactor and include the above changes.

reta added a commit to reta/OpenSearch that referenced this pull request Oct 7, 2024
* Update Apache Lucene to 9.12.0

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>

* change to IOContext READONCE in locations where the file is not expected to be read multiple times.

Signed-off-by: Marc Handalian <marc.handalian@gmail.com>

* Use READ IOContext for all non Segment* files when copying node-node

Signed-off-by: Marc Handalian <marc.handalian@gmail.com>

* Fixing more test failures

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>

* Move Composite912Codec under org.opensearch.index.codec.composite.composite912 package

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>

---------

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
Signed-off-by: Marc Handalian <marc.handalian@gmail.com>
Co-authored-by: Marc Handalian <marc.handalian@gmail.com>
(cherry picked from commit 146b0f7)
Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
reta added a commit to reta/OpenSearch that referenced this pull request Oct 7, 2024
* Update Apache Lucene to 9.12.0

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>

* change to IOContext READONCE in locations where the file is not expected to be read multiple times.

Signed-off-by: Marc Handalian <marc.handalian@gmail.com>

* Use READ IOContext for all non Segment* files when copying node-node

Signed-off-by: Marc Handalian <marc.handalian@gmail.com>

* Fixing more test failures

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>

* Move Composite912Codec under org.opensearch.index.codec.composite.composite912 package

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>

---------

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
Signed-off-by: Marc Handalian <marc.handalian@gmail.com>
Co-authored-by: Marc Handalian <marc.handalian@gmail.com>
(cherry picked from commit 146b0f7)
Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
reta added a commit to reta/OpenSearch that referenced this pull request Oct 7, 2024
* Update Apache Lucene to 9.12.0

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>

* change to IOContext READONCE in locations where the file is not expected to be read multiple times.

Signed-off-by: Marc Handalian <marc.handalian@gmail.com>

* Use READ IOContext for all non Segment* files when copying node-node

Signed-off-by: Marc Handalian <marc.handalian@gmail.com>

* Fixing more test failures

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>

* Move Composite912Codec under org.opensearch.index.codec.composite.composite912 package

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>

---------

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
Signed-off-by: Marc Handalian <marc.handalian@gmail.com>
Co-authored-by: Marc Handalian <marc.handalian@gmail.com>
(cherry picked from commit 146b0f7)
Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
reta added a commit to reta/OpenSearch that referenced this pull request Oct 7, 2024
* Update Apache Lucene to 9.12.0

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>

* change to IOContext READONCE in locations where the file is not expected to be read multiple times.

Signed-off-by: Marc Handalian <marc.handalian@gmail.com>

* Use READ IOContext for all non Segment* files when copying node-node

Signed-off-by: Marc Handalian <marc.handalian@gmail.com>

* Fixing more test failures

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>

* Move Composite912Codec under org.opensearch.index.codec.composite.composite912 package

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>

---------

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
Signed-off-by: Marc Handalian <marc.handalian@gmail.com>
Co-authored-by: Marc Handalian <marc.handalian@gmail.com>
(cherry picked from commit 146b0f7)
Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
finnegancarroll added a commit to finnegancarroll/OpenSearch that referenced this pull request Oct 8, 2024
reta added a commit that referenced this pull request Oct 8, 2024
* Update Apache Lucene to 9.12.0



* change to IOContext READONCE in locations where the file is not expected to be read multiple times.



* Use READ IOContext for all non Segment* files when copying node-node



* Fixing more test failures



* Move Composite912Codec under org.opensearch.index.codec.composite.composite912 package



---------




(cherry picked from commit 146b0f7)

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
Signed-off-by: Marc Handalian <marc.handalian@gmail.com>
Co-authored-by: Marc Handalian <marc.handalian@gmail.com>
dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 16, 2024
* Update Apache Lucene to 9.12.0

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>

* change to IOContext READONCE in locations where the file is not expected to be read multiple times.

Signed-off-by: Marc Handalian <marc.handalian@gmail.com>

* Use READ IOContext for all non Segment* files when copying node-node

Signed-off-by: Marc Handalian <marc.handalian@gmail.com>

* Fixing more test failures

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>

* Move Composite912Codec under org.opensearch.index.codec.composite.composite912 package

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>

---------

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
Signed-off-by: Marc Handalian <marc.handalian@gmail.com>
Co-authored-by: Marc Handalian <marc.handalian@gmail.com>
dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 17, 2024
* Update Apache Lucene to 9.12.0

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>

* change to IOContext READONCE in locations where the file is not expected to be read multiple times.

Signed-off-by: Marc Handalian <marc.handalian@gmail.com>

* Use READ IOContext for all non Segment* files when copying node-node

Signed-off-by: Marc Handalian <marc.handalian@gmail.com>

* Fixing more test failures

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>

* Move Composite912Codec under org.opensearch.index.codec.composite.composite912 package

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>

---------

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
Signed-off-by: Marc Handalian <marc.handalian@gmail.com>
Co-authored-by: Marc Handalian <marc.handalian@gmail.com>
dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 21, 2024
* Update Apache Lucene to 9.12.0

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>

* change to IOContext READONCE in locations where the file is not expected to be read multiple times.

Signed-off-by: Marc Handalian <marc.handalian@gmail.com>

* Use READ IOContext for all non Segment* files when copying node-node

Signed-off-by: Marc Handalian <marc.handalian@gmail.com>

* Fixing more test failures

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>

* Move Composite912Codec under org.opensearch.index.codec.composite.composite912 package

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>

---------

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
Signed-off-by: Marc Handalian <marc.handalian@gmail.com>
Co-authored-by: Marc Handalian <marc.handalian@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch backport-failed dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants