[Backport 2.x] Incrementally remove resources from workflow state during deprovisioning #910
Conversation
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
…ing (#898) * Add method to delete a resource from the resources_created field Signed-off-by: Daniel Widdis <widdis@gmail.com> * Update deprovisioned resources incrementally Signed-off-by: Daniel Widdis <widdis@gmail.com> * Use Log4j ParameterizedMessage for string substitutions Signed-off-by: Daniel Widdis <widdis@gmail.com> --------- Signed-off-by: Daniel Widdis <widdis@gmail.com> (cherry picked from commit 2f52b7e) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot
bot
requested review from
dbwiddis,
owaiskazi19,
joshpalis,
ohltyler,
amitgalitz and
jackiehanyang
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.x #910 +/- ##
============================================
- Coverage 78.04% 78.01% -0.03%
- Complexity 977 982 +5
============================================
Files 97 97
Lines 4554 4576 +22
Branches 423 426 +3
============================================
+ Hits 3554 3570 +16
- Misses 823 829 +6
Partials 177 177 ☔ View full report in Codecov by Sentry. |
|
@navneet1v So earlier I incorrectly tagged the lucene issue but these tests definitely have the lucene99 class not found error. Does opensearch-project/k-NN#2195 need to be backported to 2.x? |
|
Yes it needs k-NN code needs to be backported as the changes in Opensearch core is pushed to 2.x branch like few hours ago: opensearch-project/OpenSearch#16211 |
|
Living on the bleeding edge! |
backport PR raised: opensearch-project/k-NN#2196 |
Backport 2f52b7e from #898.