Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Pass parent filter to inner hit query (#13770)" #13896

Merged
merged 1 commit into from
May 30, 2024

Conversation

heemin32
Copy link
Contributor

@heemin32 heemin32 commented May 30, 2024

This reverts commit db5240e.

Reverting due to flaky test failure. #13890

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • API changes companion pull request created.
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

Copy link
Contributor

❌ Gradle check result for c40cdc6: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❕ Gradle check result for c40cdc6: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link

codecov bot commented May 30, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 71.59%. Comparing base (b15cb0c) to head (c40cdc6).
Report is 324 commits behind head on main.

Files Patch % Lines
...org/opensearch/index/query/NestedQueryBuilder.java 0.00% 5 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #13896      +/-   ##
============================================
+ Coverage     71.42%   71.59%   +0.17%     
- Complexity    59978    61343    +1365     
============================================
  Files          4985     5064      +79     
  Lines        282275   288086    +5811     
  Branches      40946    41715     +769     
============================================
+ Hits         201603   206266    +4663     
- Misses        63999    64770     +771     
- Partials      16673    17050     +377     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@msfroh
Copy link
Collaborator

msfroh commented May 30, 2024

Thanks for reverting this @heemin32 !

Hopefully the failing test will be easy to fix and we can get this back in time for 2.15.

@msfroh msfroh merged commit 9632bd6 into opensearch-project:main May 30, 2024
53 of 77 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants