Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] NestedQueryBuilderTests.testParentFilterFromInlineLeafInnerHitsNestedQuery is flaky #13890

Closed
msfroh opened this issue May 30, 2024 · 3 comments
Labels
bug Something isn't working flaky-test Random test failure that succeeds on second run Search:Query Capabilities untriaged

Comments

@msfroh
Copy link
Collaborator

msfroh commented May 30, 2024

Describe the bug

See e.g. https://build.ci.opensearch.org/job/gradle-check/39435/testReport/junit/org.opensearch.index.query/NestedQueryBuilderTests/testParentFilterFromInlineLeafInnerHitsNestedQuery/

[xZY] QueryShardException[No mapping found for [bbSiO] in order to sort on]
	at __randomizedtesting.SeedInfo.seed([82773C9793E6B096:83316B8C6652D666]:0)
	at app//org.opensearch.search.sort.FieldSortBuilder.resolveUnmappedType(FieldSortBuilder.java:564)
	at app//org.opensearch.search.sort.FieldSortBuilder.build(FieldSortBuilder.java:411)
	at app//org.opensearch.search.sort.SortBuilder.buildSort(SortBuilder.java:168)
	at app//org.opensearch.index.query.InnerHitContextBuilder.setupInnerHitsContext(InnerHitContextBuilder.java:143)
	at app//org.opensearch.index.query.NestedQueryBuilder$NestedInnerHitContextBuilder.doBuild(NestedQueryBuilder.java:422)
	at app//org.opensearch.index.query.InnerHitContextBuilder.build(InnerHitContextBuilder.java:86)
	at app//org.opensearch.index.query.NestedQueryBuilderTests.testParentFilterFromInlineLeafInnerHitsNestedQuery(NestedQueryBuilderTests.java:344)

Related component

Search:Query Capabilities

To Reproduce

Reproduces reliably with:

./gradlew ':server:test' --tests "org.opensearch.index.query.NestedQueryBuilderTests.testParentFilterFromInlineLeafInnerHitsNestedQuery" -Dtests.seed=82773C9793E6B096 -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=es-GT -Dtests.timezone=Europe/Astrakhan -Druntime.java=21

Expected behavior

The test should pass all the time 😁

Additional Details

This failure was probably triggered by the merge of #13770

@msfroh msfroh added bug Something isn't working untriaged flaky-test Random test failure that succeeds on second run labels May 30, 2024
@msfroh
Copy link
Collaborator Author

msfroh commented May 30, 2024

We may want to revert #13770 as a quick fix, then reapply it once we have a reliable fix.

@heemin32
Copy link
Contributor

There was a bug in the test case. Raised a new PR after the fix. #13903

@msfroh
Copy link
Collaborator Author

msfroh commented May 31, 2024

Fixed by #13896 and #13903

@msfroh msfroh closed this as completed May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working flaky-test Random test failure that succeeds on second run Search:Query Capabilities untriaged
Projects
Status: Done
Development

No branches or pull requests

2 participants