Decouple remote state configuration #11858
Conversation
soosinha
requested review from
abbashus,
adnapibar,
anasalkouz,
andrross,
Bukhtawar,
CEHENKLE,
dblock,
dbwiddis,
dreamer-89,
gbbafna,
kartg,
kotwanikunal,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
ryanbogan,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami,
tlfeng and
VachaShah
as code owners
Compatibility status:Checks if related components are compatible with change db7683c Incompatible componentsIncompatible components: [https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/alerting.git] Skipped componentsCompatible componentsCompatible components: [https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/flow-framework.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/sql.git] |
|
❌ Gradle check result for d8ab19e: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
soosinha
force-pushed
the
decouple_remotestate
branch
from
d8ab19e
to
3f67648
Compare
|
❌ Gradle check result for 3f67648: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
Tagging @shwetathareja @psychbot for review. |
server/src/main/java/org/opensearch/node/remotestore/RemoteStoreNodeAttribute.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/node/remotestore/RemoteStoreNodeAttribute.java
Outdated
Show resolved
Hide resolved
server/src/test/java/org/opensearch/cluster/coordination/JoinTaskExecutorTests.java
Show resolved
Hide resolved
|
No other major comment, lets add new test cover new combination where remote state is enabled without remote store for segments. |
soosinha
force-pushed
the
decouple_remotestate
branch
from
33f810d
to
8e220e2
Compare
|
❌ Gradle check result for 8e220e2: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
Gradle check failure due to flaky test: #12593 |
Signed-off-by: Sooraj Sinha <soosinha@amazon.com>
Signed-off-by: Sooraj Sinha <soosinha@amazon.com>
Signed-off-by: Sooraj Sinha <soosinha@amazon.com>
Signed-off-by: Sooraj Sinha <soosinha@amazon.com>
soosinha
force-pushed
the
decouple_remotestate
branch
from
8e220e2
to
db7683c
Compare
|
❕ Gradle check result for db7683c: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
|
Gradle check failure due to flaky test: #10558 |
server/src/main/java/org/opensearch/node/remotestore/RemoteStoreNodeAttribute.java
Show resolved
Hide resolved
|
@soosinha : Would existing non-remote clusters be able to use remote state after upgrading to whatever the version we are targeting ? |
|
@gbbafna Yes Existing non-remote store clusters should be able to use remote state after upgrade. |
* Decouple remote state configuration Signed-off-by: Sooraj Sinha <soosinha@amazon.com> (cherry picked from commit 00d4b71) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* Decouple remote state configuration Signed-off-by: Sooraj Sinha <soosinha@amazon.com>
This reverts commit 00d4b71.
* Decouple remote state configuration (cherry picked from commit 00d4b71) Signed-off-by: Sooraj Sinha <soosinha@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* Decouple remote state configuration Signed-off-by: Sooraj Sinha <soosinha@amazon.com>
* Decouple remote state configuration Signed-off-by: Sooraj Sinha <soosinha@amazon.com> Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Description
For remote store, segment and translog repo need to be configured. For remote state, cluster state repo is required. But as per current logic either all three repos should be present or none of them should be preesnt. So remote state is tightly coupled with remote store.
This PR decouples the remote state setting so that it can be enabled or disabled as an independent feature.
Related Issues
#9884
Check List
Commit changes are listed out in CHANGELOG.md file (See: Changelog)Public documentation issue/PR createdBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.