Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.x] Fix yarn build docs and update test #845

Merged
merged 1 commit into from
Oct 5, 2021

Conversation

ananzh
Copy link
Member

@ananzh ananzh commented Oct 5, 2021

yarn build flags in /src/dev/build/cli.ts are not updated to match
the renamed flags in de-couple PR (#795). This PR fixes the issue
and update the tests. Also modify words in DEVELOPER_GUIDE.md.

PR resolved:
#836

Backport PR:
#840

Signed-off-by: Anan Zhuang ananzh@amazon.com

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

yarn build flags in /src/dev/build/cli.ts are not updated to match
the renamed flags in de-couple PR (opensearch-project#795). This PR fixes the issue
and update the tests. Also modify words in DEVELOPER_GUIDE.md.

PR resolved:
opensearch-project#836

Backport PR:
opensearch-project#840

Signed-off-by: Anan Zhuang <ananzh@amazon.com>
@ananzh ananzh added bug Something isn't working build Build related additions or modifications backport labels Oct 5, 2021
@ananzh ananzh self-assigned this Oct 5, 2021
@opensearch-ci-bot
Copy link
Collaborator

✅   DCO Check Passed 4e680e0

@ananzh ananzh merged commit 925c503 into opensearch-project:1.x Oct 5, 2021
@ananzh ananzh added the v1.2.0 label Nov 1, 2021
@ananzh ananzh deleted the 1.x-836 branch February 23, 2022 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working build Build related additions or modifications v1.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants