-
Notifications
You must be signed in to change notification settings - Fork 884
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] yarn build docs are incorrect #836
Labels
bug
Something isn't working
Comments
ananzh
added a commit
to ananzh/OpenSearch-Dashboards
that referenced
this issue
Oct 5, 2021
yarn build flags in /src/dev/build/cli.ts are not updated to match the renamed flags in de-couple PR (opensearch-project#795). This PR fixes the issue and update the tests. Also modify words in DEVELOPER_GUIDE.md. PR resolved: opensearch-project#836 Signed-off-by: Anan Zhuang <ananzh@amazon.com>
@dblock thanks so much for pointing out this bug. I submitted a PR to fix it. To build a specific platform:
Can also build multiple supported platforms. For example:
Also opened an issue in documentation-website and updated DEVELOPER_GUIDE.md. |
ananzh
added a commit
to ananzh/OpenSearch-Dashboards
that referenced
this issue
Oct 5, 2021
yarn build flags in /src/dev/build/cli.ts are not updated to match the renamed flags in de-couple PR (opensearch-project#795). This PR fixes the issue and update the tests. Also modify words in DEVELOPER_GUIDE.md. PR resolved: opensearch-project#836 Backport PR: opensearch-project#840 Signed-off-by: Anan Zhuang <ananzh@amazon.com>
ananzh
added a commit
to ananzh/OpenSearch-Dashboards
that referenced
this issue
Oct 5, 2021
yarn build flags in /src/dev/build/cli.ts are not updated to match the renamed flags in de-couple PR (opensearch-project#795). This PR fixes the issue and update the tests. Also modify words in DEVELOPER_GUIDE.md. PR resolved: opensearch-project#836 Backport PR: opensearch-project#840 Signed-off-by: Anan Zhuang <ananzh@amazon.com>
This was referenced Oct 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
Tried to use #795 as described in code/docs.
Expected behavior
The correct arguments are
--linux
and--linux-arm
. There might be other places like developer guide where this needs to be updated.The text was updated successfully, but these errors were encountered: