fix: update osd to respect new oui breakpoints #8320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Viraj Sanghvi <virajs@amazon.com>
7 tasks
virajsanghvi
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT,
xinruiba,
zhyuanqi,
mengweieric,
LDrago27,
sejli,
joshuali925 and
huyaboo
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8320 +/- ##
==========================================
- Coverage 64.14% 64.11% -0.03%
==========================================
Files 3743 3743
Lines 88836 88836
Branches 13852 13852
==========================================
- Hits 56981 56958 -23
- Misses 31240 31302 +62
+ Partials 615 576 -39
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
zhongnansu
approved these changes
Sep 24, 2024
Hailong-am
approved these changes
Sep 25, 2024
|
@SuZhou-Joe remember I've seen a PR from you that fix similar things, was that merged? |
ruanyl
approved these changes
Sep 25, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 25, 2024
* fix: update osd to respect new oui breakpoints Signed-off-by: Viraj Sanghvi <virajs@amazon.com> * Changeset file for PR #8320 created/updated --------- Signed-off-by: Viraj Sanghvi <virajs@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit d3b776d) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Yes, #8289 |
AMoo-Miki
pushed a commit
that referenced
this pull request
Sep 26, 2024
* fix: update osd to respect new oui breakpoints * Changeset file for PR #8320 created/updated --------- (cherry picked from commit d3b776d) Signed-off-by: Viraj Sanghvi <virajs@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
SuZhou-Joe
pushed a commit
to SuZhou-Joe/OpenSearch-Dashboards
that referenced
this pull request
Oct 3, 2024
…) (opensearch-project#8327) * fix: update osd to respect new oui breakpoints * Changeset file for PR opensearch-project#8320 created/updated --------- (cherry picked from commit d3b776d) Signed-off-by: Viraj Sanghvi <virajs@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
New breakpoints were added to OUI but OSD did not respect them, causing some bugs. This tries to address that by looking for consumption of breakpoints and just treating largest sizes like xl.
This incorporates #8289.
Issues Resolved
N/A
Screenshot
N/A
Testing the changes
Tested some of these cases locally.
Changelog
Check List
yarn test:jestyarn test:jest_integration