Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update osd to respect new oui breakpoints #8298

Closed
wants to merge 24 commits into from
Closed

fix: update osd to respect new oui breakpoints #8298

wants to merge 24 commits into from

Conversation

virajsanghvi
Copy link
Collaborator

@virajsanghvi virajsanghvi commented Sep 23, 2024 •
edited
Loading

Description

New breakpoints were added to OUI but OSD did not respect them, causing some bugs. This tries to address that by looking for consumption of breakpoints.

Issues Resolved

Screenshot

Testing the changes

Changelog

  • fix: update osd to respect new oui breakpoints

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@virajsanghvi
fix: update osd to respect new oui breakpoints
67a0e89 
Signed-off-by: Viraj Sanghvi <virajs@amazon.com>
@github-actions GitHub Actions
Copy link
Contributor

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

@codecov Codecov
Copy link

codecov bot commented Sep 23, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.14%. Comparing base (6ebc1e3) to head (313df10).
Report is 14 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #8298      +/-   ##
==========================================
+ Coverage   64.05%   64.14%   +0.08%     
==========================================
  Files        3741     3743       +2     
  Lines       88682    88833     +151     
  Branches    13817    13852      +35     
==========================================
+ Hits        56809    56980     +171     
+ Misses      31261    31238      -23     
- Partials      612      615       +3
Flag Coverage Δ
Linux_1 30.07% <ø> (+0.01%) ⬆️
Linux_2 58.86% <ø> (+<0.01%) ⬆️
Linux_3 40.36% <ø> (+0.01%) ⬆️
Linux_4 31.58% <ø> (+0.14%) ⬆️
Windows_1 30.08% <ø> (+0.01%) ⬆️
Windows_2 58.81% <ø> (+<0.01%) ⬆️
Windows_3 40.36% <ø> (+0.01%) ⬆️
Windows_4 31.58% <ø> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

virajsanghvi and others added 21 commits September 23, 2024 23:23
@virajsanghvi
add additional cases
313df10 
Signed-off-by: Viraj Sanghvi <virajs@amazon.com>
@virajsanghvi @opensearch-changeset-bot
chore: Update oui to 1.13 (opensearch-project#8246)
f8a5fb2 
* chore: Update oui to 1.13

Signed-off-by: Viraj Sanghvi <virajs@amazon.com>

* Changeset file for PR opensearch-project#8246 created/updated

* update snapshot tests

Signed-off-by: Viraj Sanghvi <virajs@amazon.com>

* update snapshot tests

Signed-off-by: Viraj Sanghvi <virajs@amazon.com>

---------

Signed-off-by: Viraj Sanghvi <virajs@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
@AMoo-Miki @opensearch-changeset-bot @virajsanghvi
Use @osd/std to prettify objects for display (opensearch-project#8232)
cff56e1 
* Use @osd/std to stringify JSON when formatting objects for display

Signed-off-by: Miki <miki@amazon.com>

* Changeset file for PR opensearch-project#8232 created/updated

---------

Signed-off-by: Miki <miki@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
@LDrago27 @virajsanghvi
Set Legacy Discover Table for Discover 2.0 (opensearch-project#8233)
1b8b8a7 
Signed-off-by: Suchit Sahoo <suchsah@amazon.com>
@Hailong-am @opensearch-changeset-bot @virajsanghvi
[Workspace] Drop user personal settings page (opensearch-project#8236)
d1799e3 
* drop user personal settings page

Signed-off-by: Hailong Cui <ihailong@amazon.com>

* Changeset file for PR opensearch-project#8236 created/updated

* remove unuse code

Signed-off-by: Hailong Cui <ihailong@amazon.com>

---------

Signed-off-by: Hailong Cui <ihailong@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
@chishui @virajsanghvi
Add data summary panel in discover (opensearch-project#8186)
d27f18f 
* Add data summary panel in discover

Signed-off-by: Liyun Xiu <xiliyun@amazon.com>

* Fix UTs

Signed-off-by: Liyun Xiu <xiliyun@amazon.com>

* Add changelog

Signed-off-by: Liyun Xiu <xiliyun@amazon.com>

* Fix UTs

Signed-off-by: Liyun Xiu <xiliyun@amazon.com>

* Address comments

Signed-off-by: Liyun Xiu <xiliyun@amazon.com>

* Address comments

Signed-off-by: Liyun Xiu <xiliyun@amazon.com>

* Address comments

Signed-off-by: Liyun Xiu <xiliyun@amazon.com>

---------

Signed-off-by: Liyun Xiu <xiliyun@amazon.com>
@yubonluo @opensearch-changeset-bot @virajsanghvi
[Bug] Fix: use workspace type icons and compressed input (opensearch-…
0ba8c94 
…project#8215)

* fix home page issue

Signed-off-by: yubonluo <yubonluo@amazon.com>

* Changeset file for PR opensearch-project#8215 created/updated

---------

Signed-off-by: yubonluo <yubonluo@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
@raintygao @opensearch-changeset-bot
@SuZhou-Joe @virajsanghvi
[Workspace] Integrate workspace front end with data connection type s…
a41bfcd 
…aved object (opensearch-project#8013)

* feat: integrate workspace with data connections

Signed-off-by: tygao <tygao@amazon.com>

* update workspace pages and hooks to integrate with data connection

Signed-off-by: tygao <tygao@amazon.com>

* Changeset file for PR opensearch-project#8013 created/updated

* remove extra comments

Signed-off-by: tygao <tygao@amazon.com>

* update data source import

Signed-off-by: tygao <tygao@amazon.com>

* test: update tests

Signed-off-by: tygao <tygao@amazon.com>

* Changeset file for PR opensearch-project#8013 created/updated

* unify connection type icon and connectionType

Signed-off-by: tygao <tygao@amazon.com>

* test: add tests

Signed-off-by: tygao <tygao@amazon.com>

* display text directly instead of link for data connection in table

Signed-off-by: tygao <tygao@amazon.com>

* Apply suggestions from code review

Co-authored-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: Tianyu Gao <tygao@amazon.com>

* update

Signed-off-by: tygao <tygao@amazon.com>

---------

Signed-off-by: tygao <tygao@amazon.com>
Signed-off-by: Tianyu Gao <tygao@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Co-authored-by: SuZhou-Joe <suzhou@amazon.com>
@yubonluo @opensearch-changeset-bot @virajsanghvi
[Bug] Fix initial page UI issues (opensearch-project#8217)
0e9354d 
* fix initial page ui issue

Signed-off-by: yubonluo <yubonluo@amazon.com>

* Changeset file for PR opensearch-project#8217 created/updated

* fix test error

Signed-off-by: yubonluo <yubonluo@amazon.com>

---------

Signed-off-by: yubonluo <yubonluo@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
@abbyhu2000 @opensearch-changeset-bot @virajsanghvi
Add loading indicator and counter to query result (opensearch-project…
e415131 
…#8212)

* add loading indicator and counter to query result

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* Changeset file for PR opensearch-project#8212 created/updated

* add unit tests

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* address comments

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* update snapshot

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

---------

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
@AMoo-Miki @opensearch-changeset-bot @virajsanghvi
Temporary fix for a bug with Chrome 129 when handling mask-image (ope…
85b8f1a 
…nsearch-project#8274)

* Temporary fix for a bug with Chrome 129 when handling mask-image

Signed-off-by: Miki <miki@amazon.com>

* Changeset file for PR opensearch-project#8274 created/updated

---------

Signed-off-by: Miki <miki@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
@kavilla @opensearch-changeset-bot @virajsanghvi
[discover] Clean up enhanced search API (opensearch-project#8226)
d54f456 
* Clean up enhanced search API

* Deletes the connections service.
* Removes dataframe object being passed into request
* Deletes unused APIs

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* Changeset file for PR opensearch-project#8226 created/updated

---------

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
@abbyhu2000 @opensearch-changeset-bot @virajsanghvi
Fix running recent query button (opensearch-project#8252)
92fc86e 
* Fix click on recent query switching language

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* change to use uuid as identifier

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* Changeset file for PR opensearch-project#8252 created/updated

---------

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
@amsiglan @opensearch-changeset-bot @virajsanghvi
Expose method to register search strategy routes in query enhancement (…
a71b448 
…opensearch-project#8245)

* exposed method to register search strategy routes

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

* Changeset file for PR opensearch-project#8245 created/updated

* addressed comment

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

* fix linter error

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

---------

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
@amsiglan @opensearch-changeset-bot @virajsanghvi
Expose datasets and data_frames directories for specific imports (ope…
7f9981a 
…nsearch-project#8299)

* expose datasets and data_frames directories for specific imports

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

* Changeset file for PR opensearch-project#8299 created/updated

---------

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
@ruanyl @virajsanghvi
remove unnecessary multiple data source doc link (opensearch-project#…
880fba0 
…8308)

Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
@Hailong-am @virajsanghvi
exclude https://sites.google.com/site/murmurhash from link check (ope…
9614d6b 
…nsearch-project#8309)

Signed-off-by: Hailong Cui <ihailong@amazon.com>
@ruanyl @virajsanghvi
test(usage_collection): expose a function to mock plugin start (opens…
89a0776 
…earch-project#8235)

Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
@SuZhou-Joe @virajsanghvi
[navigation]fix: add xxl and xxxl for left nav responsiveness (opense…
571a35d 
…arch-project#8289)

* fix: add xxl and xxxl

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: update

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: update snapshot

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

---------

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
@virajsanghvi
fix: update osd to respect new oui breakpoints
d79c8c2 
Signed-off-by: Viraj Sanghvi <virajs@amazon.com>
@virajsanghvi
update additional cases of breakpoints
1292b56 
Signed-off-by: Viraj Sanghvi <virajs@amazon.com>
@virajsanghvi
Copy link
Collaborator Author

Moved to #8320

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ananzh ananzh Awaiting requested review from ananzh ananzh will be requested when the pull request is marked ready for review ananzh is a code owner

@kavilla kavilla Awaiting requested review from kavilla kavilla will be requested when the pull request is marked ready for review kavilla is a code owner

@AMoo-Miki AMoo-Miki Awaiting requested review from AMoo-Miki AMoo-Miki will be requested when the pull request is marked ready for review AMoo-Miki is a code owner

@ashwin-pc ashwin-pc Awaiting requested review from ashwin-pc ashwin-pc will be requested when the pull request is marked ready for review ashwin-pc is a code owner

@joshuarrrr joshuarrrr Awaiting requested review from joshuarrrr joshuarrrr will be requested when the pull request is marked ready for review joshuarrrr is a code owner

@abbyhu2000 abbyhu2000 Awaiting requested review from abbyhu2000 abbyhu2000 will be requested when the pull request is marked ready for review abbyhu2000 is a code owner

@zengyan-amazon zengyan-amazon Awaiting requested review from zengyan-amazon zengyan-amazon will be requested when the pull request is marked ready for review zengyan-amazon is a code owner

@zhongnansu zhongnansu Awaiting requested review from zhongnansu zhongnansu will be requested when the pull request is marked ready for review zhongnansu is a code owner

@manasvinibs manasvinibs Awaiting requested review from manasvinibs manasvinibs will be requested when the pull request is marked ready for review manasvinibs is a code owner

@ZilongX ZilongX Awaiting requested review from ZilongX ZilongX will be requested when the pull request is marked ready for review ZilongX is a code owner

@Flyingliuhub Flyingliuhub Awaiting requested review from Flyingliuhub Flyingliuhub will be requested when the pull request is marked ready for review Flyingliuhub is a code owner

@curq curq Awaiting requested review from curq curq will be requested when the pull request is marked ready for review curq is a code owner

@bandinib-amzn bandinib-amzn Awaiting requested review from bandinib-amzn bandinib-amzn will be requested when the pull request is marked ready for review bandinib-amzn is a code owner

@SuZhou-Joe SuZhou-Joe Awaiting requested review from SuZhou-Joe SuZhou-Joe will be requested when the pull request is marked ready for review SuZhou-Joe is a code owner

@ruanyl ruanyl Awaiting requested review from ruanyl ruanyl will be requested when the pull request is marked ready for review ruanyl is a code owner

@BionIT BionIT Awaiting requested review from BionIT BionIT will be requested when the pull request is marked ready for review BionIT is a code owner

@xinruiba xinruiba Awaiting requested review from xinruiba xinruiba will be requested when the pull request is marked ready for review xinruiba is a code owner

@zhyuanqi zhyuanqi Awaiting requested review from zhyuanqi zhyuanqi will be requested when the pull request is marked ready for review zhyuanqi is a code owner

@mengweieric mengweieric Awaiting requested review from mengweieric mengweieric will be requested when the pull request is marked ready for review mengweieric is a code owner

@LDrago27 LDrago27 Awaiting requested review from LDrago27 LDrago27 will be requested when the pull request is marked ready for review LDrago27 is a code owner

@sejli sejli Awaiting requested review from sejli sejli will be requested when the pull request is marked ready for review sejli is a code owner

@joshuali925 joshuali925 Awaiting requested review from joshuali925 joshuali925 will be requested when the pull request is marked ready for review joshuali925 is a code owner

@huyaboo huyaboo Awaiting requested review from huyaboo huyaboo will be requested when the pull request is marked ready for review huyaboo is a code owner

Assignees
No one assigned
Labels
valued-contributor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.