Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failed snapshots after oui upgrade #8288

Conversation

wanglam
Copy link
Contributor

@wanglam wanglam commented Sep 23, 2024

Description

This PR is for fixing failed snapshots in following files after oui upgrade.

  • src/core/public/chrome/ui/header/snapshots/header.test.tsx.snap
  • src/plugins/data_source_management/public/components/data_source_table/snapshots/data_source_table.test.tsx.snap
  • src/plugins/data_source_management/public/components/direct_query_data_sources_components/direct_query_data_connection/snapshots/manage_direct_query_data_connections_table.test.tsx.snap

Issues Resolved

#8290

Screenshot

No UI Changes

Testing the changes

  • Clone branch to local
  • Run yarn osd bootstrap
  • Run yarn test:jest
  • Should no failed unit tests

Changelog

  • fix: Fix failed snapshots after oui upgrade

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Signed-off-by: Lin Wang <wonglam@amazon.com>
Copy link

codecov bot commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.12%. Comparing base (f6924a7) to head (10817df).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8288      +/-   ##
==========================================
- Coverage   64.14%   64.12%   -0.02%     
==========================================
  Files        3743     3743              
  Lines       88833    88833              
  Branches    13852    13852              
==========================================
- Hits        56979    56968      -11     
- Misses      31239    31289      +50     
+ Partials      615      576      -39     
Flag Coverage Δ
Linux_1 30.07% <ø> (ø)
Linux_2 ?
Linux_4 31.58% <ø> (ø)
Windows_1 30.10% <ø> (+0.01%) ⬆️
Windows_2 58.81% <ø> (ø)
Windows_3 40.36% <ø> (ø)
Windows_4 31.58% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wanglam wanglam closed this Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant