[Build] use saved legacy config for 1.x #743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An original update to enable taking settings from a valid legacy version and applying to current OpenSearch Dashboards was made here: opensearch-project#485 However, it explicitly checked for current version being 1.0.0, which is too strict because ideally all versions of 1.x is compatible. This makes the config check more relaxed and will taking settings from a legacy version if the current version is 1.x. Issue resolved: opensearch-project#741 Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
|
✅ DCO Check Passed ce8831a |
tmarkley
approved these changes
Aug 31, 2021
kavilla
added a commit
to kavilla/OpenSearch-Dashboards-1
that referenced
this pull request
Aug 31, 2021
An original update to enable taking settings from a valid legacy version and applying to current OpenSearch Dashboards was made here: opensearch-project#485 However, it explicitly checked for current version being 1.0.0, which is too strict because ideally all versions of 1.x is compatible. This makes the config check more relaxed and will taking settings from a legacy version if the current version is 1.x. Issue resolved: opensearch-project#741 Backport PR: opensearch-project#743 Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
kavilla
added a commit
that referenced
this pull request
Aug 31, 2021
An original update to enable taking settings from a valid legacy version and applying to current OpenSearch Dashboards was made here: #485 However, it explicitly checked for current version being 1.0.0, which is too strict because ideally all versions of 1.x is compatible. This makes the config check more relaxed and will taking settings from a legacy version if the current version is 1.x. Issue resolved: #741 Backport PR: #743 Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
kavilla
added a commit
to kavilla/OpenSearch-Dashboards-1
that referenced
this pull request
Sep 1, 2021
An original update to enable taking settings from a valid legacy version and applying to current OpenSearch Dashboards was made here: opensearch-project#485 However, it explicitly checked for current version being 1.0.0, which is too strict because ideally all versions of 1.x is compatible. This makes the config check more relaxed and will taking settings from a legacy version if the current version is 1.x. Issue resolved: opensearch-project#741 Backport PR: opensearch-project#743 Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
kavilla
added a commit
that referenced
this pull request
Sep 1, 2021
An original update to enable taking settings from a valid legacy version and applying to current OpenSearch Dashboards was made here: #485 However, it explicitly checked for current version being 1.0.0, which is too strict because ideally all versions of 1.x is compatible. This makes the config check more relaxed and will taking settings from a legacy version if the current version is 1.x. Issue resolved: #741 Backport PR: #743 Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
An original update to enable taking settings from a valid legacy
version and applying to current OpenSearch Dashboards was made
here:
#485
However, it explicitly checked for current version being 1.0.0, which
is too strict because ideally all versions of 1.x is compatible.
This makes the config check more relaxed and will taking settings from
a legacy version if the current version is 1.x.
Signed-off-by: Kawika Avilla kavilla414@gmail.com
Issues Resolved
#741
Check List