Support config upgrades from Kibana v7.10.x directly to OpenSearch Dashboards v1.1

[shawnz]

Hi there, I am writing to request explicit support for an upgrade path from Kibana v7.10.x directly to OpenSearch Dashboards v1.1.

I am not sure if this is already planned, but in this patchset #485 I noticed the following line of code:

OpenSearch-Dashboards/src/core/server/ui_settings/create_or_upgrade_saved_config/is_config_version_upgradeable.ts

Line 78 in a60c4a3

const currentVersionIsVersion1 = semver.eq(opensearchDashboardsReleaseVersion, '1.0.0');

This seems to indicate that at the current time, only v1.0 will support that upgrade path.

The reason why I would like to be able to upgrade directly to v1.1 is because v1.0 will not be provided as an RPM package. Since we are currently using the ODFE RPM packages, it would be inconvenient if we could not upgrade directly to v1.1.

Further discussion:

#334 (comment)
opensearch-project/OpenSearch#671 (comment)

Thanks for reading, and my apologies if this is already planned.

Shawn

[kavilla]

Hello @shawnz, thanks for opening this.

Great catch, OpenSearch Dashboards should pretty much support direct upgrades from Kibana 7.x (verified for at least 7.10.2). The line of code you are referencing is basically for carrying over any advanced settings you have. Since what OpenSearch Dashboards is doing is checking your current version of the application and looking for any advanced settings that exist prior to it's current version, but since we went from a higher version to a lower version it wasn't able to find any original settings.

Ideally we were thinking you should have to go from a previous version to 1.0 first but that has changed. So if you go from Kibana 7.10.x to OpenSearch Dashboards 1.1, everything should be carried over it's just it won't directly apply your advanced settings if you have any set. For example, if you set dark mode in 7.10.x, you would expect to see dark mode set in OpenSearch Dashboards. Your advanced settings for 7.10.x will actually still exist and you can still it as a saved object so a workaround would be carrying over the values you set to the config for 1.1.0. But that is a bad experience so we should fix this to relax the version check. We definitely will want to keep this version check for at least 1.x, so we don't get in a weird state if OpenSearch does get to 7.10.x then this code might break some expected functionality.

[shawnz]

Thank you for the notice! Good to know as we don't really rely on any Kibana advanced settings anyway.