Fix (TableVis): Properly filter table columns when sending to filter …

[joshuarrrr]

Description

…event handler

This ensures that the column and row indices match the table cell being renderered.

Note that this is a quick fix - long term, we also want a regression test (to validate that filter actions apply the right data), as well as some refactoring of this handler; it seems a little sill to pass both the entire table and column/row indices rather than the direct reference or even value.

Issues Resolved

fixes #5612

Screenshot

Testing the changes

Can validate via the steps in the linked issue.

Check List

• All tests pass
  • yarn test:jest
  • yarn test:jest_integration
• New functionality includes testing.
• New functionality has been documented.
• Update CHANGELOG.md
• Commits are signed per the DCO using --signoff

[codecov]

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (bbd40e1) 66.97% compared to head (0e0f08c) 66.97%.

Files	Patch %	Lines
...table/public/components/table_vis_grid_columns.tsx	0.00%	2 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #5619   +/-   ##
=======================================
  Coverage   66.97%   66.97%           
=======================================
  Files        3301     3301           
  Lines       63437    63439    +2     
  Branches    10107    10107           
=======================================
+ Hits        42485    42487    +2     
- Misses      18499    18503    +4     
+ Partials     2453     2449    -4     

Flag	Coverage Δ
Linux_1	35.22% <0.00%> (-0.01%)	⬇️
Linux_2	55.11% <ø> (ø)
Linux_3	43.93% <ø> (+<0.01%)	⬆️
Linux_4	35.27% <ø> (ø)
Windows_1	35.25% <0.00%> (-0.01%)	⬇️
Windows_2	55.08% <ø> (ø)
Windows_3	43.94% <ø> (ø)
Windows_4	35.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[ananzh]

do we want to add a test in the fun tst repo?

[joshuarrrr]

do we want to add a test in the fun tst repo?

Yeah, I think the regression test would best belong there. But I don't think there will be time to do that for 2.12.

[opensearch-trigger-bot]

The backport to 2.11 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.11 2.11
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.11
# Create a new branch
git switch --create backport/backport-5619-to-2.11
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 3e2293957c2bca6b17029b238ba077f86236b87d
# Push it to GitHub
git push --set-upstream origin backport/backport-5619-to-2.11
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.11

Then, create a pull request where the base branch is 2.11 and the compare/head branch is backport/backport-5619-to-2.11.