Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix (TableVis): Properly filter table columns when sending to filter … #5619

Merged
merged 4 commits into from
Feb 6, 2024
Merged

Fix (TableVis): Properly filter table columns when sending to filter … #5619

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6c8b34d
Fix (TableVis): Properly filter table columns when sending to filter …
joshuarrrr Dec 15, 2023
1a0f099
Merge branch 'main' into fix/table-vis-filter-split-table
joshuarrrr Feb 5, 2024
78b4515
add changelog
joshuarrrr Feb 5, 2024
0e0f08c
Merge branch 'main' into fix/table-vis-filter-split-table
ashwin-pc Feb 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@ Inspired from [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
- [Discover] Fix missing index pattern field from breaking Discover [#5626](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/5626)
- [BUG] Remove duplicate sample data as id 90943e30-9a47-11e8-b64d-95841ca0b247 ([5668](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/5668))
- [BUG][Multiple Datasource] Fix datasource testing connection unexpectedly passed with wrong endpoint [#5663](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/5663)
- [Table Visualization] Fix filter action buttons for split table aggregations ([#5619](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/5619))
- [BUG][Multiple Datasource] Datasource id is required if multiple datasource is enabled and no default cluster supported [#5751](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/5751)

### 🚞 Infrastructure
Expand Down
3 changes: 2 additions & 1 deletion src/plugins/vis_type_table/public/components/table_vis_grid_columns.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,14 +15,15 @@
event: IInterpreterRenderHandlers['event'],
columnWidths: ColumnWidth[]
) => {
const formattedColumnIds = table.formattedColumns.map((column) => column.id);

Check warning on line 18 in src/plugins/vis_type_table/public/components/table_vis_grid_columns.tsx

View check run for this annotation

Codecov / codecov/patch

src/plugins/vis_type_table/public/components/table_vis_grid_columns.tsx#L18 

Added line #L18 was not covered by tests
wbeckler marked this conversation as resolved.
Show resolved Hide resolved
const filterBucket = (rowIndex: number, columnIndex: number, negate: boolean) => {
event({
name: 'filterBucket',
data: {
data: [
{
table: {
columns: table.columns,
columns: table.columns.filter((column) => formattedColumnIds.includes(column.id)),

Check warning on line 26 in src/plugins/vis_type_table/public/components/table_vis_grid_columns.tsx

View check run for this annotation

Codecov / codecov/patch

src/plugins/vis_type_table/public/components/table_vis_grid_columns.tsx#L26 

Added line #L26 was not covered by tests
rows: table.rows,
},
row: rowIndex,
Expand Down
Loading